[kphotoalbum] [Bug 474151] KPhotoAlbum crashes when Annotations are not saved and then user right-clicks Show Info in Viewer
https://bugs.kde.org/show_bug.cgi?id=474151 Johannes Zarl-Zierl changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #10 from Johannes Zarl-Zierl --- Thanks for the confirmation! -- You are receiving this mail because: You are watching all bug changes.
[kphotoalbum] [Bug 474151] KPhotoAlbum crashes when Annotations are not saved and then user right-clicks Show Info in Viewer
https://bugs.kde.org/show_bug.cgi?id=474151 --- Comment #9 from Victor Lobo --- This bug is fixed. Thank you Johannes. Please close it. -- You are receiving this mail because: You are watching all bug changes.
[kphotoalbum] [Bug 474151] KPhotoAlbum crashes when Annotations are not saved and then user right-clicks Show Info in Viewer
https://bugs.kde.org/show_bug.cgi?id=474151 --- Comment #8 from Johannes Zarl-Zierl --- Hi Victor, I think I fixed this with the a195619fcc1f0de68f41a86154eb0425f3605ffb commit and just forgot to close the bug. Can you verify that the bug is now fixed for you? Cheers, Johannes -- You are receiving this mail because: You are watching all bug changes.
[kphotoalbum] [Bug 474151] KPhotoAlbum crashes when Annotations are not saved and then user right-clicks Show Info in Viewer
https://bugs.kde.org/show_bug.cgi?id=474151 --- Comment #7 from Johannes Zarl-Zierl --- Git commit a195619fcc1f0de68f41a86154eb0425f3605ffb by Johannes Zarl-Zierl. Committed on 02/10/2023 at 22:56. Pushed by johanneszarl into branch 'master'. Fix crash when closing the annotation dialog with positionable tags Make API harder to misuse by unsetting m_areasChanged in tidyAreas() instead of doing this in the calling code. M +3-4AnnotationDialog/Dialog.cpp https://invent.kde.org/graphics/kphotoalbum/-/commit/a195619fcc1f0de68f41a86154eb0425f3605ffb -- You are receiving this mail because: You are watching all bug changes.
[kphotoalbum] [Bug 474151] KPhotoAlbum crashes when Annotations are not saved and then user right-clicks Show Info in Viewer
https://bugs.kde.org/show_bug.cgi?id=474151
Victor Lobo changed:
What|Removed |Added
Resolution|FIXED |---
Status|RESOLVED|REOPENED
--- Comment #6 from Victor Lobo ---
Reopening this bug since the same crash still occurs in the following scenario
in git master.
STEPS TO REPRODUCE
1. Open KPhotoAlbum
2. Go to Thumbnail View
3. Go to Annotations window for any image or video (CTRL + 1)
4. Add a positionable tag in the Annotation Window
5. Click DONE in Annotations window
6. Open any image or video in Viewer (press Enter)
7. Go to Info in the right-click context menu in Viewer. ("Discard Changes?"
popup dialog is displayed)
8. Click Discard or Cancel in "Discard Changes?" popup dialog
9. Crash
--
You are receiving this mail because:
You are watching all bug changes.
[kphotoalbum] [Bug 474151] KPhotoAlbum crashes when Annotations are not saved and then user right-clicks Show Info in Viewer
https://bugs.kde.org/show_bug.cgi?id=474151 --- Comment #5 from Johannes Zarl-Zierl --- Ok, now I know how this slipped through: I tried by marking a person (that is already there) on an image using a positionable tag. Having a change in positionable tags does still trigger the prompt. Adding a tag does not. -- You are receiving this mail because: You are watching all bug changes.
[kphotoalbum] [Bug 474151] KPhotoAlbum crashes when Annotations are not saved and then user right-clicks Show Info in Viewer
https://bugs.kde.org/show_bug.cgi?id=474151 --- Comment #4 from Johannes Zarl-Zierl --- Hi Victor, No, that was not intentional, but a result of late-night coding... Thanks for being thorough! Cheers, Johannes -- You are receiving this mail because: You are watching all bug changes.
[kphotoalbum] [Bug 474151] KPhotoAlbum crashes when Annotations are not saved and then user right-clicks Show Info in Viewer
https://bugs.kde.org/show_bug.cgi?id=474151 --- Comment #3 from Victor Lobo --- Hi Johannes, Yes, this fixes the crash. However, I want to point out that when I make changes in the Annotations window and click Cancel, I am no longer prompted to save my changes. I assume this was intentional with the latest commit, but not sure. Thank you! Victor -- You are receiving this mail because: You are watching all bug changes.
[kphotoalbum] [Bug 474151] KPhotoAlbum crashes when Annotations are not saved and then user right-clicks Show Info in Viewer
https://bugs.kde.org/show_bug.cgi?id=474151 --- Comment #2 from Johannes Zarl-Zierl --- Hi Victor! I believe the bug is fixed by the latest commit... Cheers, Johannes -- You are receiving this mail because: You are watching all bug changes.
[kphotoalbum] [Bug 474151] KPhotoAlbum crashes when Annotations are not saved and then user right-clicks Show Info in Viewer
https://bugs.kde.org/show_bug.cgi?id=474151 Johannes Zarl-Zierl changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit||https://invent.kde.org/grap ||hics/kphotoalbum/-/commit/7 ||d035923cafb6418ae3d58f571c7 ||3a608e84fb30 Resolution|--- |FIXED --- Comment #1 from Johannes Zarl-Zierl --- Git commit 7d035923cafb6418ae3d58f571c73a608e84fb30 by Johannes Zarl-Zierl. Committed on 09/09/2023 at 01:44. Pushed by johanneszarl into branch 'master'. Fix crash when annotation dialog is closed without saving... ...and the user then opens the context menu in the viewer window. M +23 -2AnnotationDialog/Dialog.cpp M +1-1AnnotationDialog/Dialog.h https://invent.kde.org/graphics/kphotoalbum/-/commit/7d035923cafb6418ae3d58f571c73a608e84fb30 -- You are receiving this mail because: You are watching all bug changes.
[kphotoalbum] [Bug 474151] KPhotoAlbum crashes when Annotations are not saved and then user right-clicks Show Info in Viewer
https://bugs.kde.org/show_bug.cgi?id=474151 Johannes Zarl-Zierl changed: What|Removed |Added CC||johan...@zarl-zierl.at Status|REPORTED|CONFIRMED Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
