[krdc] [Bug 486178] VNC plugin deadlocks on connection
https://bugs.kde.org/show_bug.cgi?id=486178 Nicolas Fella changed: What|Removed |Added Latest Commit|https://invent.kde.org/netw |https://invent.kde.org/netw |ork/krdc/-/commit/48fbcdffc |ork/krdc/-/commit/e6a169e40 |4ff22a11b56d8809739e0f096d1 |b80b4fcd5e42dbba17d82f3f7bf |90e6|4feb --- Comment #6 from Nicolas Fella --- Git commit e6a169e40b80b4fcd5e42dbba17d82f3f7bf4feb by Nicolas Fella, on behalf of Thiago Macieira. Committed on 08/06/2024 at 18:42. Pushed by nicolasfella into branch 'release/24.05'. VNC: replace m_stopped with QThread's interruptionRequested It's an out-of-line function call, but it doesn't require a mutex for most uses. The uses in the callbacks are replaced with isRunning(), because interruptionRequested resets back to false as soon as run() exits. (cherry picked from commit 33f89ef0bb4f5186dad7ceecad599a0e834e7f88) M +14 -24 vnc/vncclientthread.cpp M +0-1vnc/vncclientthread.h https://invent.kde.org/network/krdc/-/commit/e6a169e40b80b4fcd5e42dbba17d82f3f7bf4feb -- You are receiving this mail because: You are watching all bug changes.
[krdc] [Bug 486178] VNC plugin deadlocks on connection
https://bugs.kde.org/show_bug.cgi?id=486178 Thiago Macieira changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 Severity|normal |critical -- You are receiving this mail because: You are watching all bug changes.
[krdc] [Bug 486178] VNC plugin deadlocks on connection
https://bugs.kde.org/show_bug.cgi?id=486178 Nicolas Fella changed: What|Removed |Added Severity|critical|grave CC||nicolas.fe...@gmx.de -- You are receiving this mail because: You are watching all bug changes.
[krdc] [Bug 486178] VNC plugin deadlocks on connection
https://bugs.kde.org/show_bug.cgi?id=486178 --- Comment #1 from Thiago Macieira --- I'd say "vncplugin doesn't work at all, ever, under any conditions, if you try to use it" is sufficient for "critical", but ok for "grave" BTW, I tried to fix that function myself. I can apply a workaround to just restore the previous behaviour, but that's papering over the sun with a sieve. I really don't understand what's going on and what is being locked. Is it trying to protect m_stopped? Why not use an atomic instead? Or, better, QThread::isInterruptionRequested()? But on line 549, it accesses m_stopped without a mutex, so I don't know if it needed protecting in the first place. Ditto for m_passwordError: why not an atomic? Or why not use a local variable and only lock to save the state when exiting the function? This code should be rewritten with closer locks, not that one QMutexLocker at the top that is used incorrectly. -- You are receiving this mail because: You are watching all bug changes.
[krdc] [Bug 486178] VNC plugin deadlocks on connection
https://bugs.kde.org/show_bug.cgi?id=486178 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #2 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/network/krdc/-/merge_requests/99 -- You are receiving this mail because: You are watching all bug changes.
[krdc] [Bug 486178] VNC plugin deadlocks on connection
https://bugs.kde.org/show_bug.cgi?id=486178 Nicolas Fella changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/netw ||ork/krdc/-/commit/48fbcdffc ||4ff22a11b56d8809739e0f096d1 ||90e6 --- Comment #3 from Nicolas Fella --- Git commit 48fbcdffc4ff22a11b56d8809739e0f096d190e6 by Nicolas Fella, on behalf of Thiago Macieira. Committed on 30/04/2024 at 22:45. Pushed by nicolasfella into branch 'release/24.02'. VNC: replace m_stopped with QThread's interruptionRequested It's an out-of-line function call, but it doesn't require a mutex for most uses. The uses in the callbacks are replaced with isRunning(), because interruptionRequested resets back to false as soon as run() exits. (cherry picked from commit 33f89ef0bb4f5186dad7ceecad599a0e834e7f88) M +14 -24 vnc/vncclientthread.cpp M +0-1vnc/vncclientthread.h https://invent.kde.org/network/krdc/-/commit/48fbcdffc4ff22a11b56d8809739e0f096d190e6 -- You are receiving this mail because: You are watching all bug changes.
[krdc] [Bug 486178] VNC plugin deadlocks on connection
https://bugs.kde.org/show_bug.cgi?id=486178 Stefan Becker changed: What|Removed |Added CC||chemob...@gmail.com --- Comment #4 from Stefan Becker --- *** Bug 485215 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krdc] [Bug 486178] VNC plugin deadlocks on connection
https://bugs.kde.org/show_bug.cgi?id=486178 --- Comment #5 from Stefan Becker --- I can confirm that after applying the patch VNC connections work again with krdc. -- You are receiving this mail because: You are watching all bug changes.
[krdc] [Bug 486178] VNC plugin deadlocks on connection
https://bugs.kde.org/show_bug.cgi?id=486178 Vasyl Demin changed: What|Removed |Added CC||vasyl.de...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
