[krita] [Bug 347755] Crash when loading file containing layer with warp transform mask

[Boudewijn Rempt via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=347755

Boudewijn Rempt  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #8 from Boudewijn Rempt  ---
Fixed in a053a73edf5f89eb94895962457d8ff743bef40c

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 347755] Crash when loading file containing layer with warp transform mask

[Maks Naumov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=347755

Maks Naumov  changed:

   What|Removed |Added

 CC||maksq...@ukr.net

--- Comment #7 from Maks Naumov  ---
(In reply to Dmitry Kazakov from comment #6)
> Git commit 241ddd4ec56b58172e631596696c4ea369e52a05 by Dmitry Kazakov.
> Committed on 14/04/2016 at 14:47.
> Pushed by dkazakov into branch 'master'.
> 
> Make transform mask return a change rect for the non-affine transoforms as
> well

You have two typos in the patch:
QRect KisCageTransformWorker::approxChangeRect(const QRect )
{
const int margin = 0.30;  // 

return KisAlgebra2D::blowRect(resultRect | rc, margin);
}

and

QRect KisLiquifyTransformWorker::approxChangeRect(const QRect )
{
const int margin = 0.05; // 

return KisAlgebra2D::blowRect(resultRect | rc, margin);
}

In this cases int equals zero. It should be qreal.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 347755] Crash when loading file containing layer with warp transform mask

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=347755

--- Comment #6 from Dmitry Kazakov  ---
Git commit 241ddd4ec56b58172e631596696c4ea369e52a05 by Dmitry Kazakov.
Committed on 14/04/2016 at 14:47.
Pushed by dkazakov into branch 'master'.

Make transform mask return a change rect for the non-affine transoforms as well

We have to use really rough approximations for calculating the change
rect of cage, warp and liquify transformation. The main problem is that
there is no explicit f(x) solution for most of them (except for warp).
So we should be a bit tricky.

M  +1-1libs/image/kis_async_merger.cpp
M  +1-1libs/image/kis_base_rects_walker.h
M  +60   -0libs/image/kis_cage_transform_worker.cpp
M  +3-0libs/image/kis_cage_transform_worker.h
M  +28   -0libs/image/kis_liquify_transform_worker.cpp
M  +3-0libs/image/kis_liquify_transform_worker.h
M  +35   -20   libs/image/kis_transform_mask.cpp
M  +11   -0libs/image/kis_transform_mask_params_interface.cpp
M  +6-0libs/image/kis_transform_mask_params_interface.h
M  +18   -0libs/image/kis_warptransform_worker.cc
M  +4-1libs/image/kis_warptransform_worker.h
M  +96   -0libs/image/krita_utils.cpp
M  +8-0libs/image/krita_utils.h
M  +57   -32   libs/image/tests/kis_warp_transform_worker_test.cpp
M  +2-0libs/image/tests/kis_warp_transform_worker_test.h
M  +10   -0plugins/tools/tool_transform2/kis_transform_mask_adapter.cpp
M  +3-0plugins/tools/tool_transform2/kis_transform_mask_adapter.h
M  +66   -0plugins/tools/tool_transform2/kis_transform_utils.cpp
M  +7-0plugins/tools/tool_transform2/kis_transform_utils.h

http://commits.kde.org/krita/241ddd4ec56b58172e631596696c4ea369e52a05

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 347755] Crash when loading file containing layer with warp transform mask

[Sven Langkamp via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=347755

Sven Langkamp  changed:

   What|Removed |Added

 CC||sven.langk...@gmail.com

--- Comment #5 from Sven Langkamp  ---
Is this still reproduceable? All the files load for me in Krita 3.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 347755] Crash when loading file containing layer with warp transform mask

[Boudewijn Rempt via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=347755

Boudewijn Rempt  changed:

   What|Removed |Added

   Assignee|dimul...@gmail.com  |krita-bugs-n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.