[krita] [Bug 361012] Guides: Undo only actions, not user settings?
https://bugs.kde.org/show_bug.cgi?id=361012 --- Comment #11 from mvowada --- Thanks! -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 361012] Guides: Undo only actions, not user settings?
https://bugs.kde.org/show_bug.cgi?id=361012 tus...@vista.aero changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED CC||tus...@vista.aero --- Comment #10 from tus...@vista.aero --- Fixed by the commits above. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 361012] Guides: Undo only actions, not user settings?
https://bugs.kde.org/show_bug.cgi?id=361012 --- Comment #9 from Boudewijn Rempt --- Git commit 83d20e1377155aeba579ae22bda77be4b5d4ad8b by Boudewijn Rempt, on behalf of Tusooa Zhu. Committed on 04/06/2019 at 15:18. Pushed by rempt into branch 'krita/4.2'. Control the merging and creation of KisChangeGuidesCommand Only adding/removing/moving a guide will trigger the creation of KisChangeGuidesCommand. Only consecutive movements, or creation then movement, or movement then deletion of the same guide will trigger the merging of the commands. M +60 -2libs/ui/canvas/kis_change_guides_command.cpp M +6-0libs/ui/canvas/kis_guides_config.cpp M +1-0libs/ui/canvas/kis_guides_config.h M +16 -2libs/ui/canvas/kis_guides_manager.cpp https://invent.kde.org/kde/krita/commit/83d20e1377155aeba579ae22bda77be4b5d4ad8b -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 361012] Guides: Undo only actions, not user settings?
https://bugs.kde.org/show_bug.cgi?id=361012 --- Comment #8 from tus...@vista.aero --- Git commit 2a3fccde53e1017bd22deeaedd2f29fabb4e494a by Tusooa Zhu. Committed on 01/06/2019 at 09:56. Pushed by tusooaw into branch 'master'. Control the merging and creation of KisChangeGuidesCommand Only adding/removing/moving a guide will trigger the creation of KisChangeGuidesCommand. Only consecutive movements, or creation then movement, or movement then deletion of the same guide will trigger the merging of the commands. M +60 -2libs/ui/canvas/kis_change_guides_command.cpp M +6-0libs/ui/canvas/kis_guides_config.cpp M +1-0libs/ui/canvas/kis_guides_config.h M +16 -2libs/ui/canvas/kis_guides_manager.cpp https://invent.kde.org/kde/krita/commit/2a3fccde53e1017bd22deeaedd2f29fabb4e494a -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 361012] Guides: Undo only actions, not user settings?
https://bugs.kde.org/show_bug.cgi?id=361012
--- Comment #7 from mvowada ---
(In reply to Dmitry Kazakov from comment #5)
Thanks, I'm 100% in agreement with Dmitry and Boudewijn, with a note:
> 2.1) Creation, Removal, Moving guides should be undoable
That's right, only if it's possible, I'd prefer one step at a time, e.g.:
1. add multiple guides consecutively;
2. hit CTRL + Z ("Undo").
Expected Results: "Undo" should affect only the last guide added. Currently it
seems it reverts all the added guides.
--
You are receiving this mail because:
You are watching all bug changes.
[krita] [Bug 361012] Guides: Undo only actions, not user settings?
https://bugs.kde.org/show_bug.cgi?id=361012 --- Comment #6 from Boudewijn Rempt --- Yes, that's it. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 361012] Guides: Undo only actions, not user settings?
https://bugs.kde.org/show_bug.cgi?id=361012 Dmitry Kazakov changed: What|Removed |Added CC||dimul...@gmail.com --- Comment #5 from Dmitry Kazakov --- Do I understand it right that the guides settings should work in the following way: 1) Grids --- changing any settings in the docker should not be undoable 2) Guides: 2.1) Creation, Removal, Moving guides should be undoable 2.2) Any other options of the guides should not be undoable Right? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 361012] Guides: Undo only actions, not user settings?
https://bugs.kde.org/show_bug.cgi?id=361012 --- Comment #4 from Boudewijn Rempt --- Er... You _do_ agree: all of us are saying that things like setting "lock/unlock" guide shouldn't be end up in the undo stack; right now, they do. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 361012] Guides: Undo only actions, not user settings?
https://bugs.kde.org/show_bug.cgi?id=361012 Sven Langkamp changed: What|Removed |Added CC||sven.langk...@gmail.com --- Comment #3 from Sven Langkamp --- I don't agree. There is no application that does it. At least it shouldn't be in the general undo stack. We did do the opposite in the past when we e.g. made switching the visibility of a layer not undoable. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 361012] Guides: Undo only actions, not user settings?
https://bugs.kde.org/show_bug.cgi?id=361012 --- Comment #2 from Boudewijn Rempt --- *** Bug 361011 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 361012] Guides: Undo only actions, not user settings?
https://bugs.kde.org/show_bug.cgi?id=361012 Boudewijn Rempt changed: What|Removed |Added Summary|Undo only actions, not user |Guides: Undo only actions, |settings? |not user settings? -- You are receiving this mail because: You are watching all bug changes.
