https://bugs.kde.org/show_bug.cgi?id=363416
Friedrich W. H. Kossebau changed:
What|Removed |Added
Latest Commit||http://commits.kde.org/krit
||a/ea7592e93feadb2080a6c48ca
||6ce44b88ee3230e
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #3 from Friedrich W. H. Kossebau ---
Git commit ea7592e93feadb2080a6c48ca6ce44b88ee3230e by Friedrich W. H.
Kossebau.
Committed on 27/05/2016 at 10:05.
Pushed by kossebau into branch 'master'.
Fix double-deletion crash on destruction of KisNode with KisNodeProgressProxy
Summary:
The emission of the signal KisNodeProgressProxy::percentageChanged due to
KisBusyProgressIndicator::endUpdatesBeforeDestroying()
KisBusyProgressIndicator::Private::stopProgressReport()
KisNodeProgressProxy::setRange(int, int)
resulted in a temporary KisNodeSP being created, which called ref() and
deref() on the KisNode object, whose KisShared part already was at 0
ref count, which results in deref() to trigger another delete call
on the KisNode.
Related: bug 363470
Fixes T2393
Test Plan: KisFileLayerTest no longer fails, other tests still as before.
Reviewers: #krita:_next, rempt, dkazakov
Differential Revision: https://phabricator.kde.org/D1695
M +12 -6libs/image/kis_busy_progress_indicator.cpp
M +13 -2libs/image/kis_busy_progress_indicator.h
M +2-1libs/image/kis_node.cpp
M +6-0libs/image/kis_node_progress_proxy.cpp
M +8-0libs/image/kis_node_progress_proxy.h
http://commits.kde.org/krita/ea7592e93feadb2080a6c48ca6ce44b88ee3230e
--
You are receiving this mail because:
You are watching all bug changes.
