[krita] [Bug 364848] Krita adds more to memory usage, after opening and closing several files

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364848

--- Comment #9 from Dmitry Kazakov  ---
Git commit 5884065cb3fe96d294387e3e436c7b6be4da03a8 by Dmitry Kazakov.
Committed on 20/07/2016 at 14:00.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Don't keep the default tile data blocked from swapping

Summary:
We don't access the raw data of it usually. And is cases we do
we should block it separately.

This patch is needed to be able to migrate the leftover of tiles
to the new pool when a document is closed.

Release all the tile pools forcefully when a document is closed

This approach is a bit hackish, but it is the best thing we can do.
When the document is closed and the pool still contains a few tiles,
we artificially "swap-out" the tiles into a QList, purge the data in
the tile data pools and "swap-in" the tiles back.

Surely, we will not get an ACM award for this solution, but at least it
works ;)
Related: bug 363334

Implement data pool for the chunks in openGL canvas updates

This patch implements KisTextureTileInfoPool. A special object that keeps
track of all the chunks allocated during the openGL canvas updates.

This class is also capable of tracking multiple openGL tile sizes
and color space pixel sizes.

It should fix the most of the memory fragmentation problems,
especially on Windows.

Fix warning

Merge remote-tracking branch 'origin/master' into kazakov/memory-optimizations

Test Plan: Open any **huge image** in Krita and try to work with it, Krita
should not consume more memory with time. The RAM shouldn't also grow with
reopening the same large image multiple times. Well, it will grow anyway, but
not much.

Reviewers: rempt

Subscribers: dkazakov

Differential Revision: https://phabricator.kde.org/D2236


http://commits.kde.org/krita/5884065cb3fe96d294387e3e436c7b6be4da03a8

--- Comment #10 from Dmitry Kazakov  ---
Git commit 5884065cb3fe96d294387e3e436c7b6be4da03a8 by Dmitry Kazakov.
Committed on 20/07/2016 at 14:00.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Don't keep the default tile data blocked from swapping

Summary:
We don't access the raw data of it usually. And is cases we do
we should block it separately.

This patch is needed to be able to migrate the leftover of tiles
to the new pool when a document is closed.

Release all the tile pools forcefully when a document is closed

This approach is a bit hackish, but it is the best thing we can do.
When the document is closed and the pool still contains a few tiles,
we artificially "swap-out" the tiles into a QList, purge the data in
the tile data pools and "swap-in" the tiles back.

Surely, we will not get an ACM award for this solution, but at least it
works ;)
Related: bug 363334

Implement data pool for the chunks in openGL canvas updates

This patch implements KisTextureTileInfoPool. A special object that keeps
track of all the chunks allocated during the openGL canvas updates.

This class is also capable of tracking multiple openGL tile sizes
and color space pixel sizes.

It should fix the most of the memory fragmentation problems,
especially on Windows.

Fix warning

Merge remote-tracking branch 'origin/master' into kazakov/memory-optimizations

Test Plan: Open any **huge image** in Krita and try to work with it, Krita
should not consume more memory with time. The RAM shouldn't also grow with
reopening the same large image multiple times. Well, it will grow anyway, but
not much.

Reviewers: rempt

Subscribers: dkazakov

Differential Revision: https://phabricator.kde.org/D2236


http://commits.kde.org/krita/5884065cb3fe96d294387e3e436c7b6be4da03a8

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364848] Krita adds more to memory usage, after opening and closing several files

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364848

--- Comment #9 from Dmitry Kazakov  ---
Git commit 5884065cb3fe96d294387e3e436c7b6be4da03a8 by Dmitry Kazakov.
Committed on 20/07/2016 at 14:00.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Don't keep the default tile data blocked from swapping

Summary:
We don't access the raw data of it usually. And is cases we do
we should block it separately.

This patch is needed to be able to migrate the leftover of tiles
to the new pool when a document is closed.

Release all the tile pools forcefully when a document is closed

This approach is a bit hackish, but it is the best thing we can do.
When the document is closed and the pool still contains a few tiles,
we artificially "swap-out" the tiles into a QList, purge the data in
the tile data pools and "swap-in" the tiles back.

Surely, we will not get an ACM award for this solution, but at least it
works ;)
Related: bug 363334

Implement data pool for the chunks in openGL canvas updates

This patch implements KisTextureTileInfoPool. A special object that keeps
track of all the chunks allocated during the openGL canvas updates.

This class is also capable of tracking multiple openGL tile sizes
and color space pixel sizes.

It should fix the most of the memory fragmentation problems,
especially on Windows.

Fix warning

Merge remote-tracking branch 'origin/master' into kazakov/memory-optimizations

Test Plan: Open any **huge image** in Krita and try to work with it, Krita
should not consume more memory with time. The RAM shouldn't also grow with
reopening the same large image multiple times. Well, it will grow anyway, but
not much.

Reviewers: rempt

Subscribers: dkazakov

Differential Revision: https://phabricator.kde.org/D2236


http://commits.kde.org/krita/5884065cb3fe96d294387e3e436c7b6be4da03a8

--- Comment #10 from Dmitry Kazakov  ---
Git commit 5884065cb3fe96d294387e3e436c7b6be4da03a8 by Dmitry Kazakov.
Committed on 20/07/2016 at 14:00.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Don't keep the default tile data blocked from swapping

Summary:
We don't access the raw data of it usually. And is cases we do
we should block it separately.

This patch is needed to be able to migrate the leftover of tiles
to the new pool when a document is closed.

Release all the tile pools forcefully when a document is closed

This approach is a bit hackish, but it is the best thing we can do.
When the document is closed and the pool still contains a few tiles,
we artificially "swap-out" the tiles into a QList, purge the data in
the tile data pools and "swap-in" the tiles back.

Surely, we will not get an ACM award for this solution, but at least it
works ;)
Related: bug 363334

Implement data pool for the chunks in openGL canvas updates

This patch implements KisTextureTileInfoPool. A special object that keeps
track of all the chunks allocated during the openGL canvas updates.

This class is also capable of tracking multiple openGL tile sizes
and color space pixel sizes.

It should fix the most of the memory fragmentation problems,
especially on Windows.

Fix warning

Merge remote-tracking branch 'origin/master' into kazakov/memory-optimizations

Test Plan: Open any **huge image** in Krita and try to work with it, Krita
should not consume more memory with time. The RAM shouldn't also grow with
reopening the same large image multiple times. Well, it will grow anyway, but
not much.

Reviewers: rempt

Subscribers: dkazakov

Differential Revision: https://phabricator.kde.org/D2236


http://commits.kde.org/krita/5884065cb3fe96d294387e3e436c7b6be4da03a8

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364848] Krita adds more to memory usage, after opening and closing several files

[Raghavendra kamath via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364848

Raghavendra kamath  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Raghavendra kamath  ---
Thanks dmitry for fixing this

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364848] Krita adds more to memory usage, after opening and closing several files

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364848

--- Comment #5 from Dmitry Kazakov  ---
Git commit 550ff114cbae42c33edb667981d091e2ac4346f5 by Dmitry Kazakov.
Committed on 15/07/2016 at 10:01.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Release all the tile pools forcefully when a document is closed

This approach is a bit hackish, but it is the best thing we can do.
When the document is closed and the pool still contains a few tiles,
we artificially "swap-out" the tiles into a QList, purge the data in
the tile data pools and "swap-in" the tiles back.

Surely, we will not get an ACM award for this solution, but at least it
works ;)

M  +72   -9libs/image/tiles3/kis_tile_data.cc

http://commits.kde.org/krita/550ff114cbae42c33edb667981d091e2ac4346f5

--- Comment #6 from Dmitry Kazakov  ---
Git commit a8f901e40fb7de35a29a4b4803ccbacab802c8bd by Dmitry Kazakov.
Committed on 15/07/2016 at 10:01.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Fix releasing the node pixes memory when closing the document

KisNodeFilterProxyModel should not store any pointers after the
image has been closed.

M  +1-1libs/image/kis_default_bounds.cpp
M  +9-0libs/ui/kis_node_filter_proxy_model.cpp
M  +2-0libs/ui/kis_node_filter_proxy_model.h
M  +1-1plugins/dockers/defaultdockers/kis_layer_box.cpp

http://commits.kde.org/krita/a8f901e40fb7de35a29a4b4803ccbacab802c8bd

--- Comment #7 from Dmitry Kazakov  ---
Git commit 54282a72cee6256f29be9970793b32f6ffae6aa1 by Dmitry Kazakov.
Committed on 15/07/2016 at 10:01.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Implement data pool for the chunks in openGL canvas updates

This patch implements KisTextureTileInfoPool. A special object that keeps
track of all the chunks allocated during the openGL canvas updates.

This class is also capable of tracking multiple openGL tile sizes
and color space pixel sizes.

It should fix the most of the memory fragmentation problems,
especially on Windows.
Related: bug 363334

M  +0-1libs/ui/CMakeLists.txt
M  +8-1libs/ui/opengl/kis_opengl_image_textures.cpp
M  +4-0libs/ui/opengl/kis_opengl_image_textures.h
A  +156  -0libs/ui/opengl/kis_texture_tile_info_pool.h [License: GPL
(v2+)]
D  +0-22   libs/ui/opengl/kis_texture_tile_update_info.cpp
M  +58   -72   libs/ui/opengl/kis_texture_tile_update_info.h

http://commits.kde.org/krita/54282a72cee6256f29be9970793b32f6ffae6aa1

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364848] Krita adds more to memory usage, after opening and closing several files

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364848

--- Comment #5 from Dmitry Kazakov  ---
Git commit 550ff114cbae42c33edb667981d091e2ac4346f5 by Dmitry Kazakov.
Committed on 15/07/2016 at 10:01.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Release all the tile pools forcefully when a document is closed

This approach is a bit hackish, but it is the best thing we can do.
When the document is closed and the pool still contains a few tiles,
we artificially "swap-out" the tiles into a QList, purge the data in
the tile data pools and "swap-in" the tiles back.

Surely, we will not get an ACM award for this solution, but at least it
works ;)

M  +72   -9libs/image/tiles3/kis_tile_data.cc

http://commits.kde.org/krita/550ff114cbae42c33edb667981d091e2ac4346f5

--- Comment #6 from Dmitry Kazakov  ---
Git commit a8f901e40fb7de35a29a4b4803ccbacab802c8bd by Dmitry Kazakov.
Committed on 15/07/2016 at 10:01.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Fix releasing the node pixes memory when closing the document

KisNodeFilterProxyModel should not store any pointers after the
image has been closed.

M  +1-1libs/image/kis_default_bounds.cpp
M  +9-0libs/ui/kis_node_filter_proxy_model.cpp
M  +2-0libs/ui/kis_node_filter_proxy_model.h
M  +1-1plugins/dockers/defaultdockers/kis_layer_box.cpp

http://commits.kde.org/krita/a8f901e40fb7de35a29a4b4803ccbacab802c8bd

--- Comment #7 from Dmitry Kazakov  ---
Git commit 54282a72cee6256f29be9970793b32f6ffae6aa1 by Dmitry Kazakov.
Committed on 15/07/2016 at 10:01.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Implement data pool for the chunks in openGL canvas updates

This patch implements KisTextureTileInfoPool. A special object that keeps
track of all the chunks allocated during the openGL canvas updates.

This class is also capable of tracking multiple openGL tile sizes
and color space pixel sizes.

It should fix the most of the memory fragmentation problems,
especially on Windows.
Related: bug 363334

M  +0-1libs/ui/CMakeLists.txt
M  +8-1libs/ui/opengl/kis_opengl_image_textures.cpp
M  +4-0libs/ui/opengl/kis_opengl_image_textures.h
A  +156  -0libs/ui/opengl/kis_texture_tile_info_pool.h [License: GPL
(v2+)]
D  +0-22   libs/ui/opengl/kis_texture_tile_update_info.cpp
M  +58   -72   libs/ui/opengl/kis_texture_tile_update_info.h

http://commits.kde.org/krita/54282a72cee6256f29be9970793b32f6ffae6aa1

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364848] Krita adds more to memory usage, after opening and closing several files

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364848

--- Comment #5 from Dmitry Kazakov  ---
Git commit 550ff114cbae42c33edb667981d091e2ac4346f5 by Dmitry Kazakov.
Committed on 15/07/2016 at 10:01.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Release all the tile pools forcefully when a document is closed

This approach is a bit hackish, but it is the best thing we can do.
When the document is closed and the pool still contains a few tiles,
we artificially "swap-out" the tiles into a QList, purge the data in
the tile data pools and "swap-in" the tiles back.

Surely, we will not get an ACM award for this solution, but at least it
works ;)

M  +72   -9libs/image/tiles3/kis_tile_data.cc

http://commits.kde.org/krita/550ff114cbae42c33edb667981d091e2ac4346f5

--- Comment #6 from Dmitry Kazakov  ---
Git commit a8f901e40fb7de35a29a4b4803ccbacab802c8bd by Dmitry Kazakov.
Committed on 15/07/2016 at 10:01.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Fix releasing the node pixes memory when closing the document

KisNodeFilterProxyModel should not store any pointers after the
image has been closed.

M  +1-1libs/image/kis_default_bounds.cpp
M  +9-0libs/ui/kis_node_filter_proxy_model.cpp
M  +2-0libs/ui/kis_node_filter_proxy_model.h
M  +1-1plugins/dockers/defaultdockers/kis_layer_box.cpp

http://commits.kde.org/krita/a8f901e40fb7de35a29a4b4803ccbacab802c8bd

--- Comment #7 from Dmitry Kazakov  ---
Git commit 54282a72cee6256f29be9970793b32f6ffae6aa1 by Dmitry Kazakov.
Committed on 15/07/2016 at 10:01.
Pushed by dkazakov into branch 'kazakov/memory-optimizations'.

Implement data pool for the chunks in openGL canvas updates

This patch implements KisTextureTileInfoPool. A special object that keeps
track of all the chunks allocated during the openGL canvas updates.

This class is also capable of tracking multiple openGL tile sizes
and color space pixel sizes.

It should fix the most of the memory fragmentation problems,
especially on Windows.
Related: bug 363334

M  +0-1libs/ui/CMakeLists.txt
M  +8-1libs/ui/opengl/kis_opengl_image_textures.cpp
M  +4-0libs/ui/opengl/kis_opengl_image_textures.h
A  +156  -0libs/ui/opengl/kis_texture_tile_info_pool.h [License: GPL
(v2+)]
D  +0-22   libs/ui/opengl/kis_texture_tile_update_info.cpp
M  +58   -72   libs/ui/opengl/kis_texture_tile_update_info.h

http://commits.kde.org/krita/54282a72cee6256f29be9970793b32f6ffae6aa1

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364848] Krita adds more to memory usage, after opening and closing several files

[Boudewijn Rempt via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364848

--- Comment #4 from Boudewijn Rempt  ---
Created attachment 99859
  --> https://bugs.kde.org/attachment.cgi?id=99859=edit
massif run

Opened and closed a bunch of images in a row.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364848] Krita adds more to memory usage, after opening and closing several files

[Boudewijn Rempt via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364848

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||b...@valdyas.org

--- Comment #3 from Boudewijn Rempt  ---
Created attachment 99858
  --> https://bugs.kde.org/attachment.cgi?id=99858=edit
memcheck log

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364848] Krita adds more to memory usage, after opening and closing several files

[Scott Petrovic via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364848

Scott Petrovic  changed:

   What|Removed |Added

 CC||scottpetro...@gmail.com
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #2 from Scott Petrovic  ---
I can confirm this with my test I did last week. I am on a Windows 10 box.
Raghukamath gave me a series of large KRA files (over 1GB).  Memory doesn't
seem to be getting recycled. Every time a different file is opened, Krita
allocates more memory instead of reusing any of the existing memory.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 364848] Krita adds more to memory usage, after opening and closing several files

[Raghavendra kamath via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364848

--- Comment #1 from Raghavendra kamath  ---
this may be related to this bug report ->
https://bugs.kde.org/show_bug.cgi?id=363334

-- 
You are receiving this mail because:
You are watching all bug changes.