[krita] [Bug 366607] Crash when KUndo2Command tries to do a timedmerge but gets confused
https://bugs.kde.org/show_bug.cgi?id=366607 Boudewijn Rempt changed: What|Removed |Added CC||ludvig.bok...@gmail.com --- Comment #16 from Boudewijn Rempt --- *** Bug 373995 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 366607] Crash when KUndo2Command tries to do a timedmerge but gets confused
https://bugs.kde.org/show_bug.cgi?id=366607 Boudewijn Rempt changed: What|Removed |Added Latest Commit|http://commits.kde.org/krit |http://commits.kde.org/krit |a/431fbb5a10eb2f1b54085e791 |a/53b7dccab445b87b71f0e9a6d |37db8d0e7e997c4 |25429d337634703 --- Comment #15 from Boudewijn Rempt --- Git commit 53b7dccab445b87b71f0e9a6d25429d337634703 by Boudewijn Rempt, on behalf of Dmitry Kazakov. Committed on 26/09/2016 at 20:06. Pushed by rempt into branch 'krita/3.0.1'. Fix crash in timedMergeWith() Don't try to read from m_lastMergedIndex + 1, which might not exist because the previous command has been merged using basic Qt's mechanism. M +53 -19 libs/kundo2/kundo2stack.cpp http://commits.kde.org/krita/53b7dccab445b87b71f0e9a6d25429d337634703 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 366607] Crash when KUndo2Command tries to do a timedmerge but gets confused
https://bugs.kde.org/show_bug.cgi?id=366607 --- Comment #14 from Boudewijn Rempt --- Git commit e2f9deda136ff8f4a1d8a12104ab678098a2a890 by Boudewijn Rempt, on behalf of Dmitry Kazakov. Committed on 26/09/2016 at 20:06. Pushed by rempt into branch 'krita/3.0.1'. Fix crash when D&D frames from a *cloned* layer Yes, we should also copy the free-frame-id counter when cloning the layers (and ideally also check if the frame id is already occupied) M +12 -3libs/image/kis_paint_device.cc M +2-0libs/image/tests/kis_keyframing_test.h http://commits.kde.org/krita/e2f9deda136ff8f4a1d8a12104ab678098a2a890 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 366607] Crash when KUndo2Command tries to do a timedmerge but gets confused
https://bugs.kde.org/show_bug.cgi?id=366607 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED Latest Commit|http://commits.kde.org/krit |http://commits.kde.org/krit |a/68ca0a9afba1693d7f1a6234c |a/431fbb5a10eb2f1b54085e791 |605ff7233522dd5 |37db8d0e7e997c4 --- Comment #12 from Dmitry Kazakov --- Git commit a1e7098bdfa7618578f4c6096c0b35146c81bee3 by Dmitry Kazakov. Committed on 21/09/2016 at 11:05. Pushed by dkazakov into branch 'kazakov/preset-chooser-fixes'. Fix crash when D&D frames from a *cloned* layer Yes, we should also copy the free-frame-id counter when cloning the layers (and ideally also check if the frame id is already occupied) M +12 -3libs/image/kis_paint_device.cc M +55 -11 libs/image/tests/kis_keyframing_test.cpp M +2-0libs/image/tests/kis_keyframing_test.h http://commits.kde.org/krita/a1e7098bdfa7618578f4c6096c0b35146c81bee3 --- Comment #13 from Dmitry Kazakov --- Git commit 431fbb5a10eb2f1b54085e79137db8d0e7e997c4 by Dmitry Kazakov. Committed on 21/09/2016 at 13:15. Pushed by dkazakov into branch 'kazakov/preset-chooser-fixes'. Fix crash in timedMergeWith() Don't try to read from m_lastMergedIndex + 1, which might not exist because the previous command has been merged using basic Qt's mechanism. M +53 -19 libs/kundo2/kundo2stack.cpp http://commits.kde.org/krita/431fbb5a10eb2f1b54085e79137db8d0e7e997c4 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 366607] Crash when KUndo2Command tries to do a timedmerge but gets confused
https://bugs.kde.org/show_bug.cgi?id=366607 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED Latest Commit|http://commits.kde.org/krit |http://commits.kde.org/krit |a/68ca0a9afba1693d7f1a6234c |a/431fbb5a10eb2f1b54085e791 |605ff7233522dd5 |37db8d0e7e997c4 --- Comment #12 from Dmitry Kazakov --- Git commit a1e7098bdfa7618578f4c6096c0b35146c81bee3 by Dmitry Kazakov. Committed on 21/09/2016 at 11:05. Pushed by dkazakov into branch 'kazakov/preset-chooser-fixes'. Fix crash when D&D frames from a *cloned* layer Yes, we should also copy the free-frame-id counter when cloning the layers (and ideally also check if the frame id is already occupied) M +12 -3libs/image/kis_paint_device.cc M +55 -11 libs/image/tests/kis_keyframing_test.cpp M +2-0libs/image/tests/kis_keyframing_test.h http://commits.kde.org/krita/a1e7098bdfa7618578f4c6096c0b35146c81bee3 --- Comment #13 from Dmitry Kazakov --- Git commit 431fbb5a10eb2f1b54085e79137db8d0e7e997c4 by Dmitry Kazakov. Committed on 21/09/2016 at 13:15. Pushed by dkazakov into branch 'kazakov/preset-chooser-fixes'. Fix crash in timedMergeWith() Don't try to read from m_lastMergedIndex + 1, which might not exist because the previous command has been merged using basic Qt's mechanism. M +53 -19 libs/kundo2/kundo2stack.cpp http://commits.kde.org/krita/431fbb5a10eb2f1b54085e79137db8d0e7e997c4 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 366607] Crash when KUndo2Command tries to do a timedmerge but gets confused
https://bugs.kde.org/show_bug.cgi?id=366607 Boudewijn Rempt changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 366607] Crash when KUndo2Command tries to do a timedmerge but gets confused
https://bugs.kde.org/show_bug.cgi?id=366607 Boudewijn Rempt changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 366607] Crash when KUndo2Command tries to do a timedmerge but gets confused
https://bugs.kde.org/show_bug.cgi?id=366607 Boudewijn Rempt changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Latest Commit||http://commits.kde.org/krit ||a/68ca0a9afba1693d7f1a6234c ||605ff7233522dd5 Resolution|--- |FIXED --- Comment #11 from Boudewijn Rempt --- Git commit 68ca0a9afba1693d7f1a6234c605ff7233522dd5 by Boudewijn Rempt. Committed on 19/09/2016 at 11:09. Pushed by rempt into branch 'master'. Wrap the undo commands in a QPointer This should fix the problems when trying to merge already deleted commands in the timedMergeWith method, because now we can track whether the QObject-based KUndo2Command instances have been deleted behind our back. M +4-2libs/image/commands_new/kis_change_projection_color_command.cpp M +2-2libs/image/commands_new/kis_change_projection_color_command.h M +15 -10 libs/image/commands_new/kis_saved_commands.cpp M +5-5libs/image/commands_new/kis_saved_commands.h M +4-2libs/image/commands_new/kis_switch_current_time_command.cpp M +2-2libs/image/commands_new/kis_switch_current_time_command.h M +11 -17 libs/kundo2/kundo2command.cpp M +4-6libs/kundo2/kundo2command.h M +19 -10 libs/kundo2/kundo2stack.cpp M +5-3libs/kundo2/kundo2stack.h M +5-5libs/ui/canvas/kis_change_guides_command.cpp M +2-2libs/ui/canvas/kis_change_guides_command.h M +1-1plugins/flake/textshape/TextTool.cpp M +1-1plugins/flake/textshape/commands/ChangeListLevelCommand.cpp M +1-1plugins/flake/textshape/commands/ChangeListLevelCommand.h M +1-0plugins/flake/textshape/kotext/KoTextCommandBase.h M +1-1plugins/flake/textshape/kotext/KoTextEditor_undo.cpp M +1-1plugins/flake/textshape/kotext/OdfTextTrackStyles.cpp M +2-2plugins/flake/textshape/kotext/commands/ChangeListCommand.cpp M +1-1plugins/flake/textshape/kotext/commands/ChangeListCommand.h M +5-2plugins/flake/textshape/kotext/commands/DeleteCommand.cpp M +1-1plugins/flake/textshape/kotext/commands/DeleteCommand.h M +1-1 plugins/flake/textshape/kotext/commands/ListItemNumberingCommand.cpp M +1-1 plugins/flake/textshape/kotext/commands/ListItemNumberingCommand.h M +3-3plugins/flake/textshape/kotext/commands/RenameSectionCommand.cpp M +1-1plugins/flake/textshape/kotext/commands/RenameSectionCommand.h http://commits.kde.org/krita/68ca0a9afba1693d7f1a6234c605ff7233522dd5 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 366607] Crash when KUndo2Command tries to do a timedmerge but gets confused
https://bugs.kde.org/show_bug.cgi?id=366607 Boudewijn Rempt changed: What|Removed |Added Summary|Several crashes with|Crash when KUndo2Command |manipulating animation |tries to do a timedmerge |frames. |but gets confused CC||b...@valdyas.org -- You are receiving this mail because: You are watching all bug changes.
