[krita] [Bug 370246] Random pattern offset is constant

2016-10-09 Thread Boudewijn Rempt via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370246

Boudewijn Rempt  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||http://commits.kde.org/krit
   ||a/2c0bc2a25f793b7773af271a5
   ||d0695794b0d49d0

--- Comment #4 from Boudewijn Rempt  ---
Git commit 2c0bc2a25f793b7773af271a5d0695794b0d49d0 by Boudewijn Rempt.
Committed on 09/10/2016 at 11:20.
Pushed by rempt into branch 'master'.

Fix the randomness of KisRandomSource

The root cause probably was all the places where srand was called,
but after this change, textures are random again. This was a problem
on Windows only, probably because the resolution of time() is too
low. But that's a guess.
Related: bug 345196, bug 363663, bug 367873
Closed phabricator task T3887,T3968

M  +22   -5libs/image/brushengine/kis_random_source.cpp

http://commits.kde.org/krita/2c0bc2a25f793b7773af271a5d0695794b0d49d0

-- 
You are receiving this mail because:
You are watching all bug changes.


[krita] [Bug 370246] Random pattern offset is constant

2016-10-07 Thread Boudewijn Rempt via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370246

--- Comment #3 from Boudewijn Rempt  ---
Git commit 72e51771f5681fbf86ac4cac6f1eb5c8033dc832 by Boudewijn Rempt.
Committed on 07/10/2016 at 14:15.
Pushed by rempt into branch 'master'.

Use KisRandomSource for the random texture offset feature

M  +23   -30   libs/image/brushengine/kis_paintop_settings.cpp
M  +12   -9libs/image/brushengine/kis_paintop_settings.h
M  +14   -14   plugins/paintops/libpaintop/kis_texture_option.cpp

http://commits.kde.org/krita/72e51771f5681fbf86ac4cac6f1eb5c8033dc832

-- 
You are receiving this mail because:
You are watching all bug changes.


[krita] [Bug 370246] Random pattern offset is constant

2016-10-07 Thread Boudewijn Rempt via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370246

--- Comment #2 from Boudewijn Rempt  ---
Git commit 81e6fa9e6f24f5e89d981e9f7f104890bbc0c990 by Boudewijn Rempt.
Committed on 07/10/2016 at 13:17.
Pushed by rempt into branch 'master'.

Hide the random offset checkboxes

The random offset feature is not implemented
See also https://phabricator.kde.org/T3968

A  +19   -03rdparty/ext_pyqt/CMakeLists.txt
M  +3-1plugins/paintops/libpaintop/kis_texture_option.cpp

http://commits.kde.org/krita/81e6fa9e6f24f5e89d981e9f7f104890bbc0c990

-- 
You are receiving this mail because:
You are watching all bug changes.


[krita] [Bug 370246] Random pattern offset is constant

2016-10-07 Thread Boudewijn Rempt via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370246

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||b...@valdyas.org
 Ever confirmed|0   |1

--- Comment #1 from Boudewijn Rempt  ---
Hi Luis,

I think I can go further and confirm that the random offset property is not
used at all. I'm not even sure what the range for the random offset should
be... I'll hide the checkboxes for now, and make a phabricator task to discuss
the issue.

https://phabricator.kde.org/T3968

-- 
You are receiving this mail because:
You are watching all bug changes.