[krita] [Bug 378147] File layer only updates once

2017-09-12 Thread Boudewijn Rempt 
https://bugs.kde.org/show_bug.cgi?id=378147

Boudewijn Rempt  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri
   |ta/829876d88b5fbdc1a79d235d |ta/ce183f5050c5b66fe89b0818
   |11a459753a1fd81d|ede64d6e068ad6ad

--- Comment #5 from Boudewijn Rempt  ---
Git commit ce183f5050c5b66fe89b0818ede64d6e068ad6ad by Boudewijn Rempt, on
behalf of Wolthera van Hövell tot Westerflier.
Committed on 12/09/2017 at 16:55.
Pushed by rempt into branch 'krita/3.3'.

Basically, this was caused by the backups.
Krita handles backups by saying "ok, you, old file, rename to backup,
and new file, you become the url of old file". This renaming is what
signals QFileSystemWatcher, and because it is a rename, it removes it
from the list of watched files.

So what we do is that when we get our change in, we check if the file
exists and is still being watched, and if so we readd it.

M  +4-0libs/ui/kis_safe_document_loader.cpp

https://commits.kde.org/krita/ce183f5050c5b66fe89b0818ede64d6e068ad6ad

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 378147] File layer only updates once

2017-09-12 Thread wolthera 
https://bugs.kde.org/show_bug.cgi?id=378147

wolthera  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/kri
   ||ta/829876d88b5fbdc1a79d235d
   ||11a459753a1fd81d
 Resolution|--- |FIXED

--- Comment #4 from wolthera  ---
Git commit 829876d88b5fbdc1a79d235d11a459753a1fd81d by Wolthera van Hövell tot
Westerflier.
Committed on 12/09/2017 at 16:24.
Pushed by woltherav into branch 'master'.

Basically, this was caused by the backups.
Krita handles backups by saying "ok, you, old file, rename to backup,
and new file, you become the url of old file". This renaming is what
signals QFileSystemWatcher, and because it is a rename, it removes it
from the list of watched files.

So what we do is that when we get our change in, we check if the file
exists and is still being watched, and if so we readd it.

M  +4-0libs/ui/kis_safe_document_loader.cpp

https://commits.kde.org/krita/829876d88b5fbdc1a79d235d11a459753a1fd81d

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 378147] File layer only updates once

2017-09-12 Thread wolthera 
https://bugs.kde.org/show_bug.cgi?id=378147

wolthera  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||griffinval...@gmail.com
 Ever confirmed|0   |1

--- Comment #3 from wolthera  ---
This is caused... by the backups, strangely enough. QFileSystemWatcher
considers saving to the backup and then saving a new file to the old path the
same as deleting the path.

https://stackoverflow.com/questions/18300376/qt-qfilesystemwatcher-signal-filechanged-gets-emited-only-once

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 378147] File layer only updates once

2017-09-12 Thread Ricardo Nunes 
https://bugs.kde.org/show_bug.cgi?id=378147

Ricardo Nunes <3rto...@gmail.com> changed:

   What|Removed |Added

 CC||3rto...@gmail.com

--- Comment #2 from Ricardo Nunes <3rto...@gmail.com> ---
Can confirm still happens on Windows 10 on ver.3.2

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 378147] File layer only updates once

2017-08-25 Thread bugzilla_noreply 
https://bugs.kde.org/show_bug.cgi?id=378147

nmaghfurus...@gmail.com changed:

   What|Removed |Added

 CC||nmaghfurus...@gmail.com

--- Comment #1 from nmaghfurus...@gmail.com ---
I can reproduce the bug in the krita 3.2.1 appimage, running on debian testing.

-- 
You are receiving this mail because:
You are watching all bug changes.