[krita] [Bug 386279] Random crash in KisUpdateJobItem

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=386279

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Latest Commit||https://commits.kde.org/kri
   ||ta/a20c53eea0c1548502b78a73
   ||879488a09a27844c
 Resolution|--- |FIXED

--- Comment #6 from Boudewijn Rempt  ---
Git commit a20c53eea0c1548502b78a73879488a09a27844c by Boudewijn Rempt.
Committed on 26/11/2017 at 13:29.
Pushed by rempt into branch 'master'.

Add safe assert checking for the walker in KisUpdateJobItem

M  +2-1libs/image/kis_update_job_item.h

https://commits.kde.org/krita/a20c53eea0c1548502b78a73879488a09a27844c

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 386279] Random crash in KisUpdateJobItem

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=386279

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|DUPLICATE   |---

--- Comment #5 from Boudewijn Rempt  ---
No, this is not a true duplicate, because the other bug actually was about an
assert in KoDerivedResourceConverter: 

KIS_SAFE_ASSERT_RECOVER_NOOP(m_d->lastKnownValue.isNull() ||
 result == m_d->lastKnownValue);

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 386279] Random crash in KisUpdateJobItem

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=386279

Boudewijn Rempt  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #4 from Boudewijn Rempt  ---
Looks like a duplicate of 380246

*** This bug has been marked as a duplicate of bug 380246 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 386279] Random crash in KisUpdateJobItem

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=386279

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||b...@valdyas.org

--- Comment #3 from Boudewijn Rempt  ---
Something like this should solve it:

diff --git a/libs/image/kis_async_merger.cpp b/libs/image/kis_async_merger.cpp
index 041f6fbc68..9739eefab5 100644
--- a/libs/image/kis_async_merger.cpp
+++ b/libs/image/kis_async_merger.cpp
@@ -290,7 +290,6 @@ void KisAsyncMerger::startMerge(KisBaseRectsWalker ,
bool notifyClones) {
 if(m_currentProjection) {
 warnImage << "BUG: The walker hasn't reached the root layer!";
 warnImage << " Start node:" << walker.startNode() << "Requested
rect:" << walker.requestedRect();
-warnImage << " There must be an inconsistency in the walkers
happened!";
 warnImage << " Please report a bug describing how you got this
message.";
 // reset projection to avoid artefacts in next merges and allow people
to work further
 resetProjection();
diff --git a/libs/image/kis_update_job_item.h
b/libs/image/kis_update_job_item.h
index 3ac09e3436..6987611bba 100644
--- a/libs/image/kis_update_job_item.h
+++ b/libs/image/kis_update_job_item.h
@@ -100,7 +100,7 @@ public:

 m_exclusiveJobLock->unlock();

-// try to exit the loop. Please note, that noone can flip the
state from
+// try to exit the loop. Please note, that no-one can flip the
state from
 // WAITING to EMPTY except ourselves!
 Type expectedValue = Type::WAITING;
 if (m_atomicType.compare_exchange_strong(expectedValue,
Type::EMPTY)) {
@@ -111,6 +111,11 @@ public:

 inline void runMergeJob() {
 Q_ASSERT(m_atomicType == Type::MERGE);
+if (!m_walker) {
+qWarning() << "KisUpdateJobItem::runMergeJob: we have an invalid
walker.";
+return;
+}
+
 // dbgKrita << "Executing merge job" << m_walker->changeRect()
 //  << "on thread" << QThread::currentThreadId();
 m_merger.startMerge(*m_walker);

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 386279] Random crash in KisUpdateJobItem

[Bernhard Liebl]

https://bugs.kde.org/show_bug.cgi?id=386279

--- Comment #2 from Bernhard Liebl  ---
Created attachment 108602
  --> https://bugs.kde.org/attachment.cgi?id=108602=edit
same thing again

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 386279] Random crash in KisUpdateJobItem

[Bernhard Liebl]

https://bugs.kde.org/show_bug.cgi?id=386279

--- Comment #1 from Bernhard Liebl  ---
Oh, I just detected some more info from the console:

krita.core: BUG: The walker hasn't reached the root layer!
krita.core:  Start node: KisPaintLayer(0x7fa5c4bde050, name = "Layer 2")
Requested rect: QRect(7929953,7471205 -4653120x-4784194)
krita.core:  There must be an inconsistency in the walkers happened!
krita.core:  Please report a bug describing how you got this message.
Segmentation fault: 11

-- 
You are receiving this mail because:
You are watching all bug changes.