[krita] [Bug 391696] Right click with wacom pen auto selects whatever I hover over on the popup palette

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=391696

Boudewijn Rempt  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri
   |ta/c7e6c0184f951b4b4165a4bb |ta/93e1e39386eae6b23b390ab7
   |b7e99107a9e36cb0|c3034c83f864a7ec

--- Comment #12 from Boudewijn Rempt  ---
Git commit 93e1e39386eae6b23b390ab7c3034c83f864a7ec by Boudewijn Rempt, on
behalf of Dmitry Kazakov.
Committed on 02/05/2018 at 11:54.
Pushed by rempt into branch 'krita/4.0'.

Disable right-clicking on popup palette

With this patch it is not possible to select a palette item
using the right-click of the stylus. All the distinct actions
should be confirmed with the left button. Right-click on any part
of the canvas just closes the entire palette.
Related: bug 378484
(cherry picked from commit 20c9efffb70cf2757595fee8d7c56a5fe59d5664)

M  +24   -1libs/ui/kis_popup_palette.cpp
M  +5-0libs/ui/kis_popup_palette.h

https://commits.kde.org/krita/93e1e39386eae6b23b390ab7c3034c83f864a7ec

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391696] Right click with wacom pen auto selects whatever I hover over on the popup palette

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=391696

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/kri
   ||ta/c7e6c0184f951b4b4165a4bb
   ||b7e99107a9e36cb0

--- Comment #11 from Dmitry Kazakov  ---
Git commit c7e6c0184f951b4b4165a4bbb7e99107a9e36cb0 by Dmitry Kazakov.
Committed on 18/04/2018 at 14:27.
Pushed by dkazakov into branch 'master'.

Disable right-clicking on popup palette

With this patch it is not possible to select a palette item
using the right-click of the stylus. All the distinct actions
should be confirmed with the left button. Right-click on any part
of the canvas just closes the entire palette.
Related: bug 378484

M  +24   -1libs/ui/kis_popup_palette.cpp
M  +5-0libs/ui/kis_popup_palette.h

https://commits.kde.org/krita/c7e6c0184f951b4b4165a4bbb7e99107a9e36cb0

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391696] Right click with wacom pen auto selects whatever I hover over on the popup palette

[Storm Engineer]

https://bugs.kde.org/show_bug.cgi?id=391696

--- Comment #10 from Storm Engineer  ---
(In reply to Alvin Wong from comment #9)
> When I said this, it was referring to the context menus in other areas:

Oh sorry, I misread it, my bad.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391696] Right click with wacom pen auto selects whatever I hover over on the popup palette

[Alvin Wong]

https://bugs.kde.org/show_bug.cgi?id=391696

--- Comment #9 from Alvin Wong  ---
(In reply to Storm Engineer from comment #8)
> (In reply to Alvin Wong from comment #6)
> 
> > I don't see a problem with them
> Using the menus and palette with my Wacom pen is very frustrating and
> sometimes outright painful. Constantly selecting things I don't mean,
> constantly picking brushes and colors when I just want to open the palette.
> 
> And most importantly it makes no sense since the side button is set to be a
> right click - why is this right click behaving entirely different from my
> mouse right click?
> 
> * The huge difference is that a mouse cursor generally stays in the same
> place as you click - a pen held hovering over the tablet is unstable, so
> it's very easy for it to move over to the first option before you release
> the button, by accident.
> 
> I believe press and hold only makes sense in the case of touch and should
> not be default for anything with buttons (eg stylus/pen, mouse, trackball,
> touchpad buttons, etc.)
> 
> Touch and hold could be a great _optional_ feature for the minority who own
> and use a touch enabled device, but shouldn't be default behavior,
> especially when not even using touch.

When I said this, it was referring to the context menus in other areas:
> Other context menus (on layers docker and others), however, only pops up on
> a right-mouse-button release event, at least on Windows.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391696] Right click with wacom pen auto selects whatever I hover over on the popup palette

[Storm Engineer]

https://bugs.kde.org/show_bug.cgi?id=391696

--- Comment #8 from Storm Engineer  ---
(In reply to Alvin Wong from comment #6)
> it also happens when using a mouse.
I can confirm. I never noticed.*

> I don't see a problem with them
Using the menus and palette with my Wacom pen is very frustrating and sometimes
outright painful. Constantly selecting things I don't mean, constantly picking
brushes and colors when I just want to open the palette.

And most importantly it makes no sense since the side button is set to be a
right click - why is this right click behaving entirely different from my mouse
right click?

* The huge difference is that a mouse cursor generally stays in the same place
as you click - a pen held hovering over the tablet is unstable, so it's very
easy for it to move over to the first option before you release the button, by
accident.

I believe press and hold only makes sense in the case of touch and should not
be default for anything with buttons (eg stylus/pen, mouse, trackball, touchpad
buttons, etc.)

Touch and hold could be a great _optional_ feature for the minority who own and
use a touch enabled device, but shouldn't be default behavior, especially when
not even using touch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391696] Right click with wacom pen auto selects whatever I hover over on the popup palette

[Alvin Wong]

https://bugs.kde.org/show_bug.cgi?id=391696

--- Comment #7 from Alvin Wong  ---
*** Bug 375073 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391696] Right click with wacom pen auto selects whatever I hover over on the popup palette

[Alvin Wong]

https://bugs.kde.org/show_bug.cgi?id=391696

Alvin Wong  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
Summary|Right click with wacom pen  |Right click with wacom pen
   |auto selects whatever I |auto selects whatever I
   |hover over  |hover over on the popup
   ||palette

--- Comment #6 from Alvin Wong  ---
The popup palette behaviour appears to be a special case as I recall that it is
invoked on a tablet press-with-side-button event, instead of a mouse
right-button down/up event. As a result, the actual (synthesized) mouse press
event gets sent to the popup palette and thus the following mouse release event
can trigger a brush preset selection.

Putting it this way, it does seem to be an unintended behaviour of how the
popup palette works. It doesn't happen with a mouse right-click.


(In reply to Storm Engineer from comment #4)
> This also causes context menus to operate in a "hold and release to select"
> manner, which I thought to be intentional.

I was about to say that this doesn't happen, but then I realized it does happen
with the context menus on the canvas when using certain tools. It does seem to
be intentional because it also happens when using a mouse. Other context menus
(on layers docker and others), however, only pops up on a right-mouse-button
release event, at least on Windows. I don't see a problem with them

This commit seems relevant:
https://github.com/KDE/krita/commit/259d5f8253da02717ca5e985e0b979c8a15e3165#diff-aab2f60d332f75c298562b5349d57039

-- 
You are receiving this mail because:
You are watching all bug changes.