[krita] [Bug 392343] Text editor's Font-Style droplist and Bold button are broken

2021-09-25 Thread Tyson Tan
https://bugs.kde.org/show_bug.cgi?id=392343

--- Comment #13 from Tyson Tan  ---
Thank you Artem and Halla! :D

One thing though: after this fix, the Style droplist can CHANGE the style, but
it does not SHOW the current style -- it is stuck as "regular". Unlike the Size
droplist which shows the current size of the cursor position.

Do I open a new bug, or do I reopen this bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 392343] Text editor's Font-Style droplist and Bold button are broken

2021-09-24 Thread Halla Rempt
https://bugs.kde.org/show_bug.cgi?id=392343

Halla Rempt  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/371894fec |hics/krita/commit/af510b47a
   |a52dec75ac2c33aebccbfe7ba75 |fc7368a2d2a34cc8d2730070f09
   |b6a7|f27e

--- Comment #12 from Halla Rempt  ---
Git commit af510b47afc7368a2d2a34cc8d2730070f09f27e by Halla Rempt, on behalf
of Black Cat.
Committed on 24/09/2021 at 08:43.
Pushed by rempt into branch 'krita/5.0'.

Fix applying font styles to text in vector text tool

* Apply font style as combination of font weight and italization
* Show correct font style and font properties (bold, italic, etc) on
  cursor change or font style update
* Fix text changing format and loosing whitespaces while switching
  from Rich Text to Svg Source tab

(cherry picked from commit 371894feca52dec75ac2c33aebccbfe7ba75b6a7)

M  +6-9libs/flake/text/KoSvgTextShapeMarkupConverter.cpp
M  +12   -11   libs/widgetutils/kis_font_family_combo_box.cpp
M  +18   -4plugins/tools/svgtexttool/SvgTextEditor.cpp

https://invent.kde.org/graphics/krita/commit/af510b47afc7368a2d2a34cc8d2730070f09f27e

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 392343] Text editor's Font-Style droplist and Bold button are broken

2021-09-24 Thread Halla Rempt
https://bugs.kde.org/show_bug.cgi?id=392343

Halla Rempt  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/371894fec
   ||a52dec75ac2c33aebccbfe7ba75
   ||b6a7
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #11 from Halla Rempt  ---
Git commit 371894feca52dec75ac2c33aebccbfe7ba75b6a7 by Halla Rempt, on behalf
of Black Cat.
Committed on 24/09/2021 at 08:33.
Pushed by rempt into branch 'master'.

Fix applying font styles to text in vector text tool

* Apply font style as combination of font weight and italization
* Show correct font style and font properties (bold, italic, etc) on
  cursor change or font style update
* Fix text changing format and loosing whitespaces while switching
  from Rich Text to Svg Source tab

M  +6-9libs/flake/text/KoSvgTextShapeMarkupConverter.cpp
M  +12   -11   libs/widgetutils/kis_font_family_combo_box.cpp
M  +18   -4plugins/tools/svgtexttool/SvgTextEditor.cpp

https://invent.kde.org/graphics/krita/commit/371894feca52dec75ac2c33aebccbfe7ba75b6a7

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 392343] Text editor's Font-Style droplist and Bold button are broken

2021-09-23 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=392343

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #10 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/graphics/krita/-/merge_requests/1065

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 392343] Text editor's Font-Style droplist and Bold button are broken

2021-02-03 Thread Halla Rempt
https://bugs.kde.org/show_bug.cgi?id=392343

Halla Rempt  changed:

   What|Removed |Added

 CC||ha...@valdyas.org
 Status|ASSIGNED|CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 392343] Text editor's Font-Style droplist and Bold button are broken

2020-10-05 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=392343

Dmitry Kazakov  changed:

   What|Removed |Added

   Assignee|dimul...@gmail.com  |krita-bugs-n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 392343] Text editor's Font-Style droplist and Bold button are broken

2020-05-13 Thread Tyson Tan
https://bugs.kde.org/show_bug.cgi?id=392343

--- Comment #9 from Tyson Tan  ---
May I ask if we can, for the moment, just disable the "auto-completion" and
"automatically selecting a font as you type" thing for the input box? It's very
broken at the moment, inputting a font name is basically impossible and it
really makes life so difficult around the text tool. Accessing font-style is
also a nightmare because of it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 392343] Text editor's Font-Style droplist and Bold button are broken

2020-03-21 Thread Rebecca Breu
https://bugs.kde.org/show_bug.cgi?id=392343

Rebecca Breu  changed:

   What|Removed |Added

 CC||rebe...@rbreu.de

--- Comment #8 from Rebecca Breu  ---
Bold is already broken in 4.2.8, see 419081. (I can confirm that as well).

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 392343] Text editor's Font-Style droplist and Bold button are broken

2020-03-21 Thread Rebecca Breu
https://bugs.kde.org/show_bug.cgi?id=392343

Rebecca Breu  changed:

   What|Removed |Added

 CC||danielpet...@outlook.com

--- Comment #7 from Rebecca Breu  ---
*** Bug 419081 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 392343] Text editor's Font-Style droplist and Bold button are broken

2020-03-19 Thread Tyson Tan
https://bugs.kde.org/show_bug.cgi?id=392343

--- Comment #6 from Tyson Tan  ---
Today I found out what broke the droplist workaround, as well as discovering a
new workaround to make use of font styles.



### What broke the droplist workaround:

For some reason, now in 4.3.0prealpha, whenever I tried to input some letters
inside the Text Editor's font name droplist, the moment I put the second
letter, all new letters (the first and second letter I just input) get
HIGHLIGHTED. So now if I input a third letter, the previous two letters are
deleted.



### Workaround 1:

Press Left Arrow key to cancel the highlight state and move the input cursor to
the end. Do this once every two letters are input.

To input "Bold":
1) Input "B" and "o"
2) Press Left arrow
3) Input "l"
4) Press Left arrow
5) Input "d"
6) Press Left arrow

If the added letters match a style name, it will be activated.



### Workaround 2:

Tool options panel of the Text tool has a font droplist as well, and that
droplist for some reason lists EVERY font style. In this way we can determine a
font with its native style before we create the actual text.



### The missing Bold style:

Curiously though, this droplist in Tool options doesn't list any font's Bold
style! I wonder whether the Bold ones were linked to/confused with the Bold 
button in Text Editor's toolbar, which in turn broke both ways as a result?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 392343] Text editor's Font-Style droplist and Bold button are broken

2020-03-15 Thread Tyson Tan
https://bugs.kde.org/show_bug.cgi?id=392343

Tyson Tan  changed:

   What|Removed |Added

Summary|Text editor does not|Text editor's Font-Style
   |respect native font-style,  |droplist and Bold button
   |only the ones on its|are broken
   |toolbar |

-- 
You are receiving this mail because:
You are watching all bug changes.