[krita] [Bug 394199] Frame flipping behaviour is inconsistent in isolate layer mode for invisible layers.

[Eoin O'Neill]

https://bugs.kde.org/show_bug.cgi?id=394199

Eoin O'Neill  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
   |krita/commit/207c48948edb94 |krita/commit/88342ecc54f0ff
   |f81fc41898ffd6e55c596155ea  |d9a9cdc9c2da69b4ff33b0f086

--- Comment #5 from Eoin O'Neill  ---
Git commit 88342ecc54f0ffd9a9cdc9c2da69b4ff33b0f086 by Eoin O'Neill.
Committed on 12/05/2020 at 21:08.
Pushed by eoinoneill into branch 'krita/4.3'.

Fix: Properly Play Animations / Display Onion Skins During Isolation of Hidden
Layers

Also correctly shows onion skins during isolation. Also fixes some edge
cases where drawing on isolated layers didn't work properly.
(cherry-picked from master: commit 207c48948edb94f81fc41898ffd6e55c596155ea)

M  +12   -2libs/image/kis_base_node.cpp
M  +6-0libs/image/kis_base_node.h
M  +47   -19   libs/image/kis_image.cc
M  +1-1libs/image/kis_layer.cc
M  +2-1libs/image/kis_projection_leaf.cpp

https://invent.kde.org/kde/krita/commit/88342ecc54f0ffd9a9cdc9c2da69b4ff33b0f086

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 394199] Frame flipping behaviour is inconsistent in isolate layer mode for invisible layers.

[Eoin O'Neill]

https://bugs.kde.org/show_bug.cgi?id=394199

Eoin O'Neill  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/kde/
   ||krita/commit/207c48948edb94
   ||f81fc41898ffd6e55c596155ea
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Eoin O'Neill  ---
Git commit 207c48948edb94f81fc41898ffd6e55c596155ea by Eoin O'Neill.
Committed on 12/05/2020 at 20:57.
Pushed by eoinoneill into branch 'master'.

Fix: Properly Play Animations / Display Onion Skins During Isolation of Hidden
Layers

Also correctly shows onion skins during isolation. Also fixes some edge
cases where drawing on isolated layers didn't work properly.

M  +12   -2libs/image/kis_base_node.cpp
M  +6-0libs/image/kis_base_node.h
M  +47   -19   libs/image/kis_image.cc
M  +1-1libs/image/kis_layer.cc
M  +2-1libs/image/kis_projection_leaf.cpp

https://invent.kde.org/kde/krita/commit/207c48948edb94f81fc41898ffd6e55c596155ea

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 394199] Frame flipping behaviour is inconsistent in isolate layer mode for invisible layers.

[Eoin O'Neill]

https://bugs.kde.org/show_bug.cgi?id=394199

Eoin O'Neill  changed:

   What|Removed |Added

 CC||eoinoneill1...@gmail.com

--- Comment #3 from Eoin O'Neill  ---
More notes from dmitry:

-

afaict, the following should be done:
1) KisProjectionLeaf should override node visibility if the node is exactly the
root of the isolation
2) StartIsolatedModeStroke::initStrokeCallback should check if the
node->projectionLeaf()->visible() has changed during assignment of the root
if it has changed, updates should be issued
3) These updates should be done with blockUIUpdates set to false (like it is
done in KisProcessingApplicator)
4) notifyProjectionUpdatedInPatches() and all the final updates stuff should go
into a separate StartIsolatedModeStroke::finishStrokeCallback(), which should
be barrier

this->enableJob(JOB_INIT, true, KisStrokeJobData::BARRIER)

5) It might be that

m_node->projectionLeaf()->explicitlyRegeneratePassThroughProjection(); can be
replaced with these new updates, but i'm not sure. It should be a separate
patch for sure

6) There should also be an optimization, these updates should not be issued for
that layers without any internal projections/caches (not listed in my list in
the bug). You might want to add some new method to KisBaseNode, like
'hasProjectionsForUpdateWhileHidden()'
for normal layers it should return "this->needProjection()", for KisShapeLayer
it shoudl always return true

---

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 394199] Frame flipping behaviour is inconsistent in isolate layer mode for invisible layers.

[Tymond]

https://bugs.kde.org/show_bug.cgi?id=394199

Tymond  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 394199] Frame flipping behaviour is inconsistent in isolate layer mode for invisible layers.

[Emmet O'Neill]

https://bugs.kde.org/show_bug.cgi?id=394199

Emmet O'Neill  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |emmetoneill@gmail.com
 CC||emmetoneill@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 394199] Frame flipping behaviour is inconsistent in isolate layer mode for invisible layers.

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=394199

Dmitry Kazakov  changed:

   What|Removed |Added

Summary|Playback and frame flipping |Frame flipping behaviour is
   |behaviour is inconsistent   |inconsistent in isolate
   |in isolate layer mode for   |layer mode for invisible
   |invisible layers.   |layers.

-- 
You are receiving this mail because:
You are watching all bug changes.