[krita] [Bug 395273] Rectangular artifacts when painting with Quick Brush on a Transparency Mask

2018-07-25 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=395273

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kri
   ||ta/db2d098d56ef3aad73799f8e
   ||2c7ffaad575237ad
 Status|ASSIGNED|RESOLVED

--- Comment #2 from Dmitry Kazakov  ---
Git commit db2d098d56ef3aad73799f8e2c7ffaad575237ad by Dmitry Kazakov.
Committed on 25/07/2018 at 16:50.
Pushed by dkazakov into branch 'master'.

Selection masks can paint outside internal selection

This patch was originally intended to fix
KisTransparencyMaskTest but it turned out it also
fixes artifacts while painting/clearing on transparency
masks.

M  +5-0libs/image/kis_transparency_mask.cc
M  +2-0libs/image/kis_transparency_mask.h

https://commits.kde.org/krita/db2d098d56ef3aad73799f8e2c7ffaad575237ad

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 395273] Rectangular artifacts when painting with Quick Brush on a Transparency Mask

2018-07-12 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=395273

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
 Ever confirmed|0   |1
   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com
 CC||b...@valdyas.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 395273] Rectangular artifacts when painting with Quick Brush on a Transparency Mask

2018-07-04 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=395273

--- Comment #1 from Dmitry Kazakov  ---
Git commit cf035350d949d47b711033c0aace91d960c8a685 by Dmitry Kazakov.
Committed on 04/07/2018 at 09:50.
Pushed by dkazakov into branch 'master'.

Test for rectangular artifacts on transparency masks

The problem itself is not solved yet. Only a test that
can reproduce it in a stable way is implemented.

The only things that I know right now is:

1) The problem is related to multithreading. It doesn't
   appear when the number of threads is limited to 1.

2) Artifacts appear only after clearing the transparency
   paint device.

3) Artifacts are neither present in the transparency mask
   paint device, nor in the projection of its parent layer.

4) Artifacts appear in the final image projection, right
   when the async merger calls layer->projectionPlane()->
   ->apply().

5) Changing dirtyRect in KisToolUtils::clearImage() to the
   entire image bounds doesn't help much.

M  +5-0libs/ui/tests/CMakeLists.txt
A  +134  -0libs/ui/tests/KisPaintOnTransparencyMaskTest.cpp [License:
UNKNOWN]  *
A  +15   -0libs/ui/tests/KisPaintOnTransparencyMaskTest.h [License:
UNKNOWN]  *
A  +---libs/ui/tests/data/testing_wet_circle.kpp
M  +5-0sdk/tests/stroke_testing_utils.cpp
M  +1-0sdk/tests/stroke_testing_utils.h

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://commits.kde.org/krita/cf035350d949d47b711033c0aace91d960c8a685

-- 
You are receiving this mail because:
You are watching all bug changes.