[krita] [Bug 395643] Krita shows an error message about loosing layer infos, but there are no layers
https://bugs.kde.org/show_bug.cgi?id=395643 Andrey changed: What|Removed |Added Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri |ta/9eb1c15eb90b558cd6c1 |ta/c7fb30c297d4c36360500b2c |982eda7d2ef2060b|d8a65038a8db8688 --- Comment #18 from Andrey --- Git commit c7fb30c297d4c36360500b2cd8a65038a8db8688 by Andrey Kamakin, on behalf of Boudewijn Rempt. Committed on 26/06/2018 at 14:18. Pushed by akamakin into branch 'akamakin/T8628-multithreading-optimization'. Improve the message in the multilayer check M +1-1libs/impex/MultiLayerCheck.h https://commits.kde.org/krita/c7fb30c297d4c36360500b2cd8a65038a8db8688 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395643] Krita shows an error message about loosing layer infos, but there are no layers
https://bugs.kde.org/show_bug.cgi?id=395643 --- Comment #17 from BenderIRC --- Your right, from the job done so far, i was imagening a bigger team for krita, as it's one of the lighthouse projects for OSS development. Ok, in this case, take it from a guy whos coding for 35 years now: Adding this hint messages does not help the user whos seeing the dropbox, because hes not clicking there, as i did. Users don't tend to do this, it's not obvious for the work flow. The better way is to add a check before the message is displayed, who ensures, that it's only shown when really needed. Displaying the selection area will never be noticed as a "mistake/bug/reason" for displaying this error message. I already talked with different people about this matter today, and they all agree, that what you planed, does not solve the problem. I doN#t argument for myself, as i now know what and why it happens, but normal users with no background will never understand why you display a message, and write inside, that he can ignore it, when ... Normal users will always consider it as a major bug when a warning message is shown. There is no way to deny this. Go grab your neigbour , place him infront of your terminal, let him execute the steps, and check his reaction to the message box. You will instantly accept all I tried to tell you today ;) You will see.. trust an old dev ;) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395643] Krita shows an error message about loosing layer infos, but there are no layers
https://bugs.kde.org/show_bug.cgi?id=395643 --- Comment #16 from Boudewijn Rempt --- Yes, I know what QA means. I think you might be under a misapprehension here. This is an open source project, not a company. We've got a full-time project maintainer and lead developer (me, funded by sales in the Windows Store), another full-time developer (funded by donations) and a bunch of volunteers from all over the world. We make decisions together, and we have a volunteer who does a lot of UI polish work, but we do not have a "QA contact". -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395643] Krita shows an error message about loosing layer infos, but there are no layers
https://bugs.kde.org/show_bug.cgi?id=395643 --- Comment #15 from BenderIRC --- Quality Assurance -> Team Leadership -> Main Designer -> Master of Deaster -> Someone who does the UI decisions that kind of contacts ;) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395643] Krita shows an error message about loosing layer infos, but there are no layers
https://bugs.kde.org/show_bug.cgi?id=395643 --- Comment #14 from Boudewijn Rempt --- What QA contact? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395643] Krita shows an error message about loosing layer infos, but there are no layers
https://bugs.kde.org/show_bug.cgi?id=395643 --- Comment #13 from BenderIRC --- Sorry, i have to insist, that adding more informations to a message, that should never be triggered in the first place, isn't a solution at all. Any userinteraction should be as easy & clear as possible. This error message should simply not there for what happened. Even a fix like "we autotrigger deselect() before opening a savecontext" would be better than this! If you just add an additional line of infos, noone will read this, as all you can see directly without clicking on the error message, is not helpful at all and does not change due to your solution. So it's not only "not a solution", but also "not helpful at all" :D Accept it, keeping that message there, for an open areaselecting, is just wrong. If you don't trust me, give it to the QA contact, he/she will see this in the same way. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395643] Krita shows an error message about loosing layer infos, but there are no layers
https://bugs.kde.org/show_bug.cgi?id=395643 --- Comment #12 from David REVOY --- @BlenderIRC: It is not an error message; it is a warning and the saving pop-up is not designed to be a validator with checkbox. So, the commit and solution looks acceptable to me and good enough to informs the user about what is happening. You can mark the bug solved on bugzilla.redhat.com. @Boud: Thank you for the super quick fix @Boud! -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395643] Krita shows an error message about loosing layer infos, but there are no layers
https://bugs.kde.org/show_bug.cgi?id=395643 --- Comment #11 from BenderIRC --- äh... "improoving the message" isn't the correct behaviour. Add a check if the selected area is the only reason for the message and than supressing it would be the right way to solve this. Your Approach is "This is an error message for an error thats not an error at all." Sorry, not acceptable :D -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395643] Krita shows an error message about loosing layer infos, but there are no layers
https://bugs.kde.org/show_bug.cgi?id=395643 Boudewijn Rempt changed: What|Removed |Added CC||b...@valdyas.org --- Comment #10 from Boudewijn Rempt --- assistants shouldn't trigger the issue, though. Maybe reference images would. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395643] Krita shows an error message about loosing layer infos, but there are no layers
https://bugs.kde.org/show_bug.cgi?id=395643 --- Comment #9 from Boudewijn Rempt --- Aw, I pushed an improved message before I saw your suggestion... -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395643] Krita shows an error message about loosing layer infos, but there are no layers
https://bugs.kde.org/show_bug.cgi?id=395643 Boudewijn Rempt changed: What|Removed |Added Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri |ta/bec019d1fd4e4d2fc7d07856 |ta/9eb1c15eb90b558cd6c1 |b202dc03665b9504|982eda7d2ef2060b --- Comment #8 from Boudewijn Rempt --- Git commit 9eb1c15eb90b558cd6c1982eda7d2ef2060b by Boudewijn Rempt. Committed on 20/06/2018 at 12:05. Pushed by rempt into branch 'krita/4.1'. Improve the message in the multilayer check (cherry picked from commit 3017c443022ef564d298fa53cb29d20bfc0cfe5f) M +1-1libs/impex/MultiLayerCheck.h https://commits.kde.org/krita/9eb1c15eb90b558cd6c1982eda7d2ef2060b -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395643] Krita shows an error message about loosing layer infos, but there are no layers
https://bugs.kde.org/show_bug.cgi?id=395643 Boudewijn Rempt changed: What|Removed |Added Latest Commit||https://commits.kde.org/kri ||ta/bec019d1fd4e4d2fc7d07856 ||b202dc03665b9504 Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #7 from Boudewijn Rempt --- Git commit bec019d1fd4e4d2fc7d07856b202dc03665b9504 by Boudewijn Rempt. Committed on 20/06/2018 at 12:05. Pushed by rempt into branch 'master'. Improve the message in the multilayer check M +1-1libs/impex/MultiLayerCheck.h https://commits.kde.org/krita/bec019d1fd4e4d2fc7d07856b202dc03665b9504 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395643] Krita shows an error message about loosing layer infos, but there are no layers
https://bugs.kde.org/show_bug.cgi?id=395643 --- Comment #6 from David REVOY --- Ok. So, the only thing to fix here is the error message. It needs to list more reasons than just multi-layers. From: > You will lose information when saving this image as a PNG image. Reason: > - The image has more than one layer. Only the flattened image will be saved. To: > You will lose information when saving this image as a PNG image. POSSIBLE > reasonS: > - The image has more than one layer. Only the flattened image will be saved. > - The image contains a selection. This data will be lost > - The image contains (Assistants, Grids, Rulers). This data will be lost. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395643] Krita shows an error message about loosing layer infos, but there are no layers
https://bugs.kde.org/show_bug.cgi?id=395643 BenderIRC changed: What|Removed |Added Status|NEEDSINFO |CONFIRMED Ever confirmed|0 |1 Resolution|WAITINGFORINFO |--- --- Comment #5 from BenderIRC --- Confirmed: "Deselecting All" before calling the save dialog avoids the message. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395643] Krita shows an error message about loosing layer infos, but there are no layers
https://bugs.kde.org/show_bug.cgi?id=395643 --- Comment #4 from David REVOY --- Thank you for the informations. The behavior you describe sounds totally normal: by having a selection (I can see the marching ants on your screenshot) you add informations on the canvas that Krita will not able to save in a PNG image. The warning message here does perfectly its job and act on purpose. Can you reproduce if you go to Select > Deselect Before saving? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395643] Krita shows an error message about loosing layer infos, but there are no layers
https://bugs.kde.org/show_bug.cgi?id=395643 --- Comment #3 from BenderIRC --- Created attachment 113458 --> https://bugs.kde.org/attachment.cgi?id=113458=edit RAW unaltered Image for testing -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395643] Krita shows an error message about loosing layer infos, but there are no layers
https://bugs.kde.org/show_bug.cgi?id=395643 --- Comment #2 from BenderIRC --- Version A 1. Taking a Screenshot via Cinnamonds Screensshottool 2. open krita for editing from the picture preview in nemo 3. Trimming the picture to a smaller area 4. Hitting CTRL+S 5. getting this message. B 2. open krita for editing from the picture preview in nemo for any picture 3. Trimming the picture to a smaller area 4. Hitting CTRL+S 5. getting this message. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395643] Krita shows an error message about loosing layer infos, but there are no layers
https://bugs.kde.org/show_bug.cgi?id=395643 David REVOY changed: What|Removed |Added CC||i...@davidrevoy.com Resolution|--- |WAITINGFORINFO Status|UNCONFIRMED |NEEDSINFO --- Comment #1 from David REVOY --- Hi, When you open a PNG under Krita, during the time of the edition your picture's pixels have the potential to get multilayered and also all the features of Krita(Assistants, Grids, Rulers). Krita 4.0.3 (tested on appimage) doesn't trigger the warning if you just open a PNG, edit painting on it, and save it. The message appears when special features were in use during the time of editing (eg. adding an assistant). Please describe a step-by-step procedure to reproduce the scenario on a file where you estimate the warning message is an error. -- You are receiving this mail because: You are watching all bug changes.
