[krita] [Bug 399723] A visual glitch when using multiple views of the same document and soft proofing

2021-12-01 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=399723

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/02f37d051
   ||4e6b5e6ed9fed86a5fa2680ab2e
   ||2b25
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Dmitry Kazakov  ---
Git commit 02f37d0514e6b5e6ed9fed86a5fa2680ab2e2b25 by Dmitry Kazakov, on
behalf of Mathias Wein.
Committed on 01/12/2021 at 10:06.
Pushed by dkazakov into branch 'master'.

Fix soft proofing settings affecting other views

Contrary to the description, setProofingOptions() was messing with the
options stored inside the image.
Updating settings also avoids unnecessary canvas updates now when
soft proofing is not active.

M  +2-2libs/ui/KisView.cpp
M  +30   -23   libs/ui/canvas/kis_canvas2.cpp
M  +7-5libs/ui/canvas/kis_canvas2.h

https://invent.kde.org/graphics/krita/commit/02f37d0514e6b5e6ed9fed86a5fa2680ab2e2b25

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399723] A visual glitch when using multiple views of the same document and soft proofing

2021-12-01 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=399723

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/02f37d051 |hics/krita/commit/09713f284
   |4e6b5e6ed9fed86a5fa2680ab2e |0d4ce831aab9cc576d7f44bfd12
   |2b25|55f7

--- Comment #5 from Dmitry Kazakov  ---
Git commit 09713f2840d4ce831aab9cc576d7f44bfd1255f7 by Dmitry Kazakov, on
behalf of Mathias Wein.
Committed on 01/12/2021 at 10:16.
Pushed by dkazakov into branch 'krita/5.0'.

Fix soft proofing settings affecting other views

Contrary to the description, setProofingOptions() was messing with the
options stored inside the image.
Updating settings also avoids unnecessary canvas updates now when
soft proofing is not active.
(cherry picked from commit 02f37d0514e6b5e6ed9fed86a5fa2680ab2e2b25)

M  +2-2libs/ui/KisView.cpp
M  +30   -23   libs/ui/canvas/kis_canvas2.cpp
M  +7-5libs/ui/canvas/kis_canvas2.h

https://invent.kde.org/graphics/krita/commit/09713f2840d4ce831aab9cc576d7f44bfd1255f7

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399723] A visual glitch when using multiple views of the same document and soft proofing

2018-10-14 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=399723

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 CC||b...@valdyas.org
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Boudewijn Rempt  ---
I haven't seen it happen myself. Does this also happen for you if you disable
canvas acceleration? 

If so, I think that this might be caused by Krita using the same textures for
both views, which we do to save memory.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399723] A visual glitch when using multiple views of the same document and soft proofing

2018-11-27 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=399723

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|REOPENED|CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399723] A visual glitch when using multiple views of the same document and soft proofing

2018-11-04 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=399723

8172...@mail.com changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |REOPENED

--- Comment #3 from 8172...@mail.com ---
Some extra details:

- I tested this with some more file types, and it really seems to occur only
with KRA files, but only if it's a previously saved file that has been
re-opened

- Can't reproduce it with canvas acceleration turned off, because I can't get
soft proofing to work without canvas acceleration

- The problem gets temporary solved after turning soft proofing on and off for
the subwindow that's supposed to have it turned off. The problem reoccurs as
soon as soft proofing is turned off and on again for the other window.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399723] A visual glitch when using multiple views of the same document and soft proofing

2018-10-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=399723

--- Comment #2 from 8172...@mail.com ---
(In reply to Boudewijn Rempt from comment #1)
> I haven't seen it happen myself. Does this also happen for you if you
> disable canvas acceleration? 
> 
> If so, I think that this might be caused by Krita using the same textures
> for both views, which we do to save memory.

I can't reproduce it with canvas acceleration turned off, but for a very
different reason – I can't get soft proofing to work that way. It shows the
'Soft Proofing turned on' message, but the view doesn't change at all. Not sure
if that's some problem on my side or just the way it works. 

Using the same textures for both views might explain it, but why does it only
occur after opening a previously created KRA file? Shouldn't it be the same for
all formats and even newly created files?

-- 
You are receiving this mail because:
You are watching all bug changes.