[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability
https://bugs.kde.org/show_bug.cgi?id=400357 --- Comment #18 from David REVOY --- Thank you @Dmitry Utkin for fixing this bug and to @Boud too for shipping it with Krita 4.2.1 today. Super! -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability
https://bugs.kde.org/show_bug.cgi?id=400357 Boudewijn Rempt changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #17 from Boudewijn Rempt --- Fixed in commit 98d97d0e7f900ad8be59faa0dc33e84648feda53 Author: Dmitrii Utkin Date: Mon May 27 18:11:20 2019 + 400357 don't update editor's text by setEditorData -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability
https://bugs.kde.org/show_bug.cgi?id=400357 --- Comment #16 from Dmitry Utkin --- Thanks for help, I managed to create the account. Here is the MR: https://invent.kde.org/kde/krita/merge_requests/33 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability
https://bugs.kde.org/show_bug.cgi?id=400357 --- Comment #15 from wolthera --- Hey Dmitry, did you make a KDE Identity account? At identity.kde.org? (It's a seperate login than the bugtracker, but on the plus side, basically every other KDE infra(forums, wikis, gitlab) except the bugtracker can use it) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability
https://bugs.kde.org/show_bug.cgi?id=400357 --- Comment #14 from Dmitry Utkin --- Dear @wolthera, I'd like to create a fork and Merge Request, but could you please help me with login to gitlab? Looks like it should use the same account as here, but I cannot login with it: "Invalid credentials". I tried with "KDE identity" and "Standard" options. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability
https://bugs.kde.org/show_bug.cgi?id=400357 --- Comment #13 from wolthera --- Hey Dmitry, Would you like to try applying that patch to a fork of yours on the KDE gitlab instance(and then make a merge request)? https://invent.kde.org/kde/krita If you don't, that's okay, it'll just make code review a little easier for us :) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability
https://bugs.kde.org/show_bug.cgi?id=400357 --- Comment #12 from Dmitry Utkin --- Created attachment 120311 --> https://bugs.kde.org/attachment.cgi?id=120311=edit Disable updating layer name upon thumbnail update I had some debug session today and found the reason of the bug. It comes from the timer which updates the thumbnail which drops to "LayerBox::updateThumbnail()" -> "NodeView::updateNode()" -> "NodeView::dataChanged(...)" -> "NodeDelegate::setEditorData(...)". There is no reason to update layer name in edit box every time when that signal is emitted, actually, it's sufficient enough to update it for the first time only when the layer name is to be put to the editbox, because of the second and further signals are came from "updateThumbnail". I didn't find an other simple way to fix it, but this patch works reliable enough and do not revert layer name any more. Please consider this patch, it fixes the bug, but I'm not sure if it is the correct way to go. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability
https://bugs.kde.org/show_bug.cgi?id=400357 Boudewijn Rempt changed: What|Removed |Added CC||loen...@gmail.com --- Comment #11 from Boudewijn Rempt --- *** Bug 405310 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability
https://bugs.kde.org/show_bug.cgi?id=400357 Boudewijn Rempt changed: What|Removed |Added CC||kstg...@gmail.com --- Comment #10 from Boudewijn Rempt --- *** Bug 405334 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability
https://bugs.kde.org/show_bug.cgi?id=400357 --- Comment #9 from mvowada --- Created attachment 118713 --> https://bugs.kde.org/attachment.cgi?id=118713=edit Video example 2 (timing) (Checked with Krita 4.2.0-pre-alpha (git c2fbec1) Hi, could be a timing issue (see video)? If I do click the layer and quickly hit F2, then the text will lose its selection/highlighting. Where if I click the layer, wait a few seconds and hit F2, then the text will remain highlighted/selected. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability
https://bugs.kde.org/show_bug.cgi?id=400357 --- Comment #8 from Boudewijn Rempt --- Git commit 078429964d4fbb897b42374959e22961403bb42d by Boudewijn Rempt. Committed on 20/11/2018 at 08:25. Pushed by rempt into branch 'krita/4.1'. Give the delegate StrongFocus, as per Qt documentation See http://doc.qt.io/qt-5/qabstractitemdelegate.html#createEditor M +2-1libs/ui/KisNodeDelegate.cpp https://commits.kde.org/krita/078429964d4fbb897b42374959e22961403bb42d -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability
https://bugs.kde.org/show_bug.cgi?id=400357 --- Comment #7 from wolthera --- I still get this issue here on git 9697760 :| -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability
https://bugs.kde.org/show_bug.cgi?id=400357 --- Comment #6 from Boudewijn Rempt --- Git commit dd0a38e89d8996b524d517710c3f903e4d240d18 by Boudewijn Rempt. Committed on 30/10/2018 at 13:26. Pushed by rempt into branch 'master'. Give the delegate StrongFocus, as per Qt documentation See http://doc.qt.io/qt-5/qabstractitemdelegate.html#createEditor M +2-1libs/ui/KisNodeDelegate.cpp https://commits.kde.org/krita/dd0a38e89d8996b524d517710c3f903e4d240d18 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability
https://bugs.kde.org/show_bug.cgi?id=400357 Boudewijn Rempt changed: What|Removed |Added CC||b...@valdyas.org --- Comment #5 from Boudewijn Rempt --- I don't really this happening, but maybe that's because I'm using an external mouse, or a different xcb implementation, or something else. I'm not sure what we can do about it. If there's a fix, it probably will be in KisNodeDelegate::editorEvent -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability
https://bugs.kde.org/show_bug.cgi?id=400357 wolthera changed: What|Removed |Added CC||griffinval...@gmail.com Keywords||triaged --- Comment #4 from wolthera --- confirmed here too. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability
https://bugs.kde.org/show_bug.cgi?id=400357 --- Comment #3 from mvowada --- The exact steps are: 1. click on "layer A", once 2. double click on "layer B" (it works) 3. click on "layer A" once 4. double click on "layer B" -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability
https://bugs.kde.org/show_bug.cgi?id=400357 mvowada changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #2 from mvowada --- Confirming. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability
https://bugs.kde.org/show_bug.cgi?id=400357 mvowada changed: What|Removed |Added CC||freebo...@tiscali.it --- Comment #1 from mvowada --- Created attachment 115919 --> https://bugs.kde.org/attachment.cgi?id=115919=edit (Video) (Krita appimage 4.2.0-pre-alpha (git 55c0c6d) - Ubuntu 14.04, Unity) Hi, here I can reproduce the issue with these steps (see video): 1. click on any layer once 2. double click the actual layer you need to rename. Actual Results: text highlighting disappears after a second -- You are receiving this mail because: You are watching all bug changes.
