[krita] [Bug 402494] Merging down a layer with colourise mask

2018-12-23 Thread Boudewijn Rempt 
https://bugs.kde.org/show_bug.cgi?id=402494

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||b...@valdyas.org
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #1 from Boudewijn Rempt  ---
Thanks for the report and for the extremely helpful test file! I can confirm
the crash:

Application: Krita (krita), signal: Aborted
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f5878d69800 (LWP 32447))]

Thread 6 (Thread 0x7f585f7fe700 (LWP 32454)):
#0  0x7f587d993524 in g_mutex_unlock () from
/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#1  0x7f587d94c36c in g_main_context_prepare () from
/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x7f587d94cd7b in ?? () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7f587d94cf6c in g_main_context_iteration () from
/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#4  0x7f588126a15b in
QEventDispatcherGlib::processEvents(QFlags) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#5  0x7f588121716b in
QEventLoop::exec(QFlags) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#6  0x7f58810660b6 in QThread::exec() () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#7  0x7f587594e1f5 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#8  0x7f588106fc87 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#9  0x7f587e7f9164 in start_thread (arg=) at
pthread_create.c:486
#10 0x7f5880d39def in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 5 (Thread 0x7f585effd700 (LWP 32453)):
#0  syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38
#1  0x7f5881064fd0 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#2  0x7f5881064e42 in QSemaphore::tryAcquire(int, int) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#3  0x7f587f994f33 in KisTileDataSwapper::waitForWork (this=) at
/home/boud/dev/krita/libs/image/tiles3/swap/kis_tile_data_swapper.cpp:86
#4  0x7f587f99516a in KisTileDataSwapper::run (this=0x7f587fe06b00
<(anonymous namespace)::Q_QGS_s_instance::innerFunction()::holder+64>) at
/home/boud/dev/krita/libs/image/tiles3/swap/kis_tile_data_swapper.cpp:92
#5  0x7f588106fc87 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#6  0x7f587e7f9164 in start_thread (arg=) at
pthread_create.c:486
#7  0x7f5880d39def in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 4 (Thread 0x7f585700 (LWP 32451)):
#0  0x7f5880d2d6d9 in __GI___poll (fds=0x7f5858004a10, nfds=1, timeout=-1)
at ../sysdeps/unix/sysv/linux/poll.c:29
#1  0x7f587d94ce46 in ?? () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x7f587d94cf6c in g_main_context_iteration () from
/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7f588126a15b in
QEventDispatcherGlib::processEvents(QFlags) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#4  0x7f588121716b in
QEventLoop::exec(QFlags) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#5  0x7f58810660b6 in QThread::exec() () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#6  0x7f588106fc87 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#7  0x7f587e7f9164 in start_thread (arg=) at
pthread_create.c:486
#8  0x7f5880d39def in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 3 (Thread 0x7f586d58f700 (LWP 32450)):
#0  0x7f5880d2d6d9 in __GI___poll (fds=0x7f5860019410, nfds=1, timeout=-1)
at ../sysdeps/unix/sysv/linux/poll.c:29
#1  0x7f587d94ce46 in ?? () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x7f587d94cf6c in g_main_context_iteration () from
/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7f588126a15b in
QEventDispatcherGlib::processEvents(QFlags) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#4  0x7f588121716b in
QEventLoop::exec(QFlags) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#5  0x7f58810660b6 in QThread::exec() () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#6  0x7f587e828545 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5
#7  0x7f588106fc87 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#8  0x7f587e7f9164 in start_thread (arg=) at
pthread_create.c:486
#9  0x7f5880d39def in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 2 (Thread 0x7f586f1d2700 (LWP 32449)):
#0  futex_wait_cancelable (private=, expected=0,
futex_word=0x55b58fdf09c8) at ../sysdeps/unix/sysv/linux/futex-internal.h:88
#1  __pthread_cond_wait_common (abstime=0x0, mutex=0x55b58fdf0978,
cond=0x55b58fdf09a0) at pthread_cond_wait.c:502
#2  __pthread_cond_wait (cond=0x55b58fdf09a0, mutex=0x55b58fdf0978) at
pthread_cond_wait.c:655
#3  0x7f586f6ef46b in ?? () from /usr/lib/x86_64-linux-gnu/dri/i965_dri.so
#4  0x7f586f6ef1d7 in ?? () from /usr/lib/x8

[krita] [Bug 402494] Merging down a layer with colourise mask

2019-01-06 Thread Boudewijn Rempt 
https://bugs.kde.org/show_bug.cgi?id=402494

Boudewijn Rempt  changed:

   What|Removed |Added

   Keywords||triaged

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 402494] Merging down a layer with colourise mask

2019-03-26 Thread Tymond 
https://bugs.kde.org/show_bug.cgi?id=402494

Tymond  changed:

   What|Removed |Added

 CC||tamtamy.tym...@gmail.com
   Assignee|krita-bugs-n...@kde.org |tamtamy.tym...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 402494] Merging down a layer with colourise mask

2019-03-28 Thread Tymond 
https://bugs.kde.org/show_bug.cgi?id=402494

Tymond  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/kri
   ||ta/630ce8583cb5a9337aceb2ca
   ||96f17c2cf1df306e
 Resolution|--- |FIXED

--- Comment #2 from Tymond  ---
Git commit 630ce8583cb5a9337aceb2ca96f17c2cf1df306e by Agata Cacko.
Committed on 28/03/2019 at 20:34.
Pushed by tymond into branch 'master'.

Disable assert on empty parent in Colorize Mask

Before this change, Colorize Mask asserted after flattening
or merging with another layer when the image was smaller than 1024px
wide and long. After this commit, it shouldn't happen.

It was caused by setting the parent dirty just before the parent gets
deleted. The request was linked to refreshing area outside the image
boundaries; since Colorize Mask didn't and doesn't work outside of the
image boundaries, it isn't necessary.

NOTE: In case of providing support for Colorize Mask working outside of
the canvas boundaries, the decision in this commit might need
reevaluation (in case of a need to update the mask there).

M  +9-1libs/image/lazybrush/kis_colorize_mask.cpp

https://commits.kde.org/krita/630ce8583cb5a9337aceb2ca96f17c2cf1df306e

-- 
You are receiving this mail because:
You are watching all bug changes.