[krita] [Bug 413548] Color Selector Tool 'Add to palette:' option crashes if selected palette has been deleted

2020-01-08 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=413548

Boudewijn Rempt  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
   |krita/commit/d25b10a4c25e5f |krita/commit/7d72be15bc3a6e
   |ed309ff97b532e9eaf880f9a85  |f7a5d17bf7ac15a2770c14dcbe

--- Comment #5 from Boudewijn Rempt  ---
Git commit 7d72be15bc3a6ef7a5d17bf7ac15a2770c14dcbe by Boudewijn Rempt, on
behalf of Saurabh Kumar.
Committed on 08/01/2020 at 13:33.
Pushed by rempt into branch 'krita/4.2'.

Prevent crash on addition of color to deleted palette with colorpicker

This commit makes the deletion and addition of palette
in palette docker show in colorpicker's tool options'
Add to palette comboBox. This also prevents a crash
due to a dangling pointer due to palette pointing to
deleted memory location.

M  +60   -4plugins/tools/basictools/kis_tool_colorpicker.cc
M  +14   -3plugins/tools/basictools/kis_tool_colorpicker.h

https://invent.kde.org/kde/krita/commit/7d72be15bc3a6ef7a5d17bf7ac15a2770c14dcbe

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 413548] Color Selector Tool 'Add to palette:' option crashes if selected palette has been deleted

2019-12-20 Thread Ahab Greybeard
https://bugs.kde.org/show_bug.cgi?id=413548

--- Comment #4 from Ahab Greybeard  ---
I'll raise a separate bug report for the UI/Usability problem (which is what I
should have done in the first place).

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 413548] Color Selector Tool 'Add to palette:' option crashes if selected palette has been deleted

2019-12-19 Thread Tymond
https://bugs.kde.org/show_bug.cgi?id=413548

Tymond  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/kde/
   ||krita/commit/d25b10a4c25e5f
   ||ed309ff97b532e9eaf880f9a85
 Status|CONFIRMED   |RESOLVED

--- Comment #3 from Tymond  ---
Git commit d25b10a4c25e5fed309ff97b532e9eaf880f9a85 by Agata Cacko, on behalf
of Saurabh Kumar.
Committed on 19/12/2019 at 20:52.
Pushed by tymond into branch 'master'.

Prevent crash on addition of color to deleted palette with colorpicker

This commit makes the deletion and addition of palette
in palette docker show in colorpicker's tool options'
Add to palette comboBox. This also prevents a crash
due to a dangling pointer due to palette pointing to
deleted memory location.

M  +60   -4plugins/tools/basictools/kis_tool_colorpicker.cc
M  +14   -3plugins/tools/basictools/kis_tool_colorpicker.h

https://invent.kde.org/kde/krita/commit/d25b10a4c25e5fed309ff97b532e9eaf880f9a85

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 413548] Color Selector Tool 'Add to palette:' option crashes if selected palette has been deleted

2019-10-29 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=413548

Boudewijn Rempt  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |b...@valdyas.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 413548] Color Selector Tool 'Add to palette:' option crashes if selected palette has been deleted

2019-10-29 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=413548

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||b...@valdyas.org
 Resolution|BACKTRACE   |---
 Status|NEEDSINFO   |CONFIRMED
 Ever confirmed|0   |1

--- Comment #2 from Boudewijn Rempt  ---
I do see the New-1 palette in the color picker tool option's list of palettes,
I do see it's not removed from the combobox, and I can also confirm the crash:

Application: Krita (krita), signal: Segmentation fault
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[Current thread is 1 (Thread 0x7fbe18b6a800 (LWP 3202))]

Thread 6 (Thread 0x7fbe04889700 (LWP 3338)):
#0  0x7fbe1bbbd824 in g_mutex_unlock () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#1  0x7fbe1bb7211c in g_main_context_prepare () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x7fbe1bb72b2b in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7fbe1bb72d1c in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#4  0x7fbe1e77c063 in
QEventDispatcherGlib::processEvents(QFlags) ()
from /lib/x86_64-linux-gnu/libQt5Core.so.5
#5  0x7fbe1e7275bb in
QEventLoop::exec(QFlags) () from
/lib/x86_64-linux-gnu/libQt5Core.so.5
#6  0x7fbe1e5722c6 in QThread::exec() () from
/lib/x86_64-linux-gnu/libQt5Core.so.5
#7  0x7fbe0f773ef5 in ?? () from /lib/x86_64-linux-gnu/libQt5Qml.so.5
#8  0x7fbe1e573612 in ?? () from /lib/x86_64-linux-gnu/libQt5Core.so.5
#9  0x7fbe1c33a182 in start_thread (arg=) at
pthread_create.c:486
#10 0x7fbe1e1ecb1f in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 5 (Thread 0x7fbdf700 (LWP 3337)):
#0  syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38
#1  0x7fbe1e575c30 in ?? () from /lib/x86_64-linux-gnu/libQt5Core.so.5
#2  0x7fbe1e575aa2 in QSemaphore::tryAcquire(int, int) () from
/lib/x86_64-linux-gnu/libQt5Core.so.5
#3  0x7fbe1f9f9733 in KisTileDataSwapper::waitForWork (this=) at
/home/boud/dev/krita/libs/image/tiles3/swap/kis_tile_data_swapper.cpp:86
#4  0x7fbe1f9f996a in KisTileDataSwapper::run (this=0x7fbe1fee0e40
<(anonymous namespace)::Q_QGS_s_instance::innerFunction()::holder+64>) at
/home/boud/dev/krita/libs/image/tiles3/swap/kis_tile_data_swapper.cpp:92
#5  0x7fbe1e573612 in ?? () from /lib/x86_64-linux-gnu/libQt5Core.so.5
#6  0x7fbe1c33a182 in start_thread (arg=) at
pthread_create.c:486
#7  0x7fbe1e1ecb1f in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 4 (Thread 0x7fbe05103700 (LWP )):
#0  __GI___libc_read (nbytes=16, buf=0x7fbe05102b80, fd=28) at
../sysdeps/unix/sysv/linux/read.c:26
#1  __GI___libc_read (fd=28, buf=0x7fbe05102b80, nbytes=16) at
../sysdeps/unix/sysv/linux/read.c:24
#2  0x7fbe1bbb9410 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7fbe1bb726cf in g_main_context_check () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#4  0x7fbe1bb72ba0 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#5  0x7fbe1bb72d1c in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#6  0x7fbe1e77c063 in
QEventDispatcherGlib::processEvents(QFlags) ()
from /lib/x86_64-linux-gnu/libQt5Core.so.5
#7  0x7fbe1e7275bb in
QEventLoop::exec(QFlags) () from
/lib/x86_64-linux-gnu/libQt5Core.so.5
#8  0x7fbe1e5722c6 in QThread::exec() () from
/lib/x86_64-linux-gnu/libQt5Core.so.5
#9  0x7fbe1e573612 in ?? () from /lib/x86_64-linux-gnu/libQt5Core.so.5
#10 0x7fbe1c33a182 in start_thread (arg=) at
pthread_create.c:486
#11 0x7fbe1e1ecb1f in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 3 (Thread 0x7fbe0ebca700 (LWP 3210)):
#0  0x7fbe1bbbd824 in g_mutex_unlock () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#1  0x7fbe1bb72b1e in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x7fbe1bb72d1c in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7fbe1e77c063 in
QEventDispatcherGlib::processEvents(QFlags) ()
from /lib/x86_64-linux-gnu/libQt5Core.so.5
#4  0x7fbe1e7275bb in
QEventLoop::exec(QFlags) () from
/lib/x86_64-linux-gnu/libQt5Core.so.5
#5  0x7fbe1e5722c6 in QThread::exec() () from
/lib/x86_64-linux-gnu/libQt5Core.so.5
#6  0x7fbe1c36a565 in ?? () from /lib/x86_64-linux-gnu/libQt5DBus.so.5
#7  0x7fbe1e573612 in ?? () from /lib/x86_64-linux-gnu/libQt5Core.so.5
#8  0x7fbe1c33a182 in start_thread (arg=) at
pthread_create.c:486
#9  0x7fbe1e1ecb1f in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 2 (Thread 0x7fbe178b4700 (LWP 3209)):
#0  0x7fbe1e1e0729 in __GI___poll (fds=0x7fbe178b3ca8, nfds=1, timeout=-1)
at ../sysdeps/unix/sysv/linux/poll.c:29
#1  0x7fbe1b9e9917 in ?? () from /lib/x86_64-linux-gnu/libxcb.so.1
#2  0x7fbe1b9eb53a 

[krita] [Bug 413548] Color Selector Tool 'Add to palette:' option crashes if selected palette has been deleted

2019-10-29 Thread Sam Dyer
https://bugs.kde.org/show_bug.cgi?id=413548

Sam Dyer  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |BACKTRACE
 CC||samdyer...@outlook.com

--- Comment #1 from Sam Dyer  ---
Could you please add a backtrace to help find the cause of the crash.

-- 
You are receiving this mail because:
You are watching all bug changes.