[krita] [Bug 414699] Cloned layers create corrupted files after moving to a new document
https://bugs.kde.org/show_bug.cgi?id=414699 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/efe590e14 |hics/krita/commit/564193056 |6eff93a2bb06ef8304fb9bd9622 |96d810f9c3299ac8f3814a7a814 |c192|02e0 --- Comment #6 from Dmitry Kazakov --- Git commit 56419305696d810f9c3299ac8f3814a7a81402e0 by Dmitry Kazakov. Committed on 03/08/2021 at 08:36. Pushed by dkazakov into branch 'krita/4.3'. Reincarnate clone layers when they are D'ed into a different image M +13 -3libs/ui/kis_mimedata.cpp https://invent.kde.org/graphics/krita/commit/56419305696d810f9c3299ac8f3814a7a81402e0 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 414699] Cloned layers create corrupted files after moving to a new document
https://bugs.kde.org/show_bug.cgi?id=414699 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/efe590e14 ||6eff93a2bb06ef8304fb9bd9622 ||c192 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #5 from Dmitry Kazakov --- Git commit efe590e146eff93a2bb06ef8304fb9bd9622c192 by Dmitry Kazakov. Committed on 29/07/2021 at 12:32. Pushed by dkazakov into branch 'master'. Reincarnate clone layers when they are D'ed into a different image M +13 -3libs/ui/kis_mimedata.cpp https://invent.kde.org/graphics/krita/commit/efe590e146eff93a2bb06ef8304fb9bd9622c192 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 414699] Cloned layers create corrupted files after moving to a new document
https://bugs.kde.org/show_bug.cgi?id=414699 Dmitry Kazakov changed: What|Removed |Added Assignee|tamtamy.tym...@gmail.com|dimul...@gmail.com CC||dimul...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 414699] Cloned layers create corrupted files after moving to a new document
https://bugs.kde.org/show_bug.cgi?id=414699 --- Comment #4 from Tymond --- Git commit c7a001e171ed2923c2e88cc5397921bb3b4aa30b by Agata Cacko. Committed on 11/12/2019 at 12:49. Pushed by tymond into branch 'krita/4.2'. Fix crash opening .kra with incorrect clone source Before this commit, files created using copying and pasting clone layers from one file to another would be corrupted and crash Krita when the user tried to open them. This commit fixes crashing on opening those files. After this commit, all clone layers are replaced by empty paint layers. (Empty, because all data is lost). M +4-0libs/image/kis_async_merger.cpp M +32 -2plugins/impex/kra/kra_converter.cpp M +8-3plugins/impex/libkra/kis_kra_load_visitor.cpp https://invent.kde.org/kde/krita/commit/c7a001e171ed2923c2e88cc5397921bb3b4aa30b -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 414699] Cloned layers create corrupted files after moving to a new document
https://bugs.kde.org/show_bug.cgi?id=414699 Tymond changed: What|Removed |Added Severity|crash |major --- Comment #3 from Tymond --- It shouldn't crash any more, but it's still a dataloss... I tried to fix it by making sure clones are converted into paint layers, but it's trickier than it looks like. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 414699] Cloned layers create corrupted files after moving to a new document
https://bugs.kde.org/show_bug.cgi?id=414699 --- Comment #2 from Tymond --- Git commit cf3682662b4d6c7796b2c248b20d3fe9077a5658 by Agata Cacko. Committed on 09/12/2019 at 19:36. Pushed by tymond into branch 'master'. Fix crash opening .kra with incorrect clone source Before this commit, files created using copying and pasting clone layers from one file to another would be corrupted and crash Krita when the user tried to open them. This commit fixes crashing on opening those files. After this commit, all clone layers are replaced by empty paint layers. (Empty, because all data is lost). M +4-0libs/image/kis_async_merger.cpp M +32 -2plugins/impex/kra/kra_converter.cpp M +8-3plugins/impex/libkra/kis_kra_load_visitor.cpp https://invent.kde.org/kde/krita/commit/cf3682662b4d6c7796b2c248b20d3fe9077a5658 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 414699] Cloned layers create corrupted files after moving to a new document
https://bugs.kde.org/show_bug.cgi?id=414699 Boudewijn Rempt changed: What|Removed |Added Status|CONFIRMED |ASSIGNED Assignee|krita-bugs-n...@kde.org |tamtamy.tym...@gmail.com CC||b...@valdyas.org -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 414699] Cloned layers create corrupted files after moving to a new document
https://bugs.kde.org/show_bug.cgi?id=414699 Tymond changed: What|Removed |Added CC||tamtamy.tym...@gmail.com Ever confirmed|0 |1 Status|REPORTED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 414699] Cloned layers create corrupted files after moving to a new document
https://bugs.kde.org/show_bug.cgi?id=414699 --- Comment #1 from Tymond --- Crash here is quite straight-forward, it's just an assert in the visitor reading the clone layer from the kra file: Thread 1 (Thread 0x7fffeb49a800 (LWP 15305)): #0 0x74266077 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 #1 0x74247535 in __GI_abort () at abort.c:79 #2 0x746358d7 in () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 ---Type to continue, or q to quit--- #3 0x74634d59 in qt_assert_x(char const*, char const*, char const*, int) () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #4 0x7fffcc5ccc48 in KisKraLoadVisitor::visit(KisCloneLayer*) (this=0x7fffc1e0, layer=0x72b828f0) at /home/tymon/devsec/krita/plugins/impex/libkra/kis_kra_load_visitor.cpp:308 #5 0x75d523b5 in KisNodeVisitor::visitAll(KisNode*, bool) (this=0x7fffc1e0, node=0x727bfb50, breakOnFail=false) at /home/tymon/devsec/krita/libs/global/kis_shared_ptr.h:179 #6 0x7fffcc5e3a7d in KisKraLoader::loadBinaryData(KoStore*, KisSharedPtr, QString const&, bool) (this=0x5b44a3c0, store=0x5708ee60, image=..., uri=..., external=) at /home/tymon/devsec/krita/libs/global/kis_shared_ptr.h:179 #7 0x7fffcc62ffd0 in KraConverter::completeLoading(KoStore*) (this=0x7fffc6f0, store=0x5708ee60) at /usr/include/c++/8/bits/atomic_base.h:295 #8 0x7fffcc631282 in KraConverter::buildImage(QIODevice*) (this=0x7fffc6f0, io=) at /home/tymon/devsec/krita/plugins/impex/kra/kra_converter.cpp:96 #9 0x7fffcc62babc in KraImport::convert(KisDocument*, QIODevice*, KisPinnedSharedPtr) (this=, document=0x7280ced0, io=0x7fffc7a0) at /home/tymon/devsec/krita/plugins/impex/kra/kra_import.cpp:43 #10 0x7702863a in KisImportExportManager::doImport(QString const&, QSharedPointer) (this=0x72c256e0, location=..., filter=...) at /home/tymon/devsec/krita/libs/global/kis_shared_ptr.h:75 #11 0x77029d43 in KisImportExportManager::convert(KisImportExportManager::Direction, QString const&, QString const&, QString const&, bool, KisPinnedSharedPtr, bool) (this=0x72c256e0, direction=KisImportExportManager::Import, location=..., realLocation=..., mimeType=..., showWarnings=, exportConfiguration=..., isAsync=) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qsharedpointer_impl.h:330 #12 0x7702a8fd in KisImportExportManager::importDocument(QString const&, QString const&) (this=, location=..., mimeType=...) at /home/tymon/devsec/krita/libs/global/kis_shared_ptr.h:218 #13 0x77019be0 in KisDocument::openFile() (this=0x7280ced0) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qrefcount.h:60 #14 0x7701a45b in KisDocument::openUrlInternal(QUrl const&) (this=0x7280ced0, url=...) at /home/tymon/devsec/krita/libs/ui/KisDocument.cpp:1987 #15 0x7701a9c5 in KisDocument::openUrl(QUrl const&, QFlags) (this=0x7280ced0, _url=..., flags=...) at /home/tymon/devsec/krita/libs/ui/KisDocument.cpp:1418 #16 0x77032f85 in KisMainWindow::openDocumentInternal(QUrl const&, QFlags) (this=0x706d8fb0, url=..., flags=...) at /home/tymon/devsec/krita/libs/ui/KisMainWindow.cpp:997 #17 0x7703975e in KisMainWindow::openDocument(QUrl const&, QFlags) (this=0x706d8fb0, url=..., flags=...) at /home/tymon/devsec/krita/libs/ui/KisMainWindow.cpp:968 #18 0x77039c00 in KisMainWindow::slotFileOpen(bool) (this=0x706d8fb0, isImporting=false) at /home/tymon/devsec/krita/libs/ui/KisMainWindow.cpp:1573 #19 0x748486db in QMetaObject::activate(QObject*, int, int, void**) () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #20 0x752c47a2 in QAbstractButton::clicked(bool) () at /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #21 0x752c49ba in () at /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #22 0x752c5d7f in () at /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #23 0x752c5f55 in QAbstractButton::mouseReleaseEvent(QMouseEvent*) () at /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #24 0x7521c7d8 in QWidget::event(QEvent*) () at /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #25 0x751de4a1 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #26 0x751e5d28 in QApplication::notify(QObject*, QEvent*) () at /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #27 0x770054e7 in KisApplication::notify(QObject*, QEvent*) (this=, receiver=0x706f1580, event=0x7fffd5c0) at /home/tymon/devsec/krita/libs/ui/KisApplication.cpp:653 #28 0x7481f499 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #29 0x751e5029 in QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer&, bool) () at /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #30 0x75237304 in () at /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #31
[krita] [Bug 414699] Cloned layers create corrupted files after moving to a new document
https://bugs.kde.org/show_bug.cgi?id=414699 Yaroslav changed: What|Removed |Added Summary|Cloned layers corrupted |Cloned layers create |files after moving to a new |corrupted files after |document|moving to a new document -- You are receiving this mail because: You are watching all bug changes.
