[krita] [Bug 416019] Edit Shapes Tool misbehaves while dragging/bending certain imported paths
https://bugs.kde.org/show_bug.cgi?id=416019 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/b9f2edbcc ||205d1e2e412e547de1e169802db ||283c Status|ASSIGNED|RESOLVED --- Comment #7 from Dmitry Kazakov --- Git commit b9f2edbcc205d1e2e412e547de1e169802db283c by Dmitry Kazakov, on behalf of Sharaf Zaman. Committed on 08/04/2021 at 10:51. Pushed by dkazakov into branch 'master'. Bugfix: Edit Shapes Tool misbehave when transformations are present `KoPathSegmentChangeStrategy` passed offset to `KoPathControlPointMoveCommand` in Shape coordinates already. M +1-1libs/flake/commands/KoPathControlPointMoveCommand.cpp M +1-1libs/flake/commands/KoPathControlPointMoveCommand.h M +3-1libs/flake/tools/KoPathControlPointMoveStrategy.cpp M +1-0libs/flake/tools/KoPathControlPointMoveStrategy.h https://invent.kde.org/graphics/krita/commit/b9f2edbcc205d1e2e412e547de1e169802db283c -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 416019] Edit Shapes Tool misbehaves while dragging/bending certain imported paths
https://bugs.kde.org/show_bug.cgi?id=416019 --- Comment #6 from Sharaf --- Hello! I've fixed the bug and sent it for a review. The only thing I didn't look into is the artifacts which were caused by this bug, since I couldn't reproduce them after fixing it. So, let me know if artifacts show up again. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 416019] Edit Shapes Tool misbehaves while dragging/bending certain imported paths
https://bugs.kde.org/show_bug.cgi?id=416019 --- Comment #5 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/796 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 416019] Edit Shapes Tool misbehaves while dragging/bending certain imported paths
https://bugs.kde.org/show_bug.cgi?id=416019 Sharaf changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |sharafzaz...@gmail.com Status|CONFIRMED |ASSIGNED CC||sharafzaz...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 416019] Edit Shapes Tool misbehaves while dragging/bending certain imported paths
https://bugs.kde.org/show_bug.cgi?id=416019 Ahab Greybeard changed: What|Removed |Added CC||ahab.greybe...@hotmail.co.u ||k Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #4 from Ahab Greybeard --- I can confirm this for the Jan 08 4.3.0 prealpha appimage (git dc7d037) For a similar vector shape created in kita, when dragging an edge to curve it, the curve stays attached to the cursor. For 'reproducer' and 'reproducer2', the curve lags behind the cursor when dragging the curve. Also, when dragging the curve then releasing the cursor, artifacts are produced which are part of the vector layer and cannot be removed by any layer turn off/on. The can be 'swept away' by dragging the curve so that it writes over them or by saving the file and reopening. The curve lagging the cursor is associated with the curve moving in the opposite direction when the cursor is released. For 'reproducer', reducing the size of the viewBox values changes the scale of the shape and also the amount by which the curve lags the cursor during dragging. If the viewBox values are adjusted to make them much larger then the curve leads the cursor when dragging it and no artifacts are produced. If the viewBox values are set to viewBox="0 0 575 850" then there is no lag or lead of the curve with respect to the cursor. For reproducer2, if you manually remove the transform from the .svg file and then Import it, the shape does not have the curve lagging/leading the cursor when being dragged out and also none of the problems noted in the initial description. (It's also smaller and at the top left of the layer.) The transform in the original reproducer2 seems to be a combined translation and scale. I suspect that the viewBox size for reproducer2 was 'just right' (for whatever reason) but that the scaling components of the transform had their own effect. The relationship between viewBox values, path definition values and any transform effects seems to be a serious and delicate one. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 416019] Edit Shapes Tool misbehaves while dragging/bending certain imported paths
https://bugs.kde.org/show_bug.cgi?id=416019 --- Comment #3 from Cebtenzzre --- Created attachment 124984 --> https://bugs.kde.org/attachment.cgi?id=124984&action=edit Reproducer #2 with workaround applied Created with: $ svgcleaner --allow-bigger-file --apply-transform-to-paths=yes reproducer2.svg reproducer2_workaround.svg -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 416019] Edit Shapes Tool misbehaves while dragging/bending certain imported paths
https://bugs.kde.org/show_bug.cgi?id=416019 --- Comment #2 from Cebtenzzre --- Created attachment 124983 --> https://bugs.kde.org/attachment.cgi?id=124983&action=edit Reproducer #2 An SVG that needs a different workaround -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 416019] Edit Shapes Tool misbehaves while dragging/bending certain imported paths
https://bugs.kde.org/show_bug.cgi?id=416019 --- Comment #1 from Cebtenzzre --- With a different imported SVG that had the same problem, I was able to work around the issue by extracting the vector layer from the .kra and running the following command: $ svgcleaner --no-defaults --allow-bigger-file --paths-to-relative=yes --apply-transform-to-paths=yes original.svg cleaned.svg Then I replaced the layer in the .kra with the new SVG. This didn't work without --apply-transform-to-paths=yes so this seems to be different from (but related to) the original attached reproducer, which has no transform attributes. -- You are receiving this mail because: You are watching all bug changes.
