[krita] [Bug 419121] Crash on selecting certain color profiles

2020-04-02 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=419121

Boudewijn Rempt  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
   |krita/commit/45e9530cede94e |krita/commit/bbc6d9a7fd03b8
   |e30449be4bff474469efad2968  |0f8235c047503881c5a1a3f5b0

--- Comment #10 from Boudewijn Rempt  ---
Git commit bbc6d9a7fd03b80f8235c047503881c5a1a3f5b0 by Boudewijn Rempt.
Committed on 02/04/2020 at 13:09.
Pushed by rempt into branch 'krita/4.3'.

Do not load link profiles

Photoshop comes with at least two profiles that get installed
globally that cannot be used in Krita. AnimePalette.icc is one
of them. The type of this profile is not cmsSigNamedColorClass
which it probably should be, but cmsSigLinkClass, which I cannot
believe is correct.

A quick google shows that other applications also have trouble
with this broken profile.
(cherry picked from commit 6e12760c0a2f0c29897d797ceefe593f28c47822)

M  +2-1   
plugins/color/lcms2engine/colorprofiles/LcmsColorProfileContainer.cpp

https://invent.kde.org/kde/krita/commit/bbc6d9a7fd03b80f8235c047503881c5a1a3f5b0

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 419121] Crash on selecting certain color profiles

2020-03-24 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=419121

Boudewijn Rempt  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
   |krita/commit/6e12760c0a2f0c |krita/commit/45e9530cede94e
   |29897d797ceefe593f28c47822  |e30449be4bff474469efad2968

--- Comment #9 from Boudewijn Rempt  ---
Git commit 45e9530cede94ee30449be4bff474469efad2968 by Boudewijn Rempt.
Committed on 24/03/2020 at 11:10.
Pushed by rempt into branch 'krita/4.2'.

Do not load link profiles

Photoshop comes with at least two profiles that get installed
globally that cannot be used in Krita. AnimePalette.icc is one
of them. The type of this profile is not cmsSigNamedColorClass
which it probably should be, but cmsSigLinkClass, which I cannot
believe is correct.

A quick google shows that other applications also have trouble
with this broken profile.

M  +2-1   
plugins/color/lcms2engine/colorprofiles/LcmsColorProfileContainer.cpp

https://invent.kde.org/kde/krita/commit/45e9530cede94ee30449be4bff474469efad2968

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 419121] Crash on selecting certain color profiles

2020-03-24 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=419121

Boudewijn Rempt  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/kde/
   ||krita/commit/6e12760c0a2f0c
   ||29897d797ceefe593f28c47822
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Boudewijn Rempt  ---
Git commit 6e12760c0a2f0c29897d797ceefe593f28c47822 by Boudewijn Rempt.
Committed on 24/03/2020 at 11:07.
Pushed by rempt into branch 'master'.

Do not load link profiles

Photoshop comes with at least two profiles that get installed
globally that cannot be used in Krita. AnimePalette.icc is one
of them. The type of this profile is not cmsSigNamedColorClass
which it probably should be, but cmsSigLinkClass, which I cannot
believe is correct.

A quick google shows that other applications also have trouble
with this broken profile.

M  +2-1   
plugins/color/lcms2engine/colorprofiles/LcmsColorProfileContainer.cpp

https://invent.kde.org/kde/krita/commit/6e12760c0a2f0c29897d797ceefe593f28c47822

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 419121] Crash on selecting certain color profiles

2020-03-24 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=419121

Boudewijn Rempt  changed:

   What|Removed |Added

   Platform|Compiled Sources|MS Windows
 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED
   Assignee|krita-bugs-n...@kde.org |b...@valdyas.org

--- Comment #7 from Boudewijn Rempt  ---
okay, I've found the palette file, and I do get a crash if I select it in the
colorspace browser. From my web search, it seems that it is a malformed or
special palette, but Krita (and lcms) shouldn't crash on it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 419121] Crash on selecting certain color profiles

2020-03-24 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=419121

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||b...@valdyas.org

--- Comment #6 from Boudewijn Rempt  ---
Hm, that crash happens right inside lcms2, which is the color management
library we're using. I have to check whether I can find those icc profiles
somewhere... I don't have access to Photoshop myself.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 419121] Crash on selecting certain color profiles

2020-03-23 Thread Daniel Wein
https://bugs.kde.org/show_bug.cgi?id=419121

--- Comment #5 from Daniel Wein  ---
Created attachment 126967
  --> https://bugs.kde.org/attachment.cgi?id=126967=edit
Krita backtrace log generated after the crash

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 419121] Crash on selecting certain color profiles

2020-03-23 Thread Daniel Wein
https://bugs.kde.org/show_bug.cgi?id=419121

--- Comment #4 from Daniel Wein  ---
This makes sense; the laptop came pre-installed with Adobe CS6. I hadn't known
that color profiles were system-wide. You learn something new everyday, I
guess.
I've generated a backtrace using the Krita debug build. I'll attach it shortly
after sending this comment.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 419121] Crash on selecting certain color profiles

2020-03-23 Thread Rebecca Breu
https://bugs.kde.org/show_bug.cgi?id=419121

--- Comment #3 from Rebecca Breu  ---
Ah, it seems that colour profiles are system-wide, the same as fonts are.
Apparently, AnimePalette is one that comes with PhotoShop.

Could you get a backtrace for your crash? See here:
https://docs.krita.org/en/reference_manual/dr_minw_debugger.html

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 419121] Crash on selecting certain color profiles

2020-03-22 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=419121

--- Comment #2 from danny.w...@yahoo.com ---
(In reply to Rebecca Breu from comment #1)
> Huh, I neither have AnimePalette nor ColorMatch RGB. Where did you get them
> from?

That's strange; I haven't installed any addons to my Krita. I'm pretty sure
I've got release, but I checked again after a complete reinstall (deleted all
data folders, temp files, etc.)

I still have AnimePalette, but I did notice something of great note for this
bug; selecting AnimePalette from the dropdown before using the Color Space
Browser did NOT crash Krita, but Krita DID crash when I then pressed the Color
Space Browser button.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 419121] Crash on selecting certain color profiles

2020-03-22 Thread Rebecca Breu
https://bugs.kde.org/show_bug.cgi?id=419121

Rebecca Breu  changed:

   What|Removed |Added

 CC||rebe...@rbreu.de

--- Comment #1 from Rebecca Breu  ---
Huh, I neither have AnimePalette nor ColorMatch RGB. Where did you get them
from?

-- 
You are receiving this mail because:
You are watching all bug changes.