[krita] [Bug 421295] Krita zooms to the max and rotates wildly when using touch gestures with a Wacom Intuos Pro M on Linux
https://bugs.kde.org/show_bug.cgi?id=421295 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/42219dfd7 |hics/krita/commit/e4ac1fd2c |dcf486a05910b58edcc479940e8 |bc38d28fc3d393ea4efcbaa3819 |e872|20b4 --- Comment #7 from Dmitry Kazakov --- Git commit e4ac1fd2cbc38d28fc3d393ea4efcbaa381920b4 by Dmitry Kazakov, on behalf of P. Varet. Committed on 18/05/2020 at 20:16. Pushed by dkazakov into branch 'master'. Fixed canvas "jump" on finger touches. Further touch handling fixes! In https://invent.kde.org/graphics/krita/-/merge_requests/333#note_47474 @dkazakov observed that the canvas "jumps" randomly when the user's fingers leave or touch the canvas. This is due to the QTouchEvent with unreliable touch positions also firing in the form of a QGestureEvent with equally dubious positions, and that event bubbling up all the way to the parent QAbstractScrollArea. So we just prevent QGestureEvent events from bubbling up to the parent QAbstractScrollArea, and call it a day. M +11 -0libs/flake/KoCanvasControllerWidget.cpp M +2-0libs/flake/KoCanvasControllerWidget.h https://invent.kde.org/graphics/krita/commit/e4ac1fd2cbc38d28fc3d393ea4efcbaa381920b4 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 421295] Krita zooms to the max and rotates wildly when using touch gestures with a Wacom Intuos Pro M on Linux
https://bugs.kde.org/show_bug.cgi?id=421295 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/grap |krita/commit/a855e03a2de219 |hics/krita/commit/42219dfd7 |0cce98b171730f64245dee2a8c |dcf486a05910b58edcc479940e8 ||e872 --- Comment #6 from Dmitry Kazakov --- Git commit 42219dfd7dcf486a05910b58edcc479940e8e872 by Dmitry Kazakov, on behalf of P. Varet. Committed on 18/05/2020 at 20:06. Pushed by dkazakov into branch 'krita/4.3'. Fixed canvas "jump" on finger touches. Further touch handling fixes! In https://invent.kde.org/graphics/krita/-/merge_requests/333#note_47474 @dkazakov observed that the canvas "jumps" randomly when the user's fingers leave or touch the canvas. This is due to the QTouchEvent with unreliable touch positions also firing in the form of a QGestureEvent with equally dubious positions, and that event bubbling up all the way to the parent QAbstractScrollArea. So we just prevent QGestureEvent events from bubbling up to the parent QAbstractScrollArea, and call it a day. M +11 -0libs/flake/KoCanvasControllerWidget.cpp M +2-0libs/flake/KoCanvasControllerWidget.h https://invent.kde.org/graphics/krita/commit/42219dfd7dcf486a05910b58edcc479940e8e872 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 421295] Krita zooms to the max and rotates wildly when using touch gestures with a Wacom Intuos Pro M on Linux
https://bugs.kde.org/show_bug.cgi?id=421295 Boudewijn Rempt changed: What|Removed |Added Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/ |krita/commit/fb114d7686ee81 |krita/commit/a855e03a2de219 |f7e3a6999287534e1e769102ae |0cce98b171730f64245dee2a8c --- Comment #5 from Boudewijn Rempt --- Git commit a855e03a2de2190cce98b171730f64245dee2a8c by Boudewijn Rempt, on behalf of P. Varet. Committed on 16/05/2020 at 09:08. Pushed by rempt into branch 'krita/4.3'. Fix touch-based rotation and zoom on Wacom tablets. Turns out the TouchPoints in a QTouchEvent are not always trustworthy, and we need to filter out situations where we can tell they are not reporting the correct coordinates. (cherry picked from commit 2302229958c0b629def1bb37b3b15a09c4568962) M +2-1libs/ui/canvas/kis_tool_proxy.cpp M +36 -7libs/ui/input/kis_rotate_canvas_action.cpp M +62 -22 libs/ui/input/kis_zoom_action.cpp https://invent.kde.org/kde/krita/commit/a855e03a2de2190cce98b171730f64245dee2a8c -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 421295] Krita zooms to the max and rotates wildly when using touch gestures with a Wacom Intuos Pro M on Linux
https://bugs.kde.org/show_bug.cgi?id=421295 Boudewijn Rempt changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/kde/ ||krita/commit/fb114d7686ee81 ||f7e3a6999287534e1e769102ae Status|REPORTED|RESOLVED --- Comment #4 from Boudewijn Rempt --- Git commit fb114d7686ee81f7e3a6999287534e1e769102ae by Boudewijn Rempt, on behalf of P. Varet. Committed on 16/05/2020 at 09:08. Pushed by rempt into branch 'master'. Fix touch-based rotation and zoom on Wacom tablets. Turns out the TouchPoints in a QTouchEvent are not always trustworthy, and we need to filter out situations where we can tell they are not reporting the correct coordinates. M +2-1libs/ui/canvas/kis_tool_proxy.cpp M +36 -7libs/ui/input/kis_rotate_canvas_action.cpp M +62 -22 libs/ui/input/kis_zoom_action.cpp https://invent.kde.org/kde/krita/commit/fb114d7686ee81f7e3a6999287534e1e769102ae -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 421295] Krita zooms to the max and rotates wildly when using touch gestures with a Wacom Intuos Pro M on Linux
https://bugs.kde.org/show_bug.cgi?id=421295 Boudewijn Rempt changed: What|Removed |Added CC||b...@valdyas.org --- Comment #3 from Boudewijn Rempt --- Thanks! We're now checking whether it breaks stuff on Android... And I'll build the patch to check with my Intuos. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 421295] Krita zooms to the max and rotates wildly when using touch gestures with a Wacom Intuos Pro M on Linux
https://bugs.kde.org/show_bug.cgi?id=421295 --- Comment #2 from P. Varet --- Pull request sent. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 421295] Krita zooms to the max and rotates wildly when using touch gestures with a Wacom Intuos Pro M on Linux
https://bugs.kde.org/show_bug.cgi?id=421295 --- Comment #1 from P. Varet --- Created attachment 128440 --> https://bugs.kde.org/attachment.cgi?id=128440=edit Patch fixing the issue. -- You are receiving this mail because: You are watching all bug changes.
