[krita] [Bug 427137] krita crashes unexpectedly on closing normally

2021-04-22 Thread Tiar
https://bugs.kde.org/show_bug.cgi?id=427137

Tiar  changed:

   What|Removed |Added

 CC||tamtamy.tym...@gmail.com

--- Comment #2 from Tiar  ---
Can you please check if e7bd37c699944a fixes the crash on startup for you? I
have the same Qt version and I was getting the same backtrace, so I hope it did
fix/prevent it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 427137] krita crashes unexpectedly on closing normally

2021-04-22 Thread Tiar
https://bugs.kde.org/show_bug.cgi?id=427137

Tiar  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/e7bd37c69
   ||9944a78cde620b52118d254a254
   ||b708

--- Comment #1 from Tiar  ---
Git commit e7bd37c699944a78cde620b52118d254a254b708 by Agata Cacko.
Committed on 22/04/2021 at 14:13.
Pushed by tymond into branch 'master'.

Fix crash on exit by setting styleSheet only on QTabBar

Before this commit, Krita would crash on exit on Qt 5.12.8
with segfault in the destructor for the Python plugin
widgets. It turned out that this crash was introduced in
8a7bae681a1f992, and the reason turned out to be
a method setStyleSheet() with non-empty string.
Setting empty stylesheet later (on closing) didn't make a difference.
However setting the stylesheet on just the widget
that needs it (QTabBar that keeps the document tabs)
fixes/prevents the crash.

Alternative fix would be to find the widget for the Python plugin
and explicitely set empty stylesheet after every non-empty
stylesheet set for the whole application. It wasn't tested,
but in case more widgets need non-empty stylesheet, it sounds
like it should work.
Related: bug 420612

M  +10   -6libs/ui/KisMainWindow.cpp

https://invent.kde.org/graphics/krita/commit/e7bd37c699944a78cde620b52118d254a254b708

-- 
You are receiving this mail because:
You are watching all bug changes.