[krita] [Bug 428014] Random crashes when changing screentone fill layer parameters
https://bugs.kde.org/show_bug.cgi?id=428014 --- Comment #16 from Dmitry Kazakov --- Git commit 7516fe61f6b22ca79215d4aac39ab9a7288730fe by Dmitry Kazakov. Committed on 25/02/2022 at 07:21. Pushed by dkazakov into branch 'master'. Fix thread-safety issues in KoProgressUpdater M +0-1libs/image/kis_processing_visitor.cpp M +0-1libs/image/kis_processing_visitor.h M +100 -89 libs/widgetutils/KoProgressUpdater.cpp M +3-0libs/widgetutils/KoProgressUpdater.h M +3-0libs/widgetutils/tests/TestKoProgressUpdater.cpp https://invent.kde.org/graphics/krita/commit/7516fe61f6b22ca79215d4aac39ab9a7288730fe -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 428014] Random crashes when changing screentone fill layer parameters
https://bugs.kde.org/show_bug.cgi?id=428014 Dmitry Kazakov changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/7f68229d3 |hics/krita/commit/f5c9ae341 |bb8580930199a43c7c68921c3f7 |8b8bd81882213a482c452824d68 |04b7|436b Resolution|--- |FIXED --- Comment #15 from Dmitry Kazakov --- Git commit f5c9ae3418b8bd81882213a482c452824d68436b by Dmitry Kazakov. Committed on 25/02/2022 at 07:21. Pushed by dkazakov into branch 'master'. Possible fix for the Generator Dialog update crash The dialog should also care about the thread safety and use the cookie returned by the updating threads. M +3-2libs/image/generator/kis_generator_layer.cpp M +1-1libs/image/generator/kis_generator_layer.h M +4-4libs/image/generator/kis_generator_stroke_strategy.cpp M +6-2libs/ui/dialogs/kis_dlg_generator_layer.cpp M +1-0libs/ui/dialogs/kis_dlg_generator_layer.h https://invent.kde.org/graphics/krita/commit/f5c9ae3418b8bd81882213a482c452824d68436b -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 428014] Random crashes when changing screentone fill layer parameters
https://bugs.kde.org/show_bug.cgi?id=428014 --- Comment #14 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1339 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 428014] Random crashes when changing screentone fill layer parameters
https://bugs.kde.org/show_bug.cgi?id=428014 --- Comment #13 from Dmitry Kazakov --- Created attachment 146902 --> https://bugs.kde.org/attachment.cgi?id=146902=edit Proposed patch that fixes the issue Hi, Deif Lou! The problem is a regression from stroke-based updates for the generator dialog. Could you please test if this patch fixes the issue? To make the crash easier to reproduce, please set UPDATE_DELAY in KisDlgGeneratorLayer to 10ms and create "quite big" image, like 7k pixels in size. Without the patch I could reproduce the issue even in a standard build on Windows with GCC. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 428014] Random crashes when changing screentone fill layer parameters
https://bugs.kde.org/show_bug.cgi?id=428014 --- Comment #12 from Dmitry Kazakov --- Hi, Deif Lou! What happens in this crash is the following: 1) The GUI thread calls KisGeneratorLayer::requestUpdateJobsWithStroke(), which calls resetCacheWithoutUpdate(), which, in turn, calls m_d->paintDevice->clear(). 2) At the same time, there is a generator stroke running in the background and writes the result of the filter to the same device. It results in two simultaneous write accesses to the paint device, which is not allowed by the data manager. As far as I remember, this situation should have been guarded by `m_d->updateCookie`, I'm not sure why it doesn't work here. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 428014] Random crashes when changing screentone fill layer parameters
https://bugs.kde.org/show_bug.cgi?id=428014
--- Comment #11 from amyspark ---
> it = {m_policy = {m_iter = {d = 0x7fff3c095b70}, m_rawData =
> 0x7fff46ffc450 "\b", m_oldRawData = 0x7fff46ffc450 "\b"}, m_progressPolicy =
> {}, m_pixelSize = 32767, m_rowsLeft = 1008384168,
> m_numConseqPixels = 32767, m_columnsLeft = -1669517436, m_columnOffset =
> 32767, m_iteratorX = 1191167056, m_iteratorY = 32767, m_isStarted = 146}
> #8 0x772c0673 in KisDataManager::clear(int, int, int, int, unsigned
> char const*) (this=0x573a2150, x=2048, y=0, w=-208024286, h=0,
> def=0x7fff46ffc408 "\377\377\377\377\376\352\070'") at
> /home/deiflou/Development/src/apps/krita/deiflou/sliderspinbox_nojump/libs/image/kis_datamanager.h:188
Not sure what's going on, but that sounds like a out-of-bounds access caused by
some overflow there...
--
You are receiving this mail because:
You are watching all bug changes.
[krita] [Bug 428014] Random crashes when changing screentone fill layer parameters
https://bugs.kde.org/show_bug.cgi?id=428014 --- Comment #10 from Deif Lou --- Created attachment 146435 --> https://bugs.kde.org/attachment.cgi?id=146435=edit backtrace linux I was able to reproduce the crash on linux. It happened after building with clang ( I don't know if that's relevant). -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 428014] Random crashes when changing screentone fill layer parameters
https://bugs.kde.org/show_bug.cgi?id=428014 --- Comment #9 from Deif Lou --- Created attachment 145684 --> https://bugs.kde.org/attachment.cgi?id=145684=edit android crash dump This is what I get with a custom build (RelWithDebInfo), and using adb logcat and ndk-stack. I have to say that with my custom builds I have a harder time to reproduce the crash than using the appstore version, specially with the Debug build. It's very random, with 5.0.2 from appstore I also have a harder time crashing it than I had with 5.0, but easier than with the custom builds. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 428014] Random crashes when changing screentone fill layer parameters
https://bugs.kde.org/show_bug.cgi?id=428014 amyspark changed: What|Removed |Added CC||sh...@sdf.org -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 428014] Random crashes when changing screentone fill layer parameters
https://bugs.kde.org/show_bug.cgi?id=428014 amyspark changed: What|Removed |Added OS|Linux |Unspecified Version|unspecified |5.0.0 Platform|Appimage|Android CC||a...@amyspark.me -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 428014] Random crashes when changing screentone fill layer parameters
https://bugs.kde.org/show_bug.cgi?id=428014 amyspark changed: What|Removed |Added Assignee|a...@amyspark.me |dimul...@gmail.com Status|REOPENED|ASSIGNED --- Comment #8 from amyspark --- Turning over to Dmitry, this looks like an issue with the canvas lockless storage. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 428014] Random crashes when changing screentone fill layer parameters
https://bugs.kde.org/show_bug.cgi?id=428014 Deif Lou changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #7 from Deif Lou --- After trying Krita on android 5.0 this crash still happens. I attached a log. Can this be related to the screentone generator not using signal compressor? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 428014] Random crashes when changing screentone fill layer parameters
https://bugs.kde.org/show_bug.cgi?id=428014 --- Comment #6 from Deif Lou --- Created attachment 144924 --> https://bugs.kde.org/attachment.cgi?id=144924=edit krita 5 android log -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 428014] Random crashes when changing screentone fill layer parameters
https://bugs.kde.org/show_bug.cgi?id=428014 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/195b02123 |hics/krita/commit/7f68229d3 |a33ada9c8cd914144116671bd5e |bb8580930199a43c7c68921c3f7 |a978|04b7 --- Comment #5 from Dmitry Kazakov --- Git commit 7f68229d3bb8580930199a43c7c68921c3f704b7 by Dmitry Kazakov, on behalf of L. E. Segovia. Committed on 29/10/2020 at 12:32. Pushed by dkazakov into branch 'master'. Correctly add barrier jobs for KisGeneratorStrokeStrategy The correct type of job to block Fill Layer updates is BARRIER -- update jobs cannot start unless we are sure the previous set has been cleared and committed to the canvas. Related: bug 427199 M +4-7libs/image/generator/kis_generator_stroke_strategy.cpp https://invent.kde.org/graphics/krita/commit/7f68229d3bb8580930199a43c7c68921c3f704b7 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 428014] Random crashes when changing screentone fill layer parameters
https://bugs.kde.org/show_bug.cgi?id=428014 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/195b02123 ||a33ada9c8cd914144116671bd5e ||a978 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #4 from Dmitry Kazakov --- Git commit 195b02123a33ada9c8cd914144116671bd5ea978 by Dmitry Kazakov, on behalf of L. E. Segovia. Committed on 29/10/2020 at 12:29. Pushed by dkazakov into branch 'krita/4.3'. Correctly add barrier jobs for KisGeneratorStrokeStrategy The correct type of job to block Fill Layer updates is BARRIER -- update jobs cannot start unless we are sure the previous set has been cleared and committed to the canvas. Related: bug 427199 M +4-7libs/image/generator/kis_generator_stroke_strategy.cpp https://invent.kde.org/graphics/krita/commit/195b02123a33ada9c8cd914144116671bd5ea978 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 428014] Random crashes when changing screentone fill layer parameters
https://bugs.kde.org/show_bug.cgi?id=428014 --- Comment #3 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/553 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 428014] Random crashes when changing screentone fill layer parameters
https://bugs.kde.org/show_bug.cgi?id=428014 --- Comment #2 from Deif Lou --- I've also noticed that when changing rapidly the sliders of a generator, the fill layer is updated several times with the intermediate values emited by the slider instead of discarding them, keeping just the last one and updating the layer only once. This is visible with medium size images (A4-300dpi) using the pattern and multigrid generators, but it seems to happen also with the screentone generator and simplex noise, although the image has to be larger to be noticeable (I think in the case of the simplex noise because it uses a signal compressor and in the case of screentone because it generates the image fast). -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 428014] Random crashes when changing screentone fill layer parameters
https://bugs.kde.org/show_bug.cgi?id=428014 Boudewijn Rempt changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|ASSIGNED Assignee|krita-bugs-n...@kde.org |a...@amyspark.me Severity|normal |crash --- Comment #1 from Boudewijn Rempt --- Looking at the assert, this might have something to do with the multithreading of fill layers. Amyspark, can you take a look? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 428014] Random crashes when changing screentone fill layer parameters
https://bugs.kde.org/show_bug.cgi?id=428014 Boudewijn Rempt changed: What|Removed |Added Platform|Other |Appimage CC||b...@valdyas.org -- You are receiving this mail because: You are watching all bug changes.
