[krita] [Bug 429262] Import Python Plugins doesn't import all action files
https://bugs.kde.org/show_bug.cgi?id=429262 Boudewijn Rempt changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/43d283bad |hics/krita/commit/dae45839b |df63f5dd0fda99e911aeb4f425f |43d874a9fc31c231ff8a6865a3e |b5b4|6b79 --- Comment #6 from Boudewijn Rempt --- Git commit dae45839b43d874a9fc31c231ff8a6865a3e6b79 by Boudewijn Rempt, on behalf of Rebecca Breu. Committed on 20/11/2020 at 08:28. Pushed by rempt into branch 'krita/4.3'. Make Plugin Importer more flexible regarding actions Don't make assumptions about the contents of action files — just import. (cherry picked from commit 43d283baddf63f5dd0fda99e911aeb4f425fb5b4) M +2-2dev-tools/python/dev-requirements.txt M +3-11 plugins/python/plugin_importer/plugin_importer.py D +0-1 plugins/python/plugin_importer/tests/fixtures/fail_unparsable_action_file/plugin/foo.action A +19 -0 plugins/python/plugin_importer/tests/fixtures/success_different_action_name/plugin/foo.action R +0-0 plugins/python/plugin_importer/tests/fixtures/success_different_action_name/plugin/foo.desktop [from: plugins/python/plugin_importer/tests/fixtures/fail_unparsable_action_file/plugin/foo.desktop - 100% similarity] R +0-0 plugins/python/plugin_importer/tests/fixtures/success_different_action_name/plugin/foo/__init__.py [from: plugins/python/plugin_importer/tests/fixtures/fail_unparsable_action_file/plugin/foo/__init__.py - 100% similarity] R +0-0 plugins/python/plugin_importer/tests/fixtures/success_different_action_name/plugin/foo/foo.py [from: plugins/python/plugin_importer/tests/fixtures/fail_unparsable_action_file/plugin/foo/foo.py - 100% similarity] M +19 -13 plugins/python/plugin_importer/tests/test_plugin_importer.py https://invent.kde.org/graphics/krita/commit/dae45839b43d874a9fc31c231ff8a6865a3e6b79 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 429262] Import Python Plugins doesn't import all action files
https://bugs.kde.org/show_bug.cgi?id=429262 Boudewijn Rempt changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/43d283bad ||df63f5dd0fda99e911aeb4f425f ||b5b4 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #5 from Boudewijn Rempt --- Git commit 43d283baddf63f5dd0fda99e911aeb4f425fb5b4 by Boudewijn Rempt, on behalf of Rebecca Breu. Committed on 20/11/2020 at 08:28. Pushed by rempt into branch 'master'. Make Plugin Importer more flexible regarding actions Don't make assumptions about the contents of action files — just import. M +2-2dev-tools/python/dev-requirements.txt M +3-11 plugins/python/plugin_importer/plugin_importer.py D +0-1 plugins/python/plugin_importer/tests/fixtures/fail_unparsable_action_file/plugin/foo.action A +19 -0 plugins/python/plugin_importer/tests/fixtures/success_different_action_name/plugin/foo.action R +0-0 plugins/python/plugin_importer/tests/fixtures/success_different_action_name/plugin/foo.desktop [from: plugins/python/plugin_importer/tests/fixtures/fail_unparsable_action_file/plugin/foo.desktop - 100% similarity] R +0-0 plugins/python/plugin_importer/tests/fixtures/success_different_action_name/plugin/foo/__init__.py [from: plugins/python/plugin_importer/tests/fixtures/fail_unparsable_action_file/plugin/foo/__init__.py - 100% similarity] R +0-0 plugins/python/plugin_importer/tests/fixtures/success_different_action_name/plugin/foo/foo.py [from: plugins/python/plugin_importer/tests/fixtures/fail_unparsable_action_file/plugin/foo/foo.py - 100% similarity] M +19 -13 plugins/python/plugin_importer/tests/test_plugin_importer.py https://invent.kde.org/graphics/krita/commit/43d283baddf63f5dd0fda99e911aeb4f425fb5b4 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 429262] Import Python Plugins doesn't import all action files
https://bugs.kde.org/show_bug.cgi?id=429262 --- Comment #4 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/596 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 429262] Import Python Plugins doesn't import all action files
https://bugs.kde.org/show_bug.cgi?id=429262 Tymond changed: What|Removed |Added Version|unspecified |4.4.1 Platform|Other |Mint (Ubuntu based) --- Comment #3 from Tymond --- The problem is in function "get_source_actionfile" in line 141 in plugins/python/plugin_importer/plugin_importer.py . A bug/wish about the same plugin, might be easy to fix both at the same time: bug 429265 . Thanks for checking this out, I think fixing it will improve the custom Python plugins workflow a lot :) Much less scary for users than manual importing. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 429262] Import Python Plugins doesn't import all action files
https://bugs.kde.org/show_bug.cgi?id=429262 --- Comment #2 from Rebecca Breu --- Sure! -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 429262] Import Python Plugins doesn't import all action files
https://bugs.kde.org/show_bug.cgi?id=429262 Boudewijn Rempt changed: What|Removed |Added Status|REPORTED|ASSIGNED Assignee|krita-bugs-n...@kde.org |rebe...@rbreu.de Ever confirmed|0 |1 CC||b...@valdyas.org --- Comment #1 from Boudewijn Rempt --- Rebecca, Could you please take a look? Thanks! -- You are receiving this mail because: You are watching all bug changes.
