[krita] [Bug 434646] Krita crashes on macos randomly
https://bugs.kde.org/show_bug.cgi?id=434646 vanyossi changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/88106a143 |hics/krita/commit/1c4172249 |b3d0349e272e258f2936a3ac090 |a831fb3895d8852f8a3389a40f1 |78b6|43c1 --- Comment #10 from vanyossi --- Git commit 1c4172249a831fb3895d8852f8a3389a40f143c1 by Ivan Yossi. Committed on 17/05/2021 at 07:15. Pushed by ivany into branch 'krita/4.3'. Fix random crashes on macOS Also it should fix cursor getting stuck after switching to other apps using cmd+tab and returning to krita using mouse click. M +2-8libs/ui/input/kis_extended_modifiers_mapper.cpp M +0-1libs/ui/input/kis_extended_modifiers_mapper.h M +1-7libs/ui/input/kis_extended_modifiers_mapper_osx.h M +5-30 libs/ui/input/kis_extended_modifiers_mapper_osx.mm M +0-2libs/ui/input/kis_input_manager.cpp https://invent.kde.org/graphics/krita/commit/1c4172249a831fb3895d8852f8a3389a40f143c1 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434646] Krita crashes on macos randomly
https://bugs.kde.org/show_bug.cgi?id=434646 vanyossi changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/88106a143 ||b3d0349e272e258f2936a3ac090 ||78b6 Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #9 from vanyossi --- Git commit 88106a143b3d0349e272e258f2936a3ac09078b6 by Ivan Yossi. Committed on 23/04/2021 at 14:52. Pushed by ivany into branch 'master'. Fix random crashes on macOS Also it should fix cursor getting stuck after switching to other apps using cmd+tab and returning to krita using mouse click. M +2-8libs/ui/input/kis_extended_modifiers_mapper.cpp M +0-1libs/ui/input/kis_extended_modifiers_mapper.h M +1-7libs/ui/input/kis_extended_modifiers_mapper_osx.h M +5-30 libs/ui/input/kis_extended_modifiers_mapper_osx.mm M +0-2libs/ui/input/kis_input_manager.cpp https://invent.kde.org/graphics/krita/commit/88106a143b3d0349e272e258f2936a3ac09078b6 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434646] Krita crashes on macos randomly
https://bugs.kde.org/show_bug.cgi?id=434646 vanyossi changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #8 from vanyossi --- found the reason to this bug: We started listening to shortcuts outside of krita's focus, however if the user presses a key combination that happens to be a shortcut outside the action will be triggered even with krita out of focus or with focus but no active document whic means KisToolProxy::private is null causing the crash. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434646] Krita crashes on macos randomly
https://bugs.kde.org/show_bug.cgi?id=434646 vanyossi changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #7 from vanyossi --- Closing as the random bug during my painting sessions is always KoToolproxy. pushed a quick fix for it. https://invent.kde.org/graphics/krita/-/commit/e97414d541bd9de8e080cf4cee0ce3d2c9ab1973 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434646] Krita crashes on macos randomly
https://bugs.kde.org/show_bug.cgi?id=434646 --- Comment #6 from vanyossi --- i have been using krita with a small patch to kis_tool_proxy.cpp:220:83 it checks the pointer to be valid before calling KisToolProxy. So far no crashes -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434646] Krita crashes on macos randomly
https://bugs.kde.org/show_bug.cgi?id=434646 Halla Rempt changed: What|Removed |Added CC|justin.zo...@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434646] Krita crashes on macos randomly
https://bugs.kde.org/show_bug.cgi?id=434646 --- Comment #5 from Halla Rempt --- Don't be so passive-agressive Justin. We've discussed this before and I have explained to you why mass-changing bug statuses, assignees or adding "please test this again" messages is not useful at all. I know you mean well, but you are not helping: you are making work for us. Three people have spent time on this: Ivan to fix the status, Tiar to explain to Ivan who this Justin is that made work for him, and me to explain to you once again that you're doing the wrong thing. Get to know a project, read the bug reports, understand them, get to know the people in a project and only then you can really help out. Honestly, it's completely beyond me why you even thought you needed to remove the assignee here. It's a bug that was filed yesterday, by the person who is investigating the issue... (Quite apart from the fact that you set the assignee to null without changing the ASSIGNED status, which is wrong.) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434646] Krita crashes on macos randomly
https://bugs.kde.org/show_bug.cgi?id=434646 Justin Zobel changed: What|Removed |Added CC||justin.zo...@gmail.com --- Comment #4 from Justin Zobel --- (In reply to Halla Rempt from comment #3) > I have asked Justin Zobel once again to stop messing with Krita's bugs. My apologies for trying to help with bug triaging. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434646] Krita crashes on macos randomly
https://bugs.kde.org/show_bug.cgi?id=434646 Halla Rempt changed: What|Removed |Added CC|justin.zo...@gmail.com | --- Comment #3 from Halla Rempt --- I have asked Justin Zobel once again to stop messing with Krita's bugs. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434646] Krita crashes on macos randomly
https://bugs.kde.org/show_bug.cgi?id=434646 vanyossi changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |ghe...@gmail.com Status|REPORTED|ASSIGNED Ever confirmed|0 |1 --- Comment #2 from vanyossi --- Im assigning myself again as it was removed by last editor -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434646] Krita crashes on macos randomly
https://bugs.kde.org/show_bug.cgi?id=434646 Justin Zobel changed: What|Removed |Added Severity|normal |crash Assignee|ghe...@gmail.com|krita-bugs-n...@kde.org CC||justin.zo...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434646] Krita crashes on macos randomly
https://bugs.kde.org/show_bug.cgi?id=434646 Halla Rempt changed: What|Removed |Added CC||ha...@valdyas.org --- Comment #1 from Halla Rempt --- Looks like KoToolProxy is a null pointer? libkritaui.17.0.0.dylib`KisToolProxy::activateToolAction(this=0x, action=Primary) at kis_tool_proxy.cpp:220:83 [opt] -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 434646] Krita crashes on macos randomly
https://bugs.kde.org/show_bug.cgi?id=434646 vanyossi changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |ghe...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
