[krita] [Bug 439817] Those brushes cannot be found after importing "mypaint brush bundle".
https://bugs.kde.org/show_bug.cgi?id=439817 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/cbf78192c |hics/krita/commit/ea5450925 |b7e3a4774de736cf2bd2e4dec91 |630338c79be9af21a9468f458ae |f6da|11ff --- Comment #8 from Dmitry Kazakov --- Git commit ea5450925630338c79be9af21a9468f458ae11ff by Dmitry Kazakov, on behalf of L. E. Segovia. Committed on 17/11/2021 at 13:47. Pushed by dkazakov into branch 'krita/5.0'. MyPaint: accept brushes serialized as KPP and fix their names M +34 -5plugins/paintops/mypaint/MyPaintPaintOpPreset.cpp M +5-0plugins/paintops/mypaint/MyPaintPaintOpPreset.h https://invent.kde.org/graphics/krita/commit/ea5450925630338c79be9af21a9468f458ae11ff -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 439817] Those brushes cannot be found after importing "mypaint brush bundle".
https://bugs.kde.org/show_bug.cgi?id=439817 amyspark changed: What|Removed |Added Blocks||445282 Referenced Bugs: https://bugs.kde.org/show_bug.cgi?id=445282 [Bug 445282] Overwriting a MyPaint preset creates a file with wrong extension (.myb instead of .kpp) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 439817] Those brushes cannot be found after importing "mypaint brush bundle".
https://bugs.kde.org/show_bug.cgi?id=439817 --- Comment #9 from amyspark --- Git commit 14e8cd88b267d0c083cb7bee693d02f684d022d6 by L. E. Segovia. Committed on 25/11/2021 at 13:47. Pushed by lsegovia into branch 'krita/5.0'. Fix naming of MyPaint brushes on versioned serialization Before this commit, versioned .myb files would apply the .kpp suffix, only to be overridden by the save preset dialog. Related: bug 445281, bug 445282 M +5-6libs/ui/dialogs/KisDlgSavePreset.cpp M +6-4plugins/paintops/mypaint/MyPaintPaintOpPreset.cpp M +0-7plugins/paintops/mypaint/MyPaintPaintOpPreset.h https://invent.kde.org/graphics/krita/commit/14e8cd88b267d0c083cb7bee693d02f684d022d6 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 439817] Those brushes cannot be found after importing "mypaint brush bundle".
https://bugs.kde.org/show_bug.cgi?id=439817 --- Comment #10 from amyspark --- Git commit a4f84ca9a3070ff4fe5949da3e8028fe131f3b26 by L. E. Segovia. Committed on 25/11/2021 at 13:50. Pushed by lsegovia into branch 'master'. Fix naming of MyPaint brushes on versioned serialization Before this commit, versioned .myb files would apply the .kpp suffix, only to be overridden by the save preset dialog. Related: bug 445281, bug 445282 (cherry picked from commit 14e8cd88b267d0c083cb7bee693d02f684d022d6) M +5-6libs/ui/dialogs/KisDlgSavePreset.cpp M +6-4plugins/paintops/mypaint/MyPaintPaintOpPreset.cpp M +0-7plugins/paintops/mypaint/MyPaintPaintOpPreset.h https://invent.kde.org/graphics/krita/commit/a4f84ca9a3070ff4fe5949da3e8028fe131f3b26 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 439817] Those brushes cannot be found after importing "mypaint brush bundle".
https://bugs.kde.org/show_bug.cgi?id=439817 amyspark changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REPORTED|NEEDSINFO CC||a...@amyspark.me --- Comment #1 from amyspark --- I cannot reproduce on commit 804225bc51. Can you check if your user folder has a copy of these old brushes? if so, can you try removing them, regenerate the database and check if the brush pack appears? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 439817] Those brushes cannot be found after importing "mypaint brush bundle".
https://bugs.kde.org/show_bug.cgi?id=439817 amyspark changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Ever confirmed|0 |1 Status|NEEDSINFO |CONFIRMED --- Comment #2 from amyspark --- (Apologies for the previous comment, I copy/pasted it from another bug report.) Confirming on commit 804225bc51. Bundle manifest shows that MyPaint brushes that are exported are listed as ".kpp", but the actual file has ".myb". On load, this appears in the log: Bundle "C:/Users/Amalia/AppData/Roaming/krita/Test_Mypaint.bundle" is broken. File "paintoppresets/c)_Pencil_1_Sketch_(mypaint amyspark).kpp" is missing Bundle "C:/Users/Amalia/AppData/Roaming/krita/Test_Mypaint.bundle" is broken. File "paintoppresets/c)_Pencil_2b_(mypaint amyspark).kpp" is missing -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 439817] Those brushes cannot be found after importing "mypaint brush bundle".
https://bugs.kde.org/show_bug.cgi?id=439817 Tiar changed: What|Removed |Added CC||tamtamy.tym...@gmail.com --- Comment #3 from Tiar --- Kind of funny since I just reported this bug: bug 443907, which talks about bundle manifest having wrong filenames. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 439817] Those brushes cannot be found after importing "mypaint brush bundle".
https://bugs.kde.org/show_bug.cgi?id=439817 amyspark changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |a...@amyspark.me Status|CONFIRMED |ASSIGNED --- Comment #4 from amyspark --- They do have the correct filenames *grins* but MyPaint brushes serialization is completely broken. The original author assumed they'd be read as JSON; but on saving to disk, the save format is KoResource's PNG serialization, which is in turn ignored by the loadFromDevice impl. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 439817] Those brushes cannot be found after importing "mypaint brush bundle".
https://bugs.kde.org/show_bug.cgi?id=439817 --- Comment #5 from amyspark --- If I may amend the above, MyPaint brushes loaded from .myb will preserve their extensions on save, which is wrong because of the change in serialization format. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 439817] Those brushes cannot be found after importing "mypaint brush bundle".
https://bugs.kde.org/show_bug.cgi?id=439817 --- Comment #6 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1102 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 439817] Those brushes cannot be found after importing "mypaint brush bundle".
https://bugs.kde.org/show_bug.cgi?id=439817 Halla Rempt changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/cbf78192c ||b7e3a4774de736cf2bd2e4dec91 ||f6da Resolution|--- |FIXED --- Comment #7 from Halla Rempt --- Git commit cbf78192cb7e3a4774de736cf2bd2e4dec91f6da by Halla Rempt, on behalf of L. E. Segovia. Committed on 19/10/2021 at 07:51. Pushed by rempt into branch 'master'. MyPaint: accept brushes serialized as KPP and fix their names M +34 -5plugins/paintops/mypaint/MyPaintPaintOpPreset.cpp M +5-0plugins/paintops/mypaint/MyPaintPaintOpPreset.h https://invent.kde.org/graphics/krita/commit/cbf78192cb7e3a4774de736cf2bd2e4dec91f6da -- You are receiving this mail because: You are watching all bug changes.
