[krita] [Bug 441216] Painting over a reference image shows rectangular artefacts around the cursor if fractional HiDPI scaling is enabled.
https://bugs.kde.org/show_bug.cgi?id=441216 aylamz changed: What|Removed |Added CC||ayl...@posteo.net -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441216] Painting over a reference image shows rectangular artefacts around the cursor if fractional HiDPI scaling is enabled.
https://bugs.kde.org/show_bug.cgi?id=441216 --- Comment #21 from Alvin Wong --- Git commit 3323e4e3308ce413e8439536285e42814ce628c8 by Alvin Wong. Committed on 14/09/2023 at 20:15. Pushed by alvinwong into branch 'krita/5.2'. Set updateRect to widget rect on fractional hidpi screen This fixes the warning `KoShapeManager::paint Painting with a painter that has no clipping will lead to too much being painted!`, regression from ef521dac6125ec718200ca9b689fb7ae69f51482. (cherry picked from commit d486a0605f8d120130eaeb09753829a484d9654f) M +2-0libs/ui/opengl/kis_opengl_canvas2.cpp https://invent.kde.org/graphics/krita/-/commit/3323e4e3308ce413e8439536285e42814ce628c8 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441216] Painting over a reference image shows rectangular artefacts around the cursor if fractional HiDPI scaling is enabled.
https://bugs.kde.org/show_bug.cgi?id=441216 --- Comment #20 from Alvin Wong --- Git commit d486a0605f8d120130eaeb09753829a484d9654f by Alvin Wong. Committed on 14/09/2023 at 20:15. Pushed by alvinwong into branch 'master'. Set updateRect to widget rect on fractional hidpi screen This fixes the warning `KoShapeManager::paint Painting with a painter that has no clipping will lead to too much being painted!`, regression from ef521dac6125ec718200ca9b689fb7ae69f51482. M +2-0libs/ui/opengl/kis_opengl_canvas2.cpp https://invent.kde.org/graphics/krita/-/commit/d486a0605f8d120130eaeb09753829a484d9654f -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441216] Painting over a reference image shows rectangular artefacts around the cursor if fractional HiDPI scaling is enabled.
https://bugs.kde.org/show_bug.cgi?id=441216 --- Comment #19 from Dmitry Kazakov --- The bug is currently fixed with a workaround. Now partial updates are completely disabled in fractional HiDPI mode. Ideally, we need to fix that somewhere in Qt. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441216] Painting over a reference image shows rectangular artefacts around the cursor if fractional HiDPI scaling is enabled.
https://bugs.kde.org/show_bug.cgi?id=441216 Dmitry Kazakov changed: What|Removed |Added Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441216] Painting over a reference image shows rectangular artefacts around the cursor if fractional HiDPI scaling is enabled.
https://bugs.kde.org/show_bug.cgi?id=441216 --- Comment #18 from Dmitry Kazakov --- Git commit ef521dac6125ec718200ca9b689fb7ae69f51482 by Dmitry Kazakov. Committed on 17/11/2022 at 13:33. Pushed by dkazakov into branch 'krita/5.1'. Disable partial updates for fractional HiDPI cases There is some bug either in QPainter or in our partial updates patches that cause an update issue in reference images decoration. Basically, the crop rect of the update should be aligned to the physical pixels, but it is not. M +11 -1libs/ui/opengl/kis_opengl_canvas2.cpp https://invent.kde.org/graphics/krita/commit/ef521dac6125ec718200ca9b689fb7ae69f51482 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441216] Painting over a reference image shows rectangular artefacts around the cursor if fractional HiDPI scaling is enabled.
https://bugs.kde.org/show_bug.cgi?id=441216 --- Comment #17 from Dmitry Kazakov --- Git commit b18557c58f86429ba728341a4401fba53d42f522 by Dmitry Kazakov. Committed on 17/11/2022 at 13:33. Pushed by dkazakov into branch 'master'. Disable partial updates for fractional HiDPI cases There is some bug either in QPainter or in our partial updates patches that cause an update issue in reference images decoration. Basically, the crop rect of the update should be aligned to the physical pixels, but it is not. M +11 -1libs/ui/opengl/kis_opengl_canvas2.cpp https://invent.kde.org/graphics/krita/commit/b18557c58f86429ba728341a4401fba53d42f522 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441216] Painting over a reference image shows rectangular artefacts around the cursor if fractional HiDPI scaling is enabled.
https://bugs.kde.org/show_bug.cgi?id=441216 Dmitry Kazakov changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #16 from Dmitry Kazakov --- The fix is reverted currently since it causes bug 460577 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441216] Painting over a reference image shows rectangular artefacts around the cursor if fractional HiDPI scaling is enabled.
https://bugs.kde.org/show_bug.cgi?id=441216 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/213f967ec |hics/krita/commit/fed8729ec |ed91bc22767d700f47d0973b4f6 |d3021fee8ebf1cd6ae9d7445396 |81fd|0935 --- Comment #15 from Dmitry Kazakov --- Git commit fed8729ecd3021fee8ebf1cd6ae9d74453960935 by Dmitry Kazakov. Committed on 20/09/2022 at 10:24. Pushed by dkazakov into branch 'krita/5.1'. Fix artifacts when hovering over reference images in HiDPI mode Thanks Freya Lupen for the provided patch! (cherry picked from commit 213f967eced91bc22767d700f47d0973b4f681fd) M +1-1libs/ui/opengl/kis_opengl_canvas2.cpp https://invent.kde.org/graphics/krita/commit/fed8729ecd3021fee8ebf1cd6ae9d74453960935 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441216] Painting over a reference image shows rectangular artefacts around the cursor if fractional HiDPI scaling is enabled.
https://bugs.kde.org/show_bug.cgi?id=441216 Dmitry Kazakov changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/213f967ec ||ed91bc22767d700f47d0973b4f6 ||81fd --- Comment #14 from Dmitry Kazakov --- Git commit 213f967eced91bc22767d700f47d0973b4f681fd by Dmitry Kazakov. Committed on 20/09/2022 at 10:23. Pushed by dkazakov into branch 'master'. Fix artifacts when hovering over reference images in HiDPI mode Thanks Freya Lupen for the provided patch! M +1-1libs/ui/opengl/kis_opengl_canvas2.cpp https://invent.kde.org/graphics/krita/commit/213f967eced91bc22767d700f47d0973b4f681fd -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441216] Painting over a reference image shows rectangular artefacts around the cursor if fractional HiDPI scaling is enabled.
https://bugs.kde.org/show_bug.cgi?id=441216 Halla Rempt changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com Status|CONFIRMED |ASSIGNED --- Comment #13 from Halla Rempt --- Dmitry said he'll check this solution. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441216] Painting over a reference image shows rectangular artefacts around the cursor if fractional HiDPI scaling is enabled.
https://bugs.kde.org/show_bug.cgi?id=441216 Freya Lupen changed: What|Removed |Added CC||penguinflyer2...@gmail.com --- Comment #12 from Freya Lupen --- Looked into this bug (can confirm in 5.1.0 beta 1 and recent master), and here's my findings: When moving a brush outline cursor over a reference image with fractional display scaling, 1-screen-pixel-wide/tall transparent lines appear at the left and bottom edges of the update rect. Changing this line in KisOpenGLCanvas2::paintGL() gc.setClipRect(updateRect); to this gc.setClipRect(updateRect.adjusted(-1, 0, 0, 1)); prevents them from appearing. I suspect it's some kind of rounding issue in Qt. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441216] Painting over a reference image shows rectangular artefacts around the cursor if fractional HiDPI scaling is enabled.
https://bugs.kde.org/show_bug.cgi?id=441216 --- Comment #11 from sven.wan...@gmail.com --- Now that I reinstalled 4.4.7 to test your recommendation I can tell you that I not only see artefacts in case of drawing on reference images, even if they are more massive, but I also see some without reference images. When moving the pencil, vertical and horizontal strokes appear and also vanishing again after a while or on rotating and zooming the canvas. The length seems to somehow correlate to the rotation of the canvas, on higher rotations just dot appear sometimes. Will go back to 4.4.3 again, if it is a bigger issue you might get more and maybe better feedback from others soon. Thank you for helping. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441216] Painting over a reference image shows rectangular artefacts around the cursor if fractional HiDPI scaling is enabled.
https://bugs.kde.org/show_bug.cgi?id=441216 --- Comment #10 from Halla Rempt --- That's strange... I just checked on my Yoga, set display scaling to 1, like you have, and I didn't get any artefacts anymore. And I set it to 1.25, and then disabled fractional scaling support, and didn't get artefacts; when I enabled it, I did. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441216] Painting over a reference image shows rectangular artefacts around the cursor if fractional HiDPI scaling is enabled.
https://bugs.kde.org/show_bug.cgi?id=441216 --- Comment #9 from sven.wan...@gmail.com --- Unfortunately this doesn't work in my case. I also tried to disable Hi-DPI support completely, no effect! -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441216] Painting over a reference image shows rectangular artefacts around the cursor if fractional HiDPI scaling is enabled.
https://bugs.kde.org/show_bug.cgi?id=441216 Halla Rempt changed: What|Removed |Added Summary|Painting over a reference |Painting over a reference |image shows rectangular |image shows rectangular |artefacts around the|artefacts around the cursor |cursor. |if fractional HiDPI scaling ||is enabled. Version|4.4.3 |4.4.7 --- Comment #8 from Halla Rempt --- If you disable fractional hidpi scaling in Krita's settings, then 4.4.7 will not show the cursor artefacts anymore. -- You are receiving this mail because: You are watching all bug changes.
