[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 --- Comment #24 from Dmitry Kazakov --- You are welcome! :) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 --- Comment #23 from Protoniv --- Hi, Dmitry! Just tested the patched build with these default brushes and it works great! Thank you very much! -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 --- Comment #22 from Dmitry Kazakov --- Hi, Protoniv! This build (when it completes) will contain the fix for the latest bug you reported: https://binary-factory.kde.org/job/Krita_Nightly_Windows_Build/1559/ Please test it when the build is ready :) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/156f614b4 |hics/krita/commit/5b6b0401d |d1f40b56dad3ff62a127483f2aa |634cb3307e10c6791d681f0cd02 |4c0c|e31a --- Comment #21 from Dmitry Kazakov --- Git commit 5b6b0401d634cb3307e10c6791d681f0cd02e31a by Dmitry Kazakov. Committed on 07/12/2021 at 09:19. Pushed by dkazakov into branch 'krita/5.0'. Fix loading texture patterns in presets with empty PatternMD5 field Some old Deevad's presets have empty PatternMD5 field set, we shouldn't skip them from loading, because they still have both, the filename and the (embedded) pattern itself. (cherry picked from commit 156f614b4d1f40b56dad3ff62a127483f2aa4c0c) M +3-1plugins/paintops/libpaintop/kis_texture_option.cpp https://invent.kde.org/graphics/krita/commit/5b6b0401d634cb3307e10c6791d681f0cd02e31a -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 Dmitry Kazakov changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/d1d9e8f54 |hics/krita/commit/156f614b4 |f874316709497e20a7f56994f20 |d1f40b56dad3ff62a127483f2aa |c9d5|4c0c --- Comment #20 from Dmitry Kazakov --- Git commit 156f614b4d1f40b56dad3ff62a127483f2aa4c0c by Dmitry Kazakov. Committed on 07/12/2021 at 09:05. Pushed by dkazakov into branch 'master'. Fix loading texture patterns in presets with empty PatternMD5 field Some old Deevad's presets have empty PatternMD5 field set, we shouldn't skip them from loading, because they still have both, the filename and the (embedded) pattern itself. M +3-1plugins/paintops/libpaintop/kis_texture_option.cpp https://invent.kde.org/graphics/krita/commit/156f614b4d1f40b56dad3ff62a127483f2aa4c0c -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 Bug Janitor Service changed: What|Removed |Added Status|REOPENED|ASSIGNED --- Comment #19 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1206 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 Protoniv changed: What|Removed |Added CC||ss93...@gmail.com Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #18 from Protoniv --- Hi, just tested 5.0.0-beta5-783e051031 on win10, and looked up the bugged brushes listed here, now their pattern can be found correctly. However some brushes still not apply their pattern until changing any setting. f) Dry Roller g) Dry Brushing g) Dry Textured Creases h) Chalk Details i) Wet Textured Soft i)Wet Paint -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/783e05103 |hics/krita/commit/d1d9e8f54 |1e4ddac279960d2332225a57ac7 |f874316709497e20a7f56994f20 |a408|c9d5 --- Comment #17 from Dmitry Kazakov --- Git commit d1d9e8f54f874316709497e20a7f56994f20c9d5 by Dmitry Kazakov. Committed on 06/12/2021 at 15:16. Pushed by dkazakov into branch 'master'. Fix embedded resources to appear in the resource model All the code that manipuilates resources in Krita is expected to do that via KisResourceModel. It guarantees that the internal model indexes are valid and up-to-date. Though we have one notable exception, that is, embedded resources. They are loaded by KisResourceLocator internally, when some uncached resource is loaded. In such a case the model should be notified to update its query. M +3-0libs/resources/KisResourceLocator.cpp M +6-0libs/resources/KisResourceLocator.h M +18 -0libs/resources/KisResourceModel.cpp M +17 -0libs/resources/KisResourceModel.h https://invent.kde.org/graphics/krita/commit/d1d9e8f54f874316709497e20a7f56994f20c9d5 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/8628fd22c |hics/krita/commit/783e05103 |755584ef3606732bf3dbe6af8e2 |1e4ddac279960d2332225a57ac7 |b904|a408 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #16 from Dmitry Kazakov --- Git commit 783e051031e4ddac279960d2332225a57ac7a408 by Dmitry Kazakov. Committed on 06/12/2021 at 13:48. Pushed by dkazakov into branch 'krita/5.0'. Fix embedded resources to appear in the resource model All the code that manipuilates resources in Krita is expected to do that via KisResourceModel. It guarantees that the internal model indexes are valid and up-to-date. Though we have one notable exception, that is, embedded resources. They are loaded by KisResourceLocator internally, when some uncached resource is loaded. In such a case the model should be notified to update its query. M +3-0libs/resources/KisResourceLocator.cpp M +6-0libs/resources/KisResourceLocator.h M +18 -0libs/resources/KisResourceModel.cpp M +17 -0libs/resources/KisResourceModel.h https://invent.kde.org/graphics/krita/commit/783e051031e4ddac279960d2332225a57ac7a408 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #15 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1202 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 --- Comment #14 from Dmitry Kazakov --- As far as I can tell the following happens: 1) The pattern itself is loaded into the brush correctly 2) But the pattern selector doesn't see this resource (probably because it is marked as temporary) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 Dmitry Kazakov changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com CC||dimul...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 wolthera changed: What|Removed |Added CC||hgmes...@gmail.com --- Comment #13 from wolthera --- *** Bug 446470 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 Halla Rempt changed: What|Removed |Added Assignee|ha...@valdyas.org |krita-bugs-n...@kde.org Status|REOPENED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 Yu-Hsuan Lai changed: What|Removed |Added CC||rainco...@gmail.com --- Comment #12 from Yu-Hsuan Lai --- Buggy for me too. 5.0.0-beta2 (git a642eb0). Video demo for the bug: https://krita-artists.org/t/color-smudge-brushs-ratio-setting-bug-with-video-evidence/32580/4 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 Tiar changed: What|Removed |Added Keywords||regression, release_blocker CC||tamtamy.tym...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 --- Comment #11 from var...@gmx.ch --- This is the same for me, many brushes are broken now. It looks like embeeded patterns in brushtips still aren't loaded correctly for the beta2? To add some other brushes that are broken and don't have a pattern now: g) Dry Textured Creases g) Dry Brushing g) Dry Roller and more... If you reselect the pattern in the Library, the pattern works. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 var...@gmx.ch changed: What|Removed |Added Version|5.0.0-beta1 |5.0.0-beta2 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 tomtomtomreportin...@gmail.com changed: What|Removed |Added CC||tomtomtomreportingin@gmail. ||com Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #10 from tomtomtomreportin...@gmail.com --- I'm sorry, but patterns are still buggy in some way with at least some included brushes and with certain bundled resources. Some of these buggy behaviors could probably pertain to at least three different currently closed bug reports, but I'm reopening just this one as it's probably the most general one. Here's the situation: 5.0 beta 2: h) Chalk Details - No pattern until changing any setting. g) Dry Brushing - No pattern until changing any setting. i) Wet Textured Soft - No pattern until changing any setting. k) Blender Textured Soft - No pattern until changing any setting, but wrongly loads 01_canvas after. y) Texture Wood Fiber - No pattern until changing any setting, but wrongly loads 01_canvas after. Moo Zip brushes (download the Moo Ink bundle from https://saeger.art/mojo-moo/bundles by clicking the orange BUNDLE button): Fine until changing settings, then wrongly loads 01_canvas after. master 45ea106: h) Chalk Details - No pattern until changing any setting, but wrongly loads 01_canvas after. g) Dry Brushing - No pattern until changing any setting, but wrongly loads 01_canvas after. i) Wet Textured Soft - No pattern until changing any setting, but wrongly loads 01_canvas after. k) Blender Textured Soft - No pattern until changing any setting, but wrongly loads 01_canvas after. y) Texture Wood Fiber - No pattern until changing any setting, but wrongly loads 01_canvas after. Moo Zip brushes: Fine until changing settings, then wrongly loads 01_canvas after. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 Halla Rempt changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/91bbbd5ff |hics/krita/commit/8628fd22c |d64c918cb882815f71c097c8c22 |755584ef3606732bf3dbe6af8e2 |0bf9|b904 --- Comment #9 from Halla Rempt --- Git commit 8628fd22c755584ef3606732bf3dbe6af8e2b904 by Halla Rempt. Committed on 07/09/2021 at 09:02. Pushed by rempt into branch 'krita/5.0'. Fix loading legacy brush masks If there are two resources in two storages that have the same md5sum (square_rough.png and texture_3.png), we need to make sure that the one with the filename stored in the preset can be found, so now resources(md5, filename, name) returns all matching resources. Related: bug 441347 (cherry picked from commit 91bbbd5ffd64c918cb882815f71c097c8c220bf9) M +17 -6libs/brush/kis_predefined_brush_factory.cpp M +25 -22 libs/image/brushengine/kis_paintop_preset.cpp M +3-0libs/image/brushengine/kis_paintop_settings.cpp M +1-1libs/image/kis_properties_configuration.cc M +3-3libs/psd/psd.h M +7-6libs/resources/KisGlobalResourcesInterface.cpp M +3-4libs/resources/KisLinkedResourceWrapper.h M +36 -33 libs/resources/KisLocalStrokeResources.cpp M +1-0libs/resources/KisRequiredResourcesOperators.h M +33 -13 libs/resources/KisResourceModel.cpp M +3-3libs/resources/KisResourceModel.h M +63 -23 libs/resources/KisResourcesInterface.h M +19 -5libs/resources/KoResourceServer.h M +0-1libs/resourcewidgets/dbexplorer/DlgDbExplorer.cpp M +4-1libs/ui/utils/KisDitherUtil.cpp M +12 -4libs/ui/widgets/KisDitherWidget.cpp M +0-1libs/ui/widgets/kis_preset_chooser.cpp M +12 -3libs/ui/widgets/kis_workspace_chooser.cpp M +11 -2 plugins/filters/gradientmap/KisGradientMapFilterConfiguration.cpp M +9-1plugins/filters/palettize/palettize.cpp M +7-2plugins/generators/pattern/kis_wdg_pattern.cpp M +5-1plugins/generators/pattern/patterngenerator.cpp M +1-0plugins/paintops/libpaintop/KisMaskingBrushOption.cpp M +2-3plugins/paintops/libpaintop/KisTextureMaskInfo.cpp M +0-2plugins/paintops/libpaintop/kis_brush_option.cpp M +15 -4plugins/paintops/libpaintop/kis_linked_pattern_manager.cpp M +9-6plugins/paintops/libpaintop/kis_texture_option.cpp https://invent.kde.org/graphics/krita/commit/8628fd22c755584ef3606732bf3dbe6af8e2b904 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 Halla Rempt changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/91bbbd5ff ||d64c918cb882815f71c097c8c22 ||0bf9 Resolution|--- |FIXED --- Comment #8 from Halla Rempt --- Git commit 91bbbd5ffd64c918cb882815f71c097c8c220bf9 by Halla Rempt. Committed on 02/09/2021 at 13:59. Pushed by rempt into branch 'master'. Fix loading legacy brush masks If there are two resources in two storages that have the same md5sum (square_rough.png and texture_3.png), we need to make sure that the one with the filename stored in the preset can be found, so now resources(md5, filename, name) returns all matching resources. Related: bug 441347 M +17 -6libs/brush/kis_predefined_brush_factory.cpp M +25 -22 libs/image/brushengine/kis_paintop_preset.cpp M +3-0libs/image/brushengine/kis_paintop_settings.cpp M +1-1libs/image/kis_properties_configuration.cc M +3-3libs/psdutils/psd.h M +7-6libs/resources/KisGlobalResourcesInterface.cpp M +3-4libs/resources/KisLinkedResourceWrapper.h M +36 -32 libs/resources/KisLocalStrokeResources.cpp M +1-0libs/resources/KisRequiredResourcesOperators.h M +33 -13 libs/resources/KisResourceModel.cpp M +3-3libs/resources/KisResourceModel.h M +63 -23 libs/resources/KisResourcesInterface.h M +19 -5libs/resources/KoResourceServer.h M +0-1libs/resourcewidgets/dbexplorer/DlgDbExplorer.cpp M +4-1libs/ui/utils/KisDitherUtil.cpp M +12 -4libs/ui/widgets/KisDitherWidget.cpp M +0-1libs/ui/widgets/kis_preset_chooser.cpp M +12 -3libs/ui/widgets/kis_workspace_chooser.cpp M +11 -2 plugins/filters/gradientmap/KisGradientMapFilterConfiguration.cpp M +9-1plugins/filters/palettize/palettize.cpp M +7-2plugins/generators/pattern/kis_wdg_pattern.cpp M +5-1plugins/generators/pattern/patterngenerator.cpp M +1-0plugins/paintops/libpaintop/KisMaskingBrushOption.cpp M +2-3plugins/paintops/libpaintop/KisTextureMaskInfo.cpp M +0-2plugins/paintops/libpaintop/kis_brush_option.cpp M +15 -4plugins/paintops/libpaintop/kis_linked_pattern_manager.cpp M +9-6plugins/paintops/libpaintop/kis_texture_option.cpp https://invent.kde.org/graphics/krita/commit/91bbbd5ffd64c918cb882815f71c097c8c220bf9 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 --- Comment #7 from IForce73 --- That's quite interesting. I really love to read about the progress :-) Halla Rempt schrieb am Sa., 28. Aug. 2021, 15:08: > https://bugs.kde.org/show_bug.cgi?id=441350 > > --- Comment #6 from Halla Rempt --- > When looking for dependent resources -- i.e. brush tips that paintop preset > needs -- we don't care whether the resource we find is active or not. > Inactive > resources aren't shown in the resource selectors, but they can be loaded > and > used. > > When loading a bundle, we load all resources, even if there is already a > resource with the same md5sum in the database, because resources are > considered > for md5sum + storage. > > So, the query for resource by md5sum can return either resource, but > returns > the first one in the database. The problem is that we're still in places > are > looking for resources by filename as well. > > In any case, I think I'm making progress, and I'm just documenting my > ongoing > progress :-) > > -- > You are receiving this mail because: > You are on the CC list for the bug. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 --- Comment #6 from Halla Rempt --- When looking for dependent resources -- i.e. brush tips that paintop preset needs -- we don't care whether the resource we find is active or not. Inactive resources aren't shown in the resource selectors, but they can be loaded and used. When loading a bundle, we load all resources, even if there is already a resource with the same md5sum in the database, because resources are considered for md5sum + storage. So, the query for resource by md5sum can return either resource, but returns the first one in the database. The problem is that we're still in places are looking for resources by filename as well. In any case, I think I'm making progress, and I'm just documenting my ongoing progress :-) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 --- Comment #5 from var...@gmx.ch --- I'm sorry, i mean "which brushes are deactivated in Krita 4 Bundle", and not "bugs". Don't know how to edit a comment ;-) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 --- Comment #4 from var...@gmx.ch --- About your Comment 3, is it not related to https://bugs.kde.org/show_bug.cgi?id=441347 ? Or is there the same problem? Cause in the bug 441347 i tell which bugs are deactivated in Krita 4 Bundle cause it is in Krita 3, but this are also deactivated and not avaiable in the library. There are a bunch of overlapping brushes in Krita 4 and 3 Resources and all from the Krita 4 Bundle are deactivated cause the md5sum checks the Krita 3 bundle first, right? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 --- Comment #3 from Halla Rempt --- Okay, preliminary conclusions: * There are two brush tips with the same md5sum, cf1bc7415af3103afcd82f58a2e6fe18. * But they have two different filenames: square_rough.png (krita4 bundle) and 3_texture.png (krita 3 bundle). * At some point, because we select the first resource with the correct md5sum, 3_texture.png gets added to the thread local resource snapshot. However, the paintop option still only selects by filename, and so looks for square_rough.png, which isn't in there. Two options: * return all resources with the right type and filename in KisAllResourceModel::resourceByName/FileName/MD5, and add them to the local snapshot * change the paintop options to add the relevant keys for md5sum to the option's settings object, and select from the local resource shapshot by md5sum. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 --- Comment #2 from Halla Rempt --- Looks like there's something weird with determining whather a brush is has a masking brush. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 Halla Rempt changed: What|Removed |Added CC||uenvironme...@gmail.com --- Comment #1 from Halla Rempt --- *** Bug 441437 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441350] Brushes works wrong, after selecting another pattern and reselecting the original one, they works like the should
https://bugs.kde.org/show_bug.cgi?id=441350 Halla Rempt changed: What|Removed |Added Ever confirmed|0 |1 CC||ha...@valdyas.org Status|REPORTED|ASSIGNED Assignee|krita-bugs-n...@kde.org |ha...@valdyas.org -- You are receiving this mail because: You are watching all bug changes.
