[krita] [Bug 443111] Create from Clipboard not working as intended
https://bugs.kde.org/show_bug.cgi?id=443111 --- Comment #14 from amyspark --- Git commit 573a7622a2fbddef8379c2b84fe6eadfd24a46e6 by L. E. Segovia. Committed on 27/11/2021 at 13:25. Pushed by lsegovia into branch 'master'. Fix position inconsistency in Paste at Cursor URL-backed images are handled by KisClipboardUtil::clipboardHasUrlsAction, which sidesteps all positioning logic. Yet, KisClipboard::instance()->clip also handles URL-backed images via KisClipboardUtil::fetchImageByURL. Conversely, clipboard bitmaps are pasted into a paint device which is then recentered. This commit fixes the dissonance by dropping the specialization, and ensuring that all clip() paths are centered. Related: bug 446120 (cherry picked from commit 30f7b1c9e966dca97f83f24da077df2789168aa8) M +0-6libs/ui/actions/KisPasteActionFactories.cpp M +7-5libs/ui/kis_clipboard.cc https://invent.kde.org/graphics/krita/commit/573a7622a2fbddef8379c2b84fe6eadfd24a46e6 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443111] Create from Clipboard not working as intended
https://bugs.kde.org/show_bug.cgi?id=443111 --- Comment #13 from amyspark --- Git commit 30f7b1c9e966dca97f83f24da077df2789168aa8 by L. E. Segovia. Committed on 27/11/2021 at 00:43. Pushed by lsegovia into branch 'krita/5.0'. Fix position inconsistency in Paste at Cursor URL-backed images are handled by KisClipboardUtil::clipboardHasUrlsAction, which sidesteps all positioning logic. Yet, KisClipboard::instance()->clip also handles URL-backed images via KisClipboardUtil::fetchImageByURL. Conversely, clipboard bitmaps are pasted into a paint device which is then recentered. This commit fixes the dissonance by dropping the specialization, and ensuring that all clip() paths are centered. Related: bug 446120 M +0-6libs/ui/actions/KisPasteActionFactories.cpp M +7-5libs/ui/kis_clipboard.cc https://invent.kde.org/graphics/krita/commit/30f7b1c9e966dca97f83f24da077df2789168aa8 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443111] Create from Clipboard not working as intended
https://bugs.kde.org/show_bug.cgi?id=443111 --- Comment #12 from Dmitry Kazakov --- Git commit 510842271ecd1b6f56163636235d5642ba7b16e2 by Dmitry Kazakov. Committed on 17/11/2021 at 13:47. Pushed by dkazakov into branch 'krita/5.0'. Fix assert when creating an image from Krita's internal clipboard When we copy local nodes, we should reinitialize both image and shape controller links. This patch fixes the former link, but keeps the second one unset. It should fix a crash when creating an image from the clipboard. M +7-1libs/ui/kis_mimedata.cpp https://invent.kde.org/graphics/krita/commit/510842271ecd1b6f56163636235d5642ba7b16e2 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443111] Create from Clipboard not working as intended
https://bugs.kde.org/show_bug.cgi?id=443111 Tiar changed: What|Removed |Added CC||tamtamy.tym...@gmail.com --- Comment #11 from Tiar --- *** Bug 443902 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443111] Create from Clipboard not working as intended
https://bugs.kde.org/show_bug.cgi?id=443111 --- Comment #10 from Dmitry Kazakov --- Git commit df528d74058bc976a103d4f10e2a53d960a054c2 by Dmitry Kazakov. Committed on 13/10/2021 at 08:18. Pushed by dkazakov into branch 'krita/5.0'. Fix crash when creating a new image with URL present in the clipboard Basically, KisClipboard::clip() should not ask anything related to multiple URLs in the clipboard. Its responsibility to load only one image from the clipboard (the first URL if there are multiple). Parsing of multiple URLs is the responsibility of a higher level code. M +10 -2libs/ui/actions/KisPasteActionFactories.cpp M +2-7libs/ui/kis_clipboard.cc M +49 -0libs/ui/utils/KisClipboardUtil.cpp M +3-0libs/ui/utils/KisClipboardUtil.h https://invent.kde.org/graphics/krita/commit/df528d74058bc976a103d4f10e2a53d960a054c2 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443111] Create from Clipboard not working as intended
https://bugs.kde.org/show_bug.cgi?id=443111 Dmitry Kazakov changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #9 from Dmitry Kazakov --- The bug seems to be fixed now. I have tested the following cases: 1) "Copy Buffer" from nomacs works 2) "Copy" (file url) from nomacs works 3) "Copy Image" works on both Firefox and Chromium 4) "Copy Link" doesn't work, neither on Firefox nor on Chromium, because they save the link as text/plain. For every case I tried the following: a) Create new document from clipboard b) Ctrl+V the clip into existing document If you still have issues, please reopen the bug :) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443111] Create from Clipboard not working as intended
https://bugs.kde.org/show_bug.cgi?id=443111 --- Comment #8 from Dmitry Kazakov --- Git commit 8f6c508e889c694876d806750489d5c6e00b1fb0 by Dmitry Kazakov. Committed on 12/10/2021 at 08:42. Pushed by dkazakov into branch 'master'. Fix crash when creating a new image with URL present in the clipboard Basically, KisClipboard::clip() should not ask anything related to multiple URLs in the clipboard. Its responsibility to load only one image from the clipboard (the first URL if there are multiple). Parsing of multiple URLs is the responsibility of a higher level code. M +9-2libs/ui/actions/KisPasteActionFactories.cpp M +2-7libs/ui/kis_clipboard.cc M +49 -0libs/ui/utils/KisClipboardUtil.cpp M +3-0libs/ui/utils/KisClipboardUtil.h https://invent.kde.org/graphics/krita/commit/8f6c508e889c694876d806750489d5c6e00b1fb0 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443111] Create from Clipboard not working as intended
https://bugs.kde.org/show_bug.cgi?id=443111 --- Comment #7 from Dmitry Kazakov --- I can confirm the crash :( -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443111] Create from Clipboard not working as intended
https://bugs.kde.org/show_bug.cgi?id=443111 Ahab Greybeard changed: What|Removed |Added CC||ahab.greybe...@hotmail.co.u ||k --- Comment #6 from Ahab Greybeard --- The Oct 07 5.1.0-prealpha (git f2ad3000) appimage on Debian 10 MATE still has a strange problem. When first started, an image copied using the 'Eye of MATE' image viewer will cause a crash if I use Edit -> Paste into New Image. An image copied with the 'gThumb' image viewer will have no problems after usaing Edit -> Paste into New Image. After that, I can use an image copied with 'Eye of MATE' with Edit -> Paste into New Image and krita will then give me the list of options of how to paste it. Choosing to paste into a new document gives no problems. When it crashes, the terminal says "Segmentation fault". There is no relevant log entry. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443111] Create from Clipboard not working as intended
https://bugs.kde.org/show_bug.cgi?id=443111 --- Comment #5 from Dmitry Kazakov --- Git commit afb8e54832f8ffd59d0272183ecc537a0aca06a3 by Dmitry Kazakov. Committed on 05/10/2021 at 05:24. Pushed by dkazakov into branch 'master'. Fix assert when creating an image from Krita's internal clipboard When we copy local nodes, we should reinitialize both image and shape controller links. This patch fixes the former link, but keeps the second one unset. It should fix a crash when creating an image from the clipboard. M +7-1libs/ui/kis_mimedata.cpp https://invent.kde.org/graphics/krita/commit/afb8e54832f8ffd59d0272183ecc537a0aca06a3 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443111] Create from Clipboard not working as intended
https://bugs.kde.org/show_bug.cgi?id=443111 tomtomtomreportin...@gmail.com changed: What|Removed |Added CC||tomtomtomreportingin@gmail. ||com --- Comment #4 from tomtomtomreportin...@gmail.com --- I don't think this is browser-related as I've come across this issue with images copied from Krita itself. 1. Create an A5 600 DPI document with layers. 2. On Paint Layer 1, create a max setting Random Noise filter mask. 3. Flatten the image and cut with Ctrl + X. 4. Check Create from Clipboard, it should be read properly at this moment. 4. Restart Krita. 5. Check Create from Clipboard, it's no longer read properly. Sometimes you'll get an image with wrong dimensions or the image won't be read at all. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443111] Create from Clipboard not working as intended
https://bugs.kde.org/show_bug.cgi?id=443111 Dmitry Kazakov changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com CC||dimul...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443111] Create from Clipboard not working as intended
https://bugs.kde.org/show_bug.cgi?id=443111 Halla Rempt changed: What|Removed |Added Keywords||regression, release_blocker Resolution|WAITINGFORINFO |--- Status|NEEDSINFO |CONFIRMED Ever confirmed|0 |1 --- Comment #3 from Halla Rempt --- I can also reproduce this with firefox _and_ chromeium on Linux. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443111] Create from Clipboard not working as intended
https://bugs.kde.org/show_bug.cgi?id=443111 --- Comment #2 from Rexel --- (In reply to Halla Rempt from comment #1) > Which browser are you using? There is a known bug in Chrome that puts images > on the clipboard in a broken way... I'm using Firefox, and actually now that I've tested it, everything works fine when I copy images from Chrome but not Firefox :( I'm also using the portable zip versions of Krita 5 as I want to keep Krita 4 as my main workhorse while I test things out. I've tested it again on Krita 4 and copying from both Firefox and Chrome works fine. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443111] Create from Clipboard not working as intended
https://bugs.kde.org/show_bug.cgi?id=443111 Halla Rempt changed: What|Removed |Added CC||ha...@valdyas.org Status|REPORTED|NEEDSINFO Resolution|--- |WAITINGFORINFO --- Comment #1 from Halla Rempt --- Which browser are you using? There is a known bug in Chrome that puts images on the clipboard in a broken way... -- You are receiving this mail because: You are watching all bug changes.
