[krita] [Bug 446120] Paste At Position doesn't paste at the cursor
https://bugs.kde.org/show_bug.cgi?id=446120 amyspark changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/30f7b1c9e |hics/krita/commit/573a7622a |966dca97f83f24da077df278916 |2fbddef8379c2b84fe6eadfd24a |8aa8|46e6 --- Comment #4 from amyspark --- Git commit 573a7622a2fbddef8379c2b84fe6eadfd24a46e6 by L. E. Segovia. Committed on 27/11/2021 at 13:25. Pushed by lsegovia into branch 'master'. Fix position inconsistency in Paste at Cursor URL-backed images are handled by KisClipboardUtil::clipboardHasUrlsAction, which sidesteps all positioning logic. Yet, KisClipboard::instance()->clip also handles URL-backed images via KisClipboardUtil::fetchImageByURL. Conversely, clipboard bitmaps are pasted into a paint device which is then recentered. This commit fixes the dissonance by dropping the specialization, and ensuring that all clip() paths are centered. Related: bug 443111 (cherry picked from commit 30f7b1c9e966dca97f83f24da077df2789168aa8) M +0-6libs/ui/actions/KisPasteActionFactories.cpp M +7-5libs/ui/kis_clipboard.cc https://invent.kde.org/graphics/krita/commit/573a7622a2fbddef8379c2b84fe6eadfd24a46e6 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446120] Paste At Position doesn't paste at the cursor
https://bugs.kde.org/show_bug.cgi?id=446120 --- Comment #3 from amyspark --- Git commit 689c86d924beb64ecd4f6b00cf254c004dea4c0f by L. E. Segovia. Committed on 27/11/2021 at 13:24. Pushed by lsegovia into branch 'master'. Fix regression in positioning of URL-based drag-and-drops 47db9c0be50fc85f38ba6c86757a7b307f0bbbd4 did not account for the position of the drop event, and instead used the cursor position. This means that, if the menu and/or the dialog popup were invoked, the paste position would be taken from the interaction with those widgets and not from the place where the action was triggered. This doesn't fix the discrepancy in painting a remote and a local image; that will be fixed in the next commit. (cherry picked from commit be44b3f682e6e161dd122940236b2f580667d23d) M +20 -26 libs/ui/KisView.cpp M +4-2libs/ui/actions/KisPasteActionFactories.cpp M +3-2libs/ui/utils/KisClipboardUtil.cpp M +1-1libs/ui/utils/KisClipboardUtil.h https://invent.kde.org/graphics/krita/commit/689c86d924beb64ecd4f6b00cf254c004dea4c0f -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446120] Paste At Position doesn't paste at the cursor
https://bugs.kde.org/show_bug.cgi?id=446120 --- Comment #2 from amyspark --- Git commit be44b3f682e6e161dd122940236b2f580667d23d by L. E. Segovia. Committed on 27/11/2021 at 00:43. Pushed by lsegovia into branch 'krita/5.0'. Fix regression in positioning of URL-based drag-and-drops 47db9c0be50fc85f38ba6c86757a7b307f0bbbd4 did not account for the position of the drop event, and instead used the cursor position. This means that, if the menu and/or the dialog popup were invoked, the paste position would be taken from the interaction with those widgets and not from the place where the action was triggered. This doesn't fix the discrepancy in painting a remote and a local image; that will be fixed in the next commit. M +20 -26 libs/ui/KisView.cpp M +4-2libs/ui/actions/KisPasteActionFactories.cpp M +3-2libs/ui/utils/KisClipboardUtil.cpp M +1-1libs/ui/utils/KisClipboardUtil.h https://invent.kde.org/graphics/krita/commit/be44b3f682e6e161dd122940236b2f580667d23d -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446120] Paste At Position doesn't paste at the cursor
https://bugs.kde.org/show_bug.cgi?id=446120 amyspark changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/30f7b1c9e ||966dca97f83f24da077df278916 ||8aa8 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #1 from amyspark --- Git commit 30f7b1c9e966dca97f83f24da077df2789168aa8 by L. E. Segovia. Committed on 27/11/2021 at 00:43. Pushed by lsegovia into branch 'krita/5.0'. Fix position inconsistency in Paste at Cursor URL-backed images are handled by KisClipboardUtil::clipboardHasUrlsAction, which sidesteps all positioning logic. Yet, KisClipboard::instance()->clip also handles URL-backed images via KisClipboardUtil::fetchImageByURL. Conversely, clipboard bitmaps are pasted into a paint device which is then recentered. This commit fixes the dissonance by dropping the specialization, and ensuring that all clip() paths are centered. Related: bug 443111 M +0-6libs/ui/actions/KisPasteActionFactories.cpp M +7-5libs/ui/kis_clipboard.cc https://invent.kde.org/graphics/krita/commit/30f7b1c9e966dca97f83f24da077df2789168aa8 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446120] Paste At Position doesn't paste at the cursor
https://bugs.kde.org/show_bug.cgi?id=446120 amyspark changed: What|Removed |Added CC||ghe...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446120] Paste At Position doesn't paste at the cursor
https://bugs.kde.org/show_bug.cgi?id=446120 amyspark changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |a...@amyspark.me Status|REPORTED|ASSIGNED Keywords||regression, release_blocker Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
