[krita] [Bug 447700] Right-to-left (RTL) issues with animation timeline

2022-01-30 Thread Zayed Al-Saidi
https://bugs.kde.org/show_bug.cgi?id=447700

--- Comment #8 from Zayed Al-Saidi  ---
(In reply to Alvin Wong from comment #7)
> How about we first fix the current RTL layout, then we can consider adding
> an option to force the timeline to be in LTR for those who like it better?

That is the optimum solution.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447700] Right-to-left (RTL) issues with animation timeline

2022-01-30 Thread Alvin Wong
https://bugs.kde.org/show_bug.cgi?id=447700

--- Comment #7 from Alvin Wong  ---
How about we first fix the current RTL layout, then we can consider adding an
option to force the timeline to be in LTR for those who like it better?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447700] Right-to-left (RTL) issues with animation timeline

2022-01-06 Thread Zayed Al-Saidi
https://bugs.kde.org/show_bug.cgi?id=447700

--- Comment #6 from Zayed Al-Saidi  ---
(In reply to Alvin Wong from comment #5)
> (In reply to Zayed Al-Saidi from comment #4)
> > Please don't follow that guideline. It is weird!!  Now I understand the
> > weird behavior of Android application.
> 
> Thanks for the comment. I did find more sources that concurs that media
> playback are always LTR:
> 
> - https://rtlstyling.com/posts/rtl-styling#media-player-icons
> -
> https://engineering.atspotify.com/2019/04/15/right-to-left-the-mirror-world/
> (in the "Exceptions" paragraph)
> - https://github.com/exaile/exaile/issues/144
> 
> And a user on the Krita Artists forum also thinks the timeline should be
> LTR:
> https://krita-artists.org/t/feedback-needed-from-krita-users-who-speak-
> arabic-or-hebrew/34492/9
> 
> Do you agree with them?
Sure, I don't agree because we as RTL user start looking from right to left and
this is the opposite! For media player, it is somehow  accepted since the UI is
very simple and every  thing is  force to be LTR mode.  To do that in Krita the
whole dock must be LTR which will weird when everything is in RTL mode. 

> ---
> 
> By the way, should sliders (e.g. the "Speed" slider in the screenshot) be
> mirrored to have the bar extend from right to left too?
The slider should follow the layout of the timeline dock. If it is RTL the
progress should start from right (0%)  to left (100%)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447700] Right-to-left (RTL) issues with animation timeline

2022-01-06 Thread Alvin Wong
https://bugs.kde.org/show_bug.cgi?id=447700

--- Comment #5 from Alvin Wong  ---
(In reply to Zayed Al-Saidi from comment #4)
> Please don't follow that guideline. It is weird!!  Now I understand the
> weird behavior of Android application.

Thanks for the comment. I did find more sources that concurs that media
playback are always LTR:

- https://rtlstyling.com/posts/rtl-styling#media-player-icons
- https://engineering.atspotify.com/2019/04/15/right-to-left-the-mirror-world/
(in the "Exceptions" paragraph)
- https://github.com/exaile/exaile/issues/144

And a user on the Krita Artists forum also thinks the timeline should be LTR:
https://krita-artists.org/t/feedback-needed-from-krita-users-who-speak-arabic-or-hebrew/34492/9

Do you agree with them?
---

By the way, should sliders (e.g. the "Speed" slider in the screenshot) be
mirrored to have the bar extend from right to left too?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447700] Right-to-left (RTL) issues with animation timeline

2022-01-05 Thread Zayed Al-Saidi
https://bugs.kde.org/show_bug.cgi?id=447700

Zayed Al-Saidi  changed:

   What|Removed |Added

 CC||zayed.alsa...@gmail.com

--- Comment #4 from Zayed Al-Saidi  ---
(In reply to Alvin Wong from comment #0)
> Created attachment 144970 [details]
> Animation timeline in RTL
> 
> There seems to be some issues with RTL, where the layout is mirrored:
> 
> 1. Some buttons that should be above the layer list is placed at the wrong
> side
> 2. Frame number is offset
> 3. The layout of the layer list rows are not mirrored
> 4. The playback/seeking buttons don't have their icons mirrored
> 5. When dragging left and right using the horizontal scrollbar, the movement
> direction is wrong

I would add the default layout of workspace should be mirrored as well in RTL
mode.

> However, before we fix any of these we should think about whether the
> timeline shall be mirrored for RTL. The material design guide [1] states
> that "[a]nything depicting the passage of time should be mirrored", but then
> also states that "[d]o not mirror media playback buttons and the media
> progress indicator as they refer to the direction of tape being played, not
> the direction of time". If this is worth referencing then a possible
> solution is to explicitly set the layout direction of the animation timeline
> to be left-to-right and call it done.
> 
> This requires input from RTL users. Comments from experts would be even
> better.
> 
> [1]:
> https://material.io/design/usability/bidirectionality.html#mirroring-elements

Please don't follow that guideline. It is weird!!  Now I understand the weird
behavior of Android application.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447700] Right-to-left (RTL) issues with animation timeline

2022-01-04 Thread Alvin Wong
https://bugs.kde.org/show_bug.cgi?id=447700

--- Comment #3 from Alvin Wong  ---
(In reply to Eoin O'Neill from comment #2)
> Out of curiosity, are the timeline transport controls working as expected
> and the icons are just backwards?

Well, "expected" is a vague concept... the button to the right of the "Stop"
button is "Back", and if you expect all of the layout to simply be mirrored,
then yes that seems working as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447700] Right-to-left (RTL) issues with animation timeline

2022-01-03 Thread Eoin O'Neill
https://bugs.kde.org/show_bug.cgi?id=447700

Eoin O'Neill  changed:

   What|Removed |Added

 CC||eoinoneill1...@gmail.com
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #2 from Eoin O'Neill  ---
Hi Alvin,

I'll go ahead and confirm this, though I haven't tried it yet myself. It looks
like some modifications to some of the layouting math needs to be made for RTL
layout considerations. I'm also not super happy with the frame number alignment
in either RTL or LTR, so some modifications would be nice there anyway...

Out of curiosity, are the timeline transport controls working as expected and
the icons are just backwards?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447700] Right-to-left (RTL) issues with animation timeline

2021-12-31 Thread Alvin Wong
https://bugs.kde.org/show_bug.cgi?id=447700

Alvin Wong  changed:

   What|Removed |Added

   Keywords||rtl

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447700] Right-to-left (RTL) issues with animation timeline

2021-12-30 Thread Alvin Wong
https://bugs.kde.org/show_bug.cgi?id=447700

--- Comment #1 from Alvin Wong  ---
Created attachment 144971
  --> https://bugs.kde.org/attachment.cgi?id=144971&action=edit
Animation timeline in LTR

For reference, this is how it looks in LTR.

-- 
You are receiving this mail because:
You are watching all bug changes.