[krita] [Bug 456450] [subwindow mode] drag and drop a vector layer crashes Krita
https://bugs.kde.org/show_bug.cgi?id=456450 Halla Rempt changed: What|Removed |Added Keywords||regression, release_blocker CC||ha...@valdyas.org -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 456450] [subwindow mode] drag and drop a vector layer crashes Krita
https://bugs.kde.org/show_bug.cgi?id=456450 Halla Rempt changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 456450] [subwindow mode] drag and drop a vector layer crashes Krita
https://bugs.kde.org/show_bug.cgi?id=456450 amyspark changed: What|Removed |Added CC||a...@amyspark.me Depends on||423752 --- Comment #1 from amyspark --- Duplicate by revival of 423752, when retrieving Krita node data from the clipboard, shape nodes happily ignore the image assigned in the call to KisMimeData::initializeExternalNode. This seems to go all the way to https://invent.kde.org/graphics/krita/-/commit/9475fe1d7301100ef9245da67f39e646bc1b394f. Referenced Bugs: https://bugs.kde.org/show_bug.cgi?id=423752 [Bug 423752] Crash can be induced with 4.3.0 onwards after copying a vector layer to another open image -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 456450] [subwindow mode] drag and drop a vector layer crashes Krita
https://bugs.kde.org/show_bug.cgi?id=456450 amyspark changed: What|Removed |Added Status|CONFIRMED |ASSIGNED Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com Depends on||452146 --- Comment #2 from amyspark --- Regression tracked to 81f9b1aac89d3b00e5f357dd235e6c37f002f5fb: commit 81f9b1aac89d3b00e5f357dd235e6c37f002f5fb Author: Dmitry Kazakov Date: Thu Apr 7 12:35:23 2022 +0300 Fix initialization of image link in the pasted nodes I'm not sure this patch is safe enough for 5.0.x branch. BUG:452146 https://invent.kde.org/graphics/krita/-/commit/81f9b1aac89d3b00e5f357dd235e6c37f002f5fb#5c6b72611ab77b63397e0ecf50a231e504b5_223_225 removes the image reassignment for this particular case. Referenced Bugs: https://bugs.kde.org/show_bug.cgi?id=452146 [Bug 452146] A Copy of a transparency mask or a filter mask is incomplete. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 456450] [subwindow mode] drag and drop a vector layer crashes Krita
https://bugs.kde.org/show_bug.cgi?id=456450 --- Comment #3 from Dmitry Kazakov --- Git commit 6531b6b666129cbbd0b61dadafd6bb27b6750629 by Dmitry Kazakov. Committed on 08/07/2022 at 15:28. Pushed by dkazakov into branch 'krita/5.1'. Fix D&D of the shape layers when src and dst resolutions differ We need to adjust the resolution of the shape layer to fix the new image in pixel measurements. M +13 -3libs/ui/kis_mimedata.cpp M +1-1libs/ui/kis_mimedata.h https://invent.kde.org/graphics/krita/commit/6531b6b666129cbbd0b61dadafd6bb27b6750629 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 456450] [subwindow mode] drag and drop a vector layer crashes Krita
https://bugs.kde.org/show_bug.cgi?id=456450 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/39b5ef790 ||7fe22b120b572fc49887ae83bde ||16b5 --- Comment #4 from Dmitry Kazakov --- Git commit 39b5ef7907fe22b120b572fc49887ae83bde16b5 by Dmitry Kazakov. Committed on 08/07/2022 at 15:28. Pushed by dkazakov into branch 'krita/5.1'. Fix a crash when D&D a vector layer from one image to another The patch does several things 1) Removes "application/x-krita-node" mimedata completely. It was used to pass Krita nodes between multiple instances of Krita. Since we don't support multiinstance runs anymore, these types should go. (they failed in multiple usecases anyway) 2) Implements a special KisDetachedShapesViewConverter converter class that is attached to KisShapeLayerCanvasBase, when it has no image attached (that was an exact cause of the crash). Now, when the vector layer is placed into a mime data, its converter is replaced with the detached one to no rely on KisImage (which is deleted at that moment) M +1-0libs/ui/CMakeLists.txt A +19 -0libs/ui/KisClonableViewConverter.h [License: GPL(v2.0+)] A +56 -0libs/ui/KisDetachedShapesViewConverter.cpp [License: GPL(v2.0+)] A +42 -0libs/ui/KisDetachedShapesViewConverter.h [License: GPL(v2.0+)] M +13 -14 libs/ui/KisView.cpp M +2-2libs/ui/KisWelcomePageWidget.cpp M +1-4libs/ui/flake/KisReferenceImagesLayer.cpp M +16 -7libs/ui/flake/kis_shape_layer.cc M +0-1libs/ui/flake/kis_shape_layer.h M +48 -6libs/ui/flake/kis_shape_layer_canvas.cpp M +11 -5libs/ui/flake/kis_shape_layer_canvas.h M +2-2libs/ui/kis_clipboard.cc M +4-9libs/ui/kis_image_view_converter.cpp M +4-8libs/ui/kis_image_view_converter.h M +33 -87 libs/ui/kis_mimedata.cpp M +15 -12 libs/ui/kis_mimedata.h M +1-1libs/ui/kis_node_model.cpp https://invent.kde.org/graphics/krita/commit/39b5ef7907fe22b120b572fc49887ae83bde16b5 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 456450] [subwindow mode] drag and drop a vector layer crashes Krita
https://bugs.kde.org/show_bug.cgi?id=456450 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/39b5ef790 |hics/krita/commit/e1b32d773 |7fe22b120b572fc49887ae83bde |526983ee54a4edfafd146d30ff0 |16b5|8b2a --- Comment #5 from Dmitry Kazakov --- Git commit e1b32d773526983ee54a4edfafd146d30ff08b2a by Dmitry Kazakov. Committed on 08/07/2022 at 15:27. Pushed by dkazakov into branch 'master'. Fix a crash when D&D a vector layer from one image to another The patch does several things 1) Removes "application/x-krita-node" mimedata completely. It was used to pass Krita nodes between multiple instances of Krita. Since we don't support multiinstance runs anymore, these types should go. (they failed in multiple usecases anyway) 2) Implements a special KisDetachedShapesViewConverter converter class that is attached to KisShapeLayerCanvasBase, when it has no image attached (that was an exact cause of the crash). Now, when the vector layer is placed into a mime data, its converter is replaced with the detached one to no rely on KisImage (which is deleted at that moment) M +1-0libs/ui/CMakeLists.txt A +19 -0libs/ui/KisClonableViewConverter.h [License: GPL(v2.0+)] A +56 -0libs/ui/KisDetachedShapesViewConverter.cpp [License: GPL(v2.0+)] A +42 -0libs/ui/KisDetachedShapesViewConverter.h [License: GPL(v2.0+)] M +13 -14 libs/ui/KisView.cpp M +2-2libs/ui/KisWelcomePageWidget.cpp M +1-4libs/ui/flake/KisReferenceImagesLayer.cpp M +16 -7libs/ui/flake/kis_shape_layer.cc M +0-1libs/ui/flake/kis_shape_layer.h M +48 -6libs/ui/flake/kis_shape_layer_canvas.cpp M +11 -5libs/ui/flake/kis_shape_layer_canvas.h M +2-2libs/ui/kis_clipboard.cc M +4-9libs/ui/kis_image_view_converter.cpp M +4-8libs/ui/kis_image_view_converter.h M +33 -87 libs/ui/kis_mimedata.cpp M +15 -12 libs/ui/kis_mimedata.h M +1-1libs/ui/kis_node_model.cpp https://invent.kde.org/graphics/krita/commit/e1b32d773526983ee54a4edfafd146d30ff08b2a -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 456450] [subwindow mode] drag and drop a vector layer crashes Krita
https://bugs.kde.org/show_bug.cgi?id=456450 --- Comment #6 from Dmitry Kazakov --- Git commit 25e1e1492c0c49424a539fe1a85b59c34ac4a821 by Dmitry Kazakov. Committed on 08/07/2022 at 15:27. Pushed by dkazakov into branch 'master'. Fix D&D of the shape layers when src and dst resolutions differ We need to adjust the resolution of the shape layer to fix the new image in pixel measurements. M +13 -3libs/ui/kis_mimedata.cpp M +1-1libs/ui/kis_mimedata.h https://invent.kde.org/graphics/krita/commit/25e1e1492c0c49424a539fe1a85b59c34ac4a821 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 456450] [subwindow mode] drag and drop a vector layer crashes Krita
https://bugs.kde.org/show_bug.cgi?id=456450 --- Comment #7 from amyspark --- Git commit abaec2f7bba30800e22811057fb30b0ec0be78ae by L. E. Segovia. Committed on 18/08/2022 at 17:17. Pushed by lsegovia into branch 'master'. KisMimeData: remove leftover parameter from loadNonNativeNodes M +2-3libs/ui/kis_mimedata.cpp M +1-2libs/ui/kis_mimedata.h https://invent.kde.org/graphics/krita/commit/abaec2f7bba30800e22811057fb30b0ec0be78ae -- You are receiving this mail because: You are watching all bug changes.
