[krita] [Bug 456778] pasting a not properly copied web image crashes krita

2022-07-15 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=456778

--- Comment #1 from til.schmit...@gmx.de ---
oh i guess this part from the crash log should also help

krita.exe caused a Breakpoint at location 7FFD7969D662 in module
KERNELBASE.dll.

AddrPC   Params
7FFD7969D662 01A1934A6610 0086 7FFD3CEF7C00 
KERNELBASE.dll!wil::details::DebugBreak+0x2
7FFD3B0B481A 7FFD3CEF7AEE 01CE 7FFD3B60A3C0 
Qt5Core.dll!qt_message_fatal+0xa
7FFD3B0B58AF 000A684FB4B0 000A 01A19239E5C8 
Qt5Core.dll!QMessageLogger::fatal+0x85
7FFD58C92F6D  000A8000 0003 
libkritaglobal.dll!kis_assert_common+0x54d
7FFD58C930D1 01A1F470B640 000A684FB8B0 000A684FB980 
libkritaglobal.dll!kis_assert_exception+0x11
7FFD3CA0F534 01A1870CE560 01A1901BED10 01A192600310 
libkritaui.dll!KisClipboard::clipFromBoardContents+0xd4
7FFD3CA0E0CC 7FFD3D1301C8 000A 01A185F8CDF0 
libkritaui.dll!KisClipboard::clip+0x5bc
7FFD3CD055EB  7FFD794DF05B 01A1933D99D8 
libkritaui.dll!KisPasteActionFactory::run+0x135b
7FFD3CAFAD96 7FFD3B60B038 0001  
libkritaui.dll!KisSelectionManager::paste+0x76
(...)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 456778] pasting a not properly copied web image crashes krita

2022-07-15 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=456778

amyspark  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 CC||a...@amyspark.me
 Ever confirmed|0   |1

--- Comment #2 from amyspark  ---
> i feel like the image was so big that it took a while to copy into memory. 
> might be a windows issue in that case..?

Indeed. The issue here is that Qt's reporting an image exists in the clipboard
(probably based on the mimetypes of the clipboard data) yet the bitmap's
irretrievable by the time KisClipboard attempts to read it. The assertion your
log and stacktrace refer to is *exactly* this check.

Can you reliably reproduce it with that image? And were you able to test it
from other sources? I mean particularly Chromium or d&d from the Explorer.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 456778] pasting a not properly copied web image crashes krita

2022-07-16 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=456778

--- Comment #3 from til.schmit...@gmx.de ---
i was reliably able to reproduce it with this image and also with another image
of the same dimensions. did this with edge browser. I'll test the rest in a few
days because I'm not at my desktop this weekend. I'll try with my laptop asap
though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 456778] pasting a not properly copied web image crashes krita

2022-07-16 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=456778

amyspark  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |a...@amyspark.me
 Status|CONFIRMED   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 456778] pasting a not properly copied web image crashes krita

2022-07-17 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=456778

--- Comment #4 from til.schmit...@gmx.de ---
> And were you able to test it from other sources? I mean particularly Chromium 
> or d&d from the Explorer.

chrome, firefox, edge all show this behavior and crash.
d&d / copy+paste from the explorer works like normal, no crash here.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 456778] pasting a not properly copied web image crashes krita

2022-07-17 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=456778

--- Comment #5 from til.schmit...@gmx.de ---
since we're already on the topic of copy paste issues, idk if this should be a
separate bug report, but drag n drop from browsers only works for reference
images. drag n drop as a new layer or new document doesn't work and results in
the error: "File [filename] does not exist." after downloading the image

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 456778] pasting a not properly copied web image crashes krita

2022-07-19 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=456778

amyspark  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/e747146f1
   ||b6e0e425c73ad125793a19411e3
   ||017b
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from amyspark  ---
Git commit e747146f1b6e0e425c73ad125793a19411e3017b by L. E. Segovia.
Committed on 19/07/2022 at 23:45.
Pushed by lsegovia into branch 'master'.

KisClipboard: use the correct check for defaulted bitmap pastes

If cbData->hasImage() returns true, but qimage earlier was null, then
the clipboard has an unfinished or corrupt paste data. We'd added the
check for these cases, but I didn't update the default options for
Chromium sources.

M  +1-1libs/ui/kis_clipboard.cc

https://invent.kde.org/graphics/krita/commit/e747146f1b6e0e425c73ad125793a19411e3017b

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 456778] pasting a not properly copied web image crashes krita

2022-07-19 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=456778

amyspark  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/e747146f1 |hics/krita/commit/b723e0ef1
   |b6e0e425c73ad125793a19411e3 |84137748f1cec6116e227c87b29
   |017b|f92a

--- Comment #7 from amyspark  ---
Git commit b723e0ef184137748f1cec6116e227c87b29f92a by L. E. Segovia.
Committed on 19/07/2022 at 23:47.
Pushed by lsegovia into branch 'krita/5.1'.

KisClipboard: use the correct check for defaulted bitmap pastes

If cbData->hasImage() returns true, but qimage earlier was null, then
the clipboard has an unfinished or corrupt paste data. We'd added the
check for these cases, but I didn't update the default options for
Chromium sources.
(cherry picked from commit e747146f1b6e0e425c73ad125793a19411e3017b)

M  +1-1libs/ui/kis_clipboard.cc

https://invent.kde.org/graphics/krita/commit/b723e0ef184137748f1cec6116e227c87b29f92a

-- 
You are receiving this mail because:
You are watching all bug changes.