[krita] [Bug 457514] After installing krita 5.1.0 touch gestures won't function on wacom cintinq 24

[sh_zam]

https://bugs.kde.org/show_bug.cgi?id=457514

sh_zam  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/cc8f304a7 |hics/krita/commit/6346889b7
   |da266b909d70104ce0d9de7aee7 |d9f7e7f988f48896af333204df9
   |f3b8|d306

--- Comment #11 from sh_zam  ---
Git commit 6346889b7d9f7e7f988f48896af333204df9d306 by Sharaf Zaman.
Committed on 09/08/2022 at 07:42.
Pushed by szaman into branch 'krita/5.1'.

Make Krita's canvas input profile migrate-able from version 5 to 6

The porting (PROFILE_VERSION - 1) to PROFILE_VERSION works as something
like this, with entry point being loadProfile():

1. We fill two lists, `profileEntries`: one with profiles with profile version
being
PROFILE_VERSION, `profileEntriesToMigrate`: one with profiles with version
being (PROFILE_VERSION - 1).

2. We go through the list we want to migrate and check if there is a
corresponding version of it in `profileEntries` and that has to exist in
user-local directory (not in install location -- which is the profile
version we ship).

a. If there doesn't exist one, we migrate the profile entry. And
remove it from `profileEntriesToMigrate`.
b. If there exists one (which isn't in user-local), we don't
migrate.

3. Once we get what we have to migrate and what we don't. We invoke
`KisInputProfileMigrator` to migrate the entries and because it will
change how you want to carry out migration, it is an abstract class.

   a. Currently we invoke `KisInputProfileMigrator5To6`, which
   handles the migration where we have need to import only the new
   touch shortcuts.

4. Once we've migrated, we copy the old file to same directory with
version number suffix added to the filename -- this old file is what
will be loaded by the old version of Krita if it ever is opened.

5. That's all, at this point we can save the new profile at the location
where the old version was.
Related: bug 455846
(cherry picked from commit cc8f304a7da266b909d70104ce0d9de7aee7f3b8)

M  +1-1krita/data/input/kritadefault.profile
M  +1-1krita/data/input/painttoolsaicompatible.profile
M  +1-1krita/data/input/photoshopcompatible.profile
M  +1-0libs/ui/CMakeLists.txt
A  +105  -0libs/ui/input/KisInputProfileMigrator.cpp [License:
LGPL(v2.0+)]
A  +65   -0libs/ui/input/KisInputProfileMigrator.h [License:
LGPL(v2.0+)]
M  +109  -53   libs/ui/input/kis_input_profile_manager.cpp
M  +7-0libs/ui/input/kis_input_profile_manager.h

https://invent.kde.org/graphics/krita/commit/6346889b7d9f7e7f988f48896af333204df9d306

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 457514] After installing krita 5.1.0 touch gestures won't function on wacom cintinq 24

[sh_zam]

https://bugs.kde.org/show_bug.cgi?id=457514

sh_zam  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/cc8f304a7
   ||da266b909d70104ce0d9de7aee7
   ||f3b8

--- Comment #10 from sh_zam  ---
Git commit cc8f304a7da266b909d70104ce0d9de7aee7f3b8 by Sharaf Zaman.
Committed on 09/08/2022 at 06:06.
Pushed by szaman into branch 'master'.

Make Krita's canvas input profile migrate-able from version 5 to 6

The porting (PROFILE_VERSION - 1) to PROFILE_VERSION works as something
like this, with entry point being loadProfile():

1. We fill two lists, `profileEntries`: one with profiles with profile version
being
PROFILE_VERSION, `profileEntriesToMigrate`: one with profiles with version
being (PROFILE_VERSION - 1).

2. We go through the list we want to migrate and check if there is a
corresponding version of it in `profileEntries` and that has to exist in
user-local directory (not in install location -- which is the profile
version we ship).

a. If there doesn't exist one, we migrate the profile entry. And
remove it from `profileEntriesToMigrate`.
b. If there exists one (which isn't in user-local), we don't
migrate.

3. Once we get what we have to migrate and what we don't. We invoke
`KisInputProfileMigrator` to migrate the entries and because it will
change how you want to carry out migration, it is an abstract class.

   a. Currently we invoke `KisInputProfileMigrator5To6`, which
   handles the migration where we have need to import only the new
   touch shortcuts.

4. Once we've migrated, we copy the old file to same directory with
version number suffix added to the filename -- this old file is what
will be loaded by the old version of Krita if it ever is opened.

5. That's all, at this point we can save the new profile at the location
where the old version was.
Related: bug 455846

M  +1-1krita/data/input/kritadefault.profile
M  +1-1krita/data/input/painttoolsaicompatible.profile
M  +1-1krita/data/input/photoshopcompatible.profile
M  +1-0libs/ui/CMakeLists.txt
A  +105  -0libs/ui/input/KisInputProfileMigrator.cpp [License:
LGPL(v2.0+)]
A  +65   -0libs/ui/input/KisInputProfileMigrator.h [License:
LGPL(v2.0+)]
M  +109  -53   libs/ui/input/kis_input_profile_manager.cpp
M  +7-0libs/ui/input/kis_input_profile_manager.h

https://invent.kde.org/graphics/krita/commit/cc8f304a7da266b909d70104ce0d9de7aee7f3b8

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 457514] After installing krita 5.1.0 touch gestures won't function on wacom cintinq 24

[Halla Rempt]

https://bugs.kde.org/show_bug.cgi?id=457514

Halla Rempt  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Halla Rempt  ---
The relevant merge request has been merged.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 457514] After installing krita 5.1.0 touch gestures won't function on wacom cintinq 24

[Brian Kramer]

https://bugs.kde.org/show_bug.cgi?id=457514

--- Comment #8 from Brian Kramer  ---
I may need to revert back to 5.0 version if that's the case because I spent too
much invested in presets and can't afford to focus on re-doing currently. I am
assuming that this bug is something that will be sorted out overall in the set
5.1 software in the near future.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 457514] After installing krita 5.1.0 touch gestures won't function on wacom cintinq 24

[sh_zam]

https://bugs.kde.org/show_bug.cgi?id=457514

--- Comment #7 from sh_zam  ---
In Krita, Navigate to Settings -> Configure Krita -> Canvas Input Settings ->
Restore Defaults.

Do note, this will reset the Canvas shortcuts if you’ve modified them.

“Brian Kramer”  writes:

> 
>
> — Comment #6 from Brian Kramer  —
> Thank you. I will review that however it seems a little above level of
> competence to execute. I’ll try to get some help (unless you can walk me
> through it). Otherwise I will most likely try to revert back to 5.0 version so
> I can work until I can focus on the fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 457514] After installing krita 5.1.0 touch gestures won't function on wacom cintinq 24

[Brian Kramer]

https://bugs.kde.org/show_bug.cgi?id=457514

--- Comment #6 from Brian Kramer  ---
Thank you. I will review that however it seems a little above level of
competence to execute. I'll try to get some help (unless you can walk me
through it). Otherwise I will most likely try to revert back to 5.0 version so
I can work until I can focus on the fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 457514] After installing krita 5.1.0 touch gestures won't function on wacom cintinq 24

[sh_zam]

https://bugs.kde.org/show_bug.cgi?id=457514

sh_zam  changed:

   What|Removed |Added

 CC||sh...@sdf.org

--- Comment #5 from sh_zam  ---
I'd suggest you to reset the canvas input settings. This is something which is
fixed, but is currently under review at:
https://invent.kde.org/graphics/krita/-/merge_requests/1525

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 457514] After installing krita 5.1.0 touch gestures won't function on wacom cintinq 24

[Brian Kramer]

https://bugs.kde.org/show_bug.cgi?id=457514

--- Comment #4 from Brian Kramer  ---
(In reply to Halla Rempt from comment #3)
> works for me...

I wish I could say the same. Going through every possible solution and still
the new krita won't allow me to use touch gestures. I have been a user
exclusively for two years and never had this kind of issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 457514] After installing krita 5.1.0 touch gestures won't function on wacom cintinq 24

[Halla Rempt]

https://bugs.kde.org/show_bug.cgi?id=457514

Halla Rempt  changed:

   What|Removed |Added

   Severity|critical|normal
 CC||ha...@valdyas.org

--- Comment #3 from Halla Rempt  ---
works for me...

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 457514] After installing krita 5.1.0 touch gestures won't function on wacom cintinq 24

[Brian Kramer]

https://bugs.kde.org/show_bug.cgi?id=457514

--- Comment #2 from Brian Kramer  ---
I have additionally re-downloaded/replaced to latest krita 5.1.0 again and the
result is still the same.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 457514] After installing krita 5.1.0 touch gestures won't function on wacom cintinq 24

[Brian Kramer]

https://bugs.kde.org/show_bug.cgi?id=457514

--- Comment #1 from Brian Kramer  ---
I have additionally re-downloaded/replaced to latest krita 5.1.0 again and the
result is still the same.

-- 
You are receiving this mail because:
You are watching all bug changes.