[krita] [Bug 459512] Opening a psd file which has fill layer will make krita unresponsive or crash. Having the psd in recent document will make krita to hang on startup
https://bugs.kde.org/show_bug.cgi?id=459512 Alvin Wong changed: What|Removed |Added CC||michaelknub...@gmail.com --- Comment #8 from Alvin Wong --- *** Bug 459971 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 459512] Opening a psd file which has fill layer will make krita unresponsive or crash. Having the psd in recent document will make krita to hang on startup
https://bugs.kde.org/show_bug.cgi?id=459512 Halla Rempt changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/759751d3e |hics/krita/commit/d52cf1977 |6af9c493f62b9377c1dd8101ff1 |648731ff67213fbaa88667829b2 |5fe8|14ec --- Comment #7 from Halla Rempt --- Git commit d52cf1977648731ff67213fbaa88667829b214ec by Halla Rempt. Committed on 23/09/2022 at 10:40. Pushed by rempt into branch 'master'. Revert "Use Krita's engine to load previews for PSD files" This reverts commit 48ca610ae89be95eb1db477379e54b37ab478ec2. This made Krita try to access resources in a background thread, which is not possible. M +1-4libs/ui/utils/KisFileIconCreator.cpp https://invent.kde.org/graphics/krita/commit/d52cf1977648731ff67213fbaa88667829b214ec -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 459512] Opening a psd file which has fill layer will make krita unresponsive or crash. Having the psd in recent document will make krita to hang on startup
https://bugs.kde.org/show_bug.cgi?id=459512 Halla Rempt changed: What|Removed |Added CC||tamtamy.tym...@gmail.com --- Comment #6 from Halla Rempt --- *** Bug 458561 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 459512] Opening a psd file which has fill layer will make krita unresponsive or crash. Having the psd in recent document will make krita to hang on startup
https://bugs.kde.org/show_bug.cgi?id=459512 --- Comment #5 from Halla Rempt --- Backtrace: (gdb) bt #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 #1 0x752a9859 in __GI_abort () at abort.c:79 #2 0x757590ab in QMessageLogger::fatal(char const*, ...) const () from /home/halla/dev/deps/lib/libQt5Core.so.5 #3 0x7696a184 in kis_assert_common (assertion=0x7fffc0baed98 "\260\210\v\264\377\177", file=0x7fffc0baeda0 "\002", line=24, throwException=, isIgnorable=) at /home/halla/dev/5.1/libs/global/kis_assert.cpp:89 #4 0x769703a5 in kis_safe_assert_recoverable ( assertion=assertion@entry=0x76b122e0 "QThread::currentThread() == (static_cast(QCoreApplication::instance()))->thread()", file=file@entry=0x76b12298 "/home/halla/dev/5.1/libs/resources/KisRequiredResourcesOperators.cpp", line=line@entry=24) at /home/halla/dev/5.1/libs/global/kis_assert.cpp:107 #5 0x76af7a81 in KisRequiredResourcesOperators::detail::assertInGuiThread () at /home/halla/dev/5.1/libs/resources/KisRequiredResourcesOperators.cpp:24 #6 0x76e2a023 in KisRequiredResourcesOperators::createLocalResourcesSnapshot ( object=0x7fffb400f3c0, globalResourcesInterface=...) at /home/halla/dev/5.1/libs/resources/KisRequiredResourcesOperators.h:53 #7 0x76e29801 in KisFilterConfiguration::createLocalResourcesSnapshot (this=, globalResourcesInterface=...) at /home/halla/dev/5.1/libs/image/filter/kis_filter_configuration.cc:160 #8 0x7fffc03966a1 in PSDLoader::decode (this=, io=...) at /home/halla/dev/5.1/plugins/impex/psd/psd_loader.cpp:338 #9 0x7fffc0398962 in PSDLoader::buildImage (this=this@entry=0x7fffc0baf4a0, io=...) at /home/halla/dev/5.1/plugins/impex/psd/psd_loader.cpp:432 #10 0x7fffc03928b9 in psdImport::convert (this=, document=0x7fffb40025e0, io=0x7fffc0baf510) at /home/halla/dev/5.1/plugins/impex/psd/psd_import.cc:29 #11 0x77c4c45c in KisImportExportManager::doImport (this=0x7fffb4005e80, location=..., filter=...) at /home/halla/dev/5.1/libs/ui/KisImportExportManager.cpp:668 #12 0x77c4dcaa in KisImportExportManager::convert (this=0x7fffb4005e80, direction=, location=..., realLocation=..., mimeType=..., showWarnings=, exportConfiguration=..., isAsync=, isAdvancedExporting=) at /home/halla/dev/5.1/libs/ui/KisImportExportManager.cpp:379 #13 0x77c4ea8b in KisImportExportManager::importDocument (this=this@entry=0x7fffb4005e80, location=..., mimeType=...) at /home/halla/dev/5.1/libs/global/kis_shared_ptr.h:206 #14 0x77c336c5 in KisDocument::openFile (this=0x7fffb40025e0) at /home/halla/dev/5.1/libs/ui/KisDocument.cpp:1870 #15 0x77c34139 in KisDocument::openPathInternal (this=0x7fffb40025e0, path=...) at /home/halla/dev/5.1/libs/ui/KisDocument.cpp:2410 #16 0x77c39779 in KisDocument::openPath (this=this@entry=0x7fffb40025e0, _path=..., flags=..., flags@entry=...) at /home/halla/dev/5.1/libs/ui/KisDocument.cpp:1806 #17 0x77b393d5 in KisFileIconCreator::createFileIcon (this=this@entry=0x7fffc0bafc98, path=..., icon=..., devicePixelRatioF=devicePixelRatioF@entry=1, iconSize=...) at /home/halla/dev/deps/include/QtCore/qflags.h:120 #18 0x77b3c6b2 in (anonymous namespace)::getFileIcon (gfip=...) at /home/halla/dev/5.1/libs/ui/utils/KisRecentFileIconCache.cpp:51 #19 0x77b3b165 in QtConcurrent::StoredFunctorCall1<(anonymous namespace)::IconFetchResult, (anonymous namespace)::IconFetchResult (*)((anonymous namespace)::GetFileIconParameters), (anonymous namespace)::GetFileIconParameters>::runFunctor (this=0x596b5ef0) at /home/halla/dev/deps/include/QtConcurrent/qtconcurrentstoredfunctioncall.h:422 #20 QtConcurrent::RunFunctionTask<(anonymous namespace)::IconFetchResult>::run (this=0x596b5ef0) at /home/halla/dev/deps/include/QtConcurrent/qtconcurrentrunbase.h:108 #21 0x757962c2 in ?? () from /home/halla/dev/deps/lib/libQt5Core.so.5 #22 0x75792d27 in ?? () from /home/halla/dev/deps/lib/libQt5Core.so.5 #23 0x74579609 in start_thread (arg=) at pthread_create.c:477 #24 0x753a6133 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 459512] Opening a psd file which has fill layer will make krita unresponsive or crash. Having the psd in recent document will make krita to hang on startup
https://bugs.kde.org/show_bug.cgi?id=459512 Halla Rempt changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/759751d3e ||6af9c493f62b9377c1dd8101ff1 ||5fe8 Status|CONFIRMED |RESOLVED --- Comment #4 from Halla Rempt --- Git commit 759751d3e6af9c493f62b9377c1dd8101ff15fe8 by Halla Rempt. Committed on 22/09/2022 at 08:35. Pushed by rempt into branch 'krita/5.1'. Revert "Use Krita's engine to load previews for PSD files" This reverts commit 48ca610ae89be95eb1db477379e54b37ab478ec2. This made Krita try to access resources in a background thread, which is not possible. (cherry picked from commit 034a3c5c01b356b3c9b0f9f9bf84469d4e328c4d) M +1-4libs/ui/utils/KisFileIconCreator.cpp https://invent.kde.org/graphics/krita/commit/759751d3e6af9c493f62b9377c1dd8101ff15fe8 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 459512] Opening a psd file which has fill layer will make krita unresponsive or crash. Having the psd in recent document will make krita to hang on startup
https://bugs.kde.org/show_bug.cgi?id=459512 --- Comment #3 from Halla Rempt --- Okay, this is due to commit 48ca610ae89be95eb1db477379e54b37ab478ec2 Author: Dmitry Kazakov , Tue Jul 19 16:04:21 2022 +0300 (9 weeks ago) Committer: Dmitry Kazakov , Tue Jul 19 16:04:41 2022 +0300 (9 weeks ago) Follows: v5.2.0-prealpha Branches: Use Krita's engine to load previews for PSD files It makes loading of preview for the complex file from bug 444844 reduce from 300 sec to 40 sec. BUG:456907 Because PSD files can contain references to resources, and the thumbnails are generated in a background thread, not the gui thread, and resources can only be accessed from the gui thread. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 459512] Opening a psd file which has fill layer will make krita unresponsive or crash. Having the psd in recent document will make krita to hang on startup
https://bugs.kde.org/show_bug.cgi?id=459512 Halla Rempt changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #2 from Halla Rempt --- Ah, no, I'm wrong. Krita can load the image fine, but the kimageformats framework which we use to load the thumbnails seems to crash. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 459512] Opening a psd file which has fill layer will make krita unresponsive or crash. Having the psd in recent document will make krita to hang on startup
https://bugs.kde.org/show_bug.cgi?id=459512 Halla Rempt changed: What|Removed |Added Keywords||triaged CC||ha...@valdyas.org --- Comment #1 from Halla Rempt --- I cannot reproduce a crash in current master or with the 5.1.1 appimage: the image from the original thread loads normally. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 459512] Opening a psd file which has fill layer will make krita unresponsive or crash. Having the psd in recent document will make krita to hang on startup
https://bugs.kde.org/show_bug.cgi?id=459512 Raghavendra kamath changed: What|Removed |Added Severity|normal |crash -- You are receiving this mail because: You are watching all bug changes.
