[krita] [Bug 462417] Krita Version 5.1.1 & 5.1.3 not reading in a psd file well and Krita version 4.4.5 reads it in fine

2022-12-23 Thread TG
https://bugs.kde.org/show_bug.cgi?id=462417

--- Comment #9 from TG  ---
(In reply to amyspark from comment #8)
> Git commit 0f826dd72121d873450f9e2b72e6df82c04169ea by L. E. Segovia.
> Committed on 23/12/2022 at 13:54.
> Pushed by lsegovia into branch 'krita/5.1'.
> 
> PSD: reimplement the PackBits decompressor
> 
> This commit reimplements the decompression routine in C++11 to enable
> proper bounds checking, logging, and skipping the unnecessary copies.
> 
> M  +44   -93   libs/psdutils/compression.cpp
> 
> https://invent.kde.org/graphics/krita/commit/
> 0f826dd72121d873450f9e2b72e6df82c04169ea

Not sure what all of the above comment means, but it sounds like the problem
was determined, a fix created and krita version 5.1 will not have this error. 
Thank you

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462417] Krita Version 5.1.1 & 5.1.3 not reading in a psd file well and Krita version 4.4.5 reads it in fine

2022-12-23 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462417

amyspark  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/5b48a3994 |hics/krita/commit/0f826dd72
   |c0161685cebad10db10c93669e1 |121d873450f9e2b72e6df82c041
   |6ca6|69ea

--- Comment #8 from amyspark  ---
Git commit 0f826dd72121d873450f9e2b72e6df82c04169ea by L. E. Segovia.
Committed on 23/12/2022 at 13:54.
Pushed by lsegovia into branch 'krita/5.1'.

PSD: reimplement the PackBits decompressor

This commit reimplements the decompression routine in C++11 to enable
proper bounds checking, logging, and skipping the unnecessary copies.

M  +44   -93   libs/psdutils/compression.cpp

https://invent.kde.org/graphics/krita/commit/0f826dd72121d873450f9e2b72e6df82c04169ea

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462417] Krita Version 5.1.1 & 5.1.3 not reading in a psd file well and Krita version 4.4.5 reads it in fine

2022-12-23 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462417

amyspark  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/5b48a3994
   ||c0161685cebad10db10c93669e1
   ||6ca6
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from amyspark  ---
Git commit 5b48a3994c0161685cebad10db10c93669e16ca6 by L. E. Segovia.
Committed on 23/12/2022 at 13:47.
Pushed by lsegovia into branch 'master'.

PSD: reimplement the PackBits decompressor

This commit reimplements the decompression routine in C++11 to enable
proper bounds checking, logging, and skipping the unnecessary copies.

M  +44   -93   libs/psdutils/compression.cpp

https://invent.kde.org/graphics/krita/commit/5b48a3994c0161685cebad10db10c93669e16ca6

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462417] Krita Version 5.1.1 & 5.1.3 not reading in a psd file well and Krita version 4.4.5 reads it in fine

2022-12-22 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462417

--- Comment #6 from amyspark  ---
The file you supplied does not comply with the PackBits compression scheme. In
v5, I ensured that whenever the decompression routine throws an error code, it
is acted upon by zeroing the relevant row, which is causing this bug.

The workaround is easy, but I'd like to confirm first why this is the case.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462417] Krita Version 5.1.1 & 5.1.3 not reading in a psd file well and Krita version 4.4.5 reads it in fine

2022-12-12 Thread TG
https://bugs.kde.org/show_bug.cgi?id=462417

--- Comment #5 from TG  ---
(In reply to amyspark from comment #4)
> Taking it, let's see what I can find.

Very good, thank you

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462417] Krita Version 5.1.1 & 5.1.3 not reading in a psd file well and Krita version 4.4.5 reads it in fine

2022-12-09 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462417

amyspark  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Assignee|krita-bugs-n...@kde.org |a...@amyspark.me
 Status|NEEDSINFO   |ASSIGNED
 Resolution|WAITINGFORINFO  |---
 CC||a...@amyspark.me

--- Comment #4 from amyspark  ---
Taking it, let's see what I can find.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462417] Krita Version 5.1.1 & 5.1.3 not reading in a psd file well and Krita version 4.4.5 reads it in fine

2022-12-09 Thread TG
https://bugs.kde.org/show_bug.cgi?id=462417

--- Comment #3 from TG  ---
Here is the  .psd file that causes the distorted image when imported using
Krita 5.1.1 or Krita 5.1.3
This file opens fine in Krita 4.something

If the .psd file is too large it can be accessed here
"https://drive.google.com/file/d/170JPio5Qg1XySaMIR6nJpXi3ow0aJ_b2/view?usp=sharing";

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462417] Krita Version 5.1.1 & 5.1.3 not reading in a psd file well and Krita version 4.4.5 reads it in fine

2022-12-08 Thread Halla Rempt
https://bugs.kde.org/show_bug.cgi?id=462417

Halla Rempt  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 CC||ha...@valdyas.org
 Status|REPORTED|NEEDSINFO

--- Comment #2 from Halla Rempt  ---
Could you please attach the original psd file instead of a screenshot?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462417] Krita Version 5.1.1 & 5.1.3 not reading in a psd file well and Krita version 4.4.5 reads it in fine

2022-11-30 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=462417

Nate Graham  changed:

   What|Removed |Added

   Keywords||regression
Product|kde |krita
   Assignee|unassigned-b...@kde.org |krita-bugs-n...@kde.org
Version|unspecified |5.1.1
  Component|general |General
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.