[krita] [Bug 462528] Sudden Crashing while Animating After Applying Transformation Mask

2023-07-06 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=462528

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/7ad9cc0
   ||f8574561c2cd6da346df4d65f5b
   ||4c21a8
 Status|CONFIRMED   |RESOLVED

--- Comment #16 from Dmitry Kazakov  ---
Git commit 7ad9cc0f8574561c2cd6da346df4d65f5b4c21a8 by Dmitry Kazakov.
Committed on 06/07/2023 at 09:03.
Pushed by dkazakov into branch 'master'.

Fix Krita trying to render too huge areas with transform masks

With animation curves it is too easy to set scaling to values like
x700, which would require rendering too huge areas. We should limit
this area like we do in need/changeRect functions.

M  +20   -0libs/image/kis_transform_mask.cpp

https://invent.kde.org/graphics/krita/-/commit/7ad9cc0f8574561c2cd6da346df4d65f5b4c21a8

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462528] Sudden Crashing while Animating After Applying Transformation Mask

2023-06-22 Thread YRH
https://bugs.kde.org/show_bug.cgi?id=462528

YRH  changed:

   What|Removed |Added

 CC||yavn.w...@gmail.com
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #15 from YRH  ---
I think I was able to reproduce this, but it's probably not a bug. As far as I
understand it, it's very easy to shoot yourself in the foot with the transform
mask. The bad behavior I got was huge memory consumption and unresponsiveness
due to transformation calculation. I'll attach a video below.

Repro:

1. Create a new document (big canvas and depth will likely make it worse).
2. Use the animation workspace
3. Scribble something on the canvas
4. Add a transform mask to the animated paint layer
5. Go to animation curves tab
6. Insert a control point, select Scale X or Y
7. Drag the point to a high value (e.g. Scale to 500%)
8. Open animation timeline and click on the paint layer
9. Start drawing again
10. Observe the memory usage go up
11. Keep drawing and using the UI, eventually the app will become unresponsive
when you try to switch the tabs.

The video: https://www.youtube.com/watch?v=PDrxC8snIXo
(may be still processing, it should be 4K eventually)

Not sure about the status, I'll move it to confirmed, but please adjust as
necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462528] Sudden Crashing while Animating After Applying Transformation Mask

2023-01-12 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=462528

--- Comment #14 from nextman...@gmail.com ---
Thank you. =)

On Thu, Jan 12, 2023 at 12:19 AM Bug Janitor Service <
bugzilla_nore...@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=462528
>
> Bug Janitor Service  changed:
>
>What|Removed |Added
>
> 
>  Resolution|WAITINGFORINFO  |---
>  Status|NEEDSINFO   |REPORTED
>
> --- Comment #13 from Bug Janitor Service  ---
> Thanks for your comment!
>
> Automatically switching the status of this bug to REPORTED so that the KDE
> team
> knows that the bug is ready to get confirmed.
>
> In the future you may also do this yourself when providing needed
> information.
>
> --
> You are receiving this mail because:
> You reported the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462528] Sudden Crashing while Animating After Applying Transformation Mask

2023-01-11 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=462528

Bug Janitor Service  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |REPORTED

--- Comment #13 from Bug Janitor Service  ---
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462528] Sudden Crashing while Animating After Applying Transformation Mask

2023-01-11 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=462528

--- Comment #12 from nextman...@gmail.com ---
I had the canvas for an animation set to Film 4:3K wide. I try to expand a
simple circle with a transformation mask. it commonly crashes.Maybe the
problem is that I had the canvas too big?

On Wed, Jan 11, 2023 at 4:15 PM wolthera  wrote:

> https://bugs.kde.org/show_bug.cgi?id=462528
>
> wolthera  changed:
>
>What|Removed |Added
>
> 
>  Status|REPORTED|NEEDSINFO
>  Resolution|--- |WAITINGFORINFO
>  CC||griffinval...@gmail.com
>
> --- Comment #11 from wolthera  ---
> I'm setting this back to needsinfo because we're still waiting for the
> precise
> steps that cause this crash.
>
> --
> You are receiving this mail because:
> You reported the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462528] Sudden Crashing while Animating After Applying Transformation Mask

2023-01-11 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=462528

wolthera  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||griffinval...@gmail.com

--- Comment #11 from wolthera  ---
I'm setting this back to needsinfo because we're still waiting for the precise
steps that cause this crash.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462528] Sudden Crashing while Animating After Applying Transformation Mask

2023-01-04 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=462528

Bug Janitor Service  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Status|NEEDSINFO   |REPORTED

--- Comment #10 from Bug Janitor Service  ---
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462528] Sudden Crashing while Animating After Applying Transformation Mask

2023-01-04 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=462528

--- Comment #9 from nextman...@gmail.com ---
Yes, I can do that. =)

On Wed, Jan 4, 2023 at 6:32 PM Emmet O'Neill 
wrote:

> https://bugs.kde.org/show_bug.cgi?id=462528
>
> Emmet O'Neill  changed:
>
>What|Removed |Added
>
> 
>  Status|REPORTED|NEEDSINFO
>  Resolution|--- |WORKSFORME
>  CC||emmetoneill@gmail.com
>
> --- Comment #8 from Emmet O'Neill  ---
> I'm also not able to reproduce any crash using animated transform masks
> with
> the attached Krita document.
>
> Is this a crash that you're able to consistently reproduce, nextman?
> If so, it might help us if you could list out the specific steps that you
> take
> just before the crash happens.
>
> Because Halla and I can't reproduce the crash with the information
> available,
> I'll be setting this bug to "needs info".
> But if this is something that is still affecting you then we can reopen
> the bug
> report and work together to figure out exactly what we need to do to be
> able to
> consistently reproduce it.
>
> --
> You are receiving this mail because:
> You reported the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462528] Sudden Crashing while Animating After Applying Transformation Mask

2023-01-04 Thread Emmet O'Neill
https://bugs.kde.org/show_bug.cgi?id=462528

Emmet O'Neill  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WORKSFORME
 CC||emmetoneill@gmail.com

--- Comment #8 from Emmet O'Neill  ---
I'm also not able to reproduce any crash using animated transform masks with
the attached Krita document.

Is this a crash that you're able to consistently reproduce, nextman?
If so, it might help us if you could list out the specific steps that you take
just before the crash happens.

Because Halla and I can't reproduce the crash with the information available,
I'll be setting this bug to "needs info".
But if this is something that is still affecting you then we can reopen the bug
report and work together to figure out exactly what we need to do to be able to
consistently reproduce it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462528] Sudden Crashing while Animating After Applying Transformation Mask

2022-12-09 Thread Halla Rempt
https://bugs.kde.org/show_bug.cgi?id=462528

--- Comment #7 from Halla Rempt  ---
I don't know either -- if we cannot reproduce the bug, we cannot fix it, so for
the moment we're blocked.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462528] Sudden Crashing while Animating After Applying Transformation Mask

2022-12-09 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=462528

--- Comment #6 from nextman...@gmail.com ---
I'm having trouble understanding what exactly you'd need me to do.

On Friday, December 9, 2022, Halla Rempt  wrote:

> https://bugs.kde.org/show_bug.cgi?id=462528
>
> Halla Rempt  changed:
>
>What|Removed |Added
> 
> 
>Keywords||triaged
>
> --- Comment #5 from Halla Rempt  ---
> Sorry, but I cannot reproduce a crash with that file either :-(
>
> --
> You are receiving this mail because:
> You reported the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462528] Sudden Crashing while Animating After Applying Transformation Mask

2022-12-09 Thread Halla Rempt
https://bugs.kde.org/show_bug.cgi?id=462528

Halla Rempt  changed:

   What|Removed |Added

   Keywords||triaged

--- Comment #5 from Halla Rempt  ---
Sorry, but I cannot reproduce a crash with that file either :-(

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462528] Sudden Crashing while Animating After Applying Transformation Mask

2022-12-08 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=462528

Bug Janitor Service  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |REPORTED

--- Comment #4 from Bug Janitor Service  ---
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462528] Sudden Crashing while Animating After Applying Transformation Mask

2022-12-08 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=462528

--- Comment #3 from nextman...@gmail.com ---
On Thu, Dec 8, 2022 at 8:03 AM Halla Rempt  wrote:

> https://bugs.kde.org/show_bug.cgi?id=462528
>
> Halla Rempt  changed:
>
>What|Removed |Added
>
> 
>  Status|REPORTED|NEEDSINFO
>  Resolution|--- |WAITINGFORINFO
>  CC||ha...@valdyas.org
>
> --- Comment #1 from Halla Rempt  ---
> I cannot reproduce this. The crash log isn't useful in this case because it
> doesn't show where the actual crash happens. If you still have the original
> file from before the crash, could you make that available so we can test
> with
> it?
>
> --
> You are receiving this mail because:
> You reported the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462528] Sudden Crashing while Animating After Applying Transformation Mask

2022-12-08 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=462528

--- Comment #2 from nextman...@gmail.com ---
I can recreate what I was doing.

On Thu, Dec 8, 2022 at 8:03 AM Halla Rempt  wrote:

> https://bugs.kde.org/show_bug.cgi?id=462528
>
> Halla Rempt  changed:
>
>What|Removed |Added
>
> 
>  Status|REPORTED|NEEDSINFO
>  Resolution|--- |WAITINGFORINFO
>  CC||ha...@valdyas.org
>
> --- Comment #1 from Halla Rempt  ---
> I cannot reproduce this. The crash log isn't useful in this case because it
> doesn't show where the actual crash happens. If you still have the original
> file from before the crash, could you make that available so we can test
> with
> it?
>
> --
> You are receiving this mail because:
> You reported the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462528] Sudden Crashing while Animating After Applying Transformation Mask

2022-12-08 Thread Halla Rempt
https://bugs.kde.org/show_bug.cgi?id=462528

Halla Rempt  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||ha...@valdyas.org

--- Comment #1 from Halla Rempt  ---
I cannot reproduce this. The crash log isn't useful in this case because it
doesn't show where the actual crash happens. If you still have the original
file from before the crash, could you make that available so we can test with
it?

-- 
You are receiving this mail because:
You are watching all bug changes.