[krita] [Bug 472414] Crash when undoing the move tool on a keyframe (git bc41e49)

2023-08-23 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472414

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/f692df5 |hics/krita/-/commit/e71e835
   |615344bb367895a784d28c96fa8 |fe66d1db8bd442db842d7892e1e
   |cacb82  |19b204

--- Comment #8 from Dmitry Kazakov  ---
Git commit e71e835fe66d1db8bd442db842d7892e1e19b204 by Dmitry Kazakov.
Committed on 23/08/2023 at 14:03.
Pushed by dkazakov into branch 'krita/5.2'.

Don't recreate the frames when not necessary

This bug was an artifact of the lazy-frames refactoring. The frames should
not be recreated when they are actually the ones we transform.

M  +5-2libs/ui/tool/strokes/move_stroke_strategy.cpp

https://invent.kde.org/graphics/krita/-/commit/e71e835fe66d1db8bd442db842d7892e1e19b204

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472414] Crash when undoing the move tool on a keyframe (git bc41e49)

2023-08-23 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472414

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/f692df5
   ||615344bb367895a784d28c96fa8
   ||cacb82
 Status|ASSIGNED|RESOLVED

--- Comment #7 from Dmitry Kazakov  ---
Git commit f692df5615344bb367895a784d28c96fa8cacb82 by Dmitry Kazakov.
Committed on 23/08/2023 at 14:00.
Pushed by dkazakov into branch 'master'.

Don't recreate the frames when not necessary

This bug was an artifact of the lazy-frames refactoring. The frames should
not be recreated when they are actually the ones we transform.

M  +5-2libs/ui/tool/strokes/move_stroke_strategy.cpp

https://invent.kde.org/graphics/krita/-/commit/f692df5615344bb367895a784d28c96fa8cacb82

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472414] Crash when undoing the move tool on a keyframe (git bc41e49)

2023-08-23 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472414

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
   Keywords||release_blocker
 Ever confirmed|0   |1

--- Comment #6 from Dmitry Kazakov  ---
Hi, Cade!

Thank you for your info! I seem to be able to reproduce the issue now...

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472414] Crash when undoing the move tool on a keyframe (git bc41e49)

2023-08-22 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472414

Dmitry Kazakov  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472414] Crash when undoing the move tool on a keyframe (git bc41e49)

2023-07-21 Thread Cade Martinez
https://bugs.kde.org/show_bug.cgi?id=472414

--- Comment #5 from Cade Martinez  ---
Just now I had another user confirm this with Krita 5.1.5 on Windows and Mac
OS, in case it was only my machine.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472414] Crash when undoing the move tool on a keyframe (git bc41e49)

2023-07-21 Thread Cade Martinez
https://bugs.kde.org/show_bug.cgi?id=472414

--- Comment #4 from Cade Martinez  ---
(In reply to Dmitry Kazakov from comment #3)
> I cannot reproduce the bug on Linux. Perhaps it is something
> windows-specific...

After reading this, I tried and successfully reproduced the bug on the
following Linux VMs:
- Ubuntu 20.04 VM with Krita 5.1.5 installed from snap
- Linux Mint 21.2 VM with Krita 5.2.0-prealpha (git 449aeb5) AppImage
downloaded from the website

Here is a snippet of the gdb output after the AppImage crashed on Linux Mint:
"
  Thread 19 "Thread (pooled)" received signal SIGSEGV, Segmentation fault.
  [Switching to Thread 0x7fffdd3ed640 (LWP 2617)]
  0x771ee1c4 in ?? () from
/tmp/.mount_krita-qNfEoX/usr/bin/../lib/libkritaimage.so.19
  (gdb) bt
  #0  0x771ee1c4 in ?? () from
/tmp/.mount_krita-qNfEoX/usr/bin/../lib/libkritaimage.so.19
  #1  0x772249c5 in KisTransactionData::undo() () from
/tmp/.mount_krita-qNfEoX/usr/bin/../lib/libkritaimage.so.19
  #2  0x745211d2 in KUndo2Command::undo() () from
/tmp/.mount_krita-qNfEoX/usr/bin/../lib/libkritacommand.so.19
  #3  0x7711e663 in
KisStrokeStrategyUndoCommandBased::doStrokeCallback(KisStrokeJobData*) () from
/tmp/.mount_krita-qNfEoX/usr/bin/../lib/libkritaimage.so.19
"

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472414] Crash when undoing the move tool on a keyframe (git bc41e49)

2023-07-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472414

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #3 from Dmitry Kazakov  ---
I cannot reproduce the bug on Linux. Perhaps it is something
windows-specific...

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472414] Crash when undoing the move tool on a keyframe (git bc41e49)

2023-07-19 Thread Cade Martinez
https://bugs.kde.org/show_bug.cgi?id=472414

--- Comment #2 from Cade Martinez  ---
Created attachment 160402
  --> https://bugs.kde.org/attachment.cgi?id=160402=edit
Video demonstration of steps to reproduce

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472414] Crash when undoing the move tool on a keyframe (git bc41e49)

2023-07-19 Thread Cade Martinez
https://bugs.kde.org/show_bug.cgi?id=472414

--- Comment #1 from Cade Martinez  ---
Created attachment 160401
  --> https://bugs.kde.org/attachment.cgi?id=160401=edit
Crash log

-- 
You are receiving this mail because:
You are watching all bug changes.