[krita] [Bug 473429] New start screen in 5.2 Beta adds extra steps to docker plugins that create a new project
https://bugs.kde.org/show_bug.cgi?id=473429 --- Comment #8 from Halla Rempt --- Git commit b982457181d151493a7bff7680257bbb57b802b1 by Halla Rempt. Committed on 23/10/2023 at 16:14. Pushed by rempt into branch 'krita/5.2'. Add a flag for dockers that should be shown on the welcome screen Dockers are meant to work on the currently open canvas, but over the years we have created several dockers that are supposed to be open if there's no canvas. Setting the property "ShowOnWelcomePage" on the dockwidget will override hiding that docker on the welcome page. (cherry picked from commit 10b59e95ceb2300a8f8b62e291e4ea58c51da59d) M +2-1libs/flake/KoDockFactoryBase.h M +6-6libs/ui/KisMainWindow.cpp M +2-2plugins/dockers/logdocker/LogDocker.cpp M +1-0 plugins/python/comics_project_management_tools/comics_project_manager_docker.py https://invent.kde.org/graphics/krita/-/commit/b982457181d151493a7bff7680257bbb57b802b1 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 473429] New start screen in 5.2 Beta adds extra steps to docker plugins that create a new project
https://bugs.kde.org/show_bug.cgi?id=473429 Halla Rempt changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/-/commit/10b59e9 |hics/krita/-/commit/b982457 |5ceb2300a8f8b62e291e4ea58c5 |181d151493a7bff7680257bbb57 |1da59d |b802b1 --- Comment #7 from Halla Rempt --- Git commit b982457181d151493a7bff7680257bbb57b802b1 by Halla Rempt. Committed on 23/10/2023 at 16:14. Pushed by rempt into branch 'krita/5.2'. Add a flag for dockers that should be shown on the welcome screen Dockers are meant to work on the currently open canvas, but over the years we have created several dockers that are supposed to be open if there's no canvas. Setting the property "ShowOnWelcomePage" on the dockwidget will override hiding that docker on the welcome page. (cherry picked from commit 10b59e95ceb2300a8f8b62e291e4ea58c51da59d) M +2-1libs/flake/KoDockFactoryBase.h M +6-6libs/ui/KisMainWindow.cpp M +2-2plugins/dockers/logdocker/LogDocker.cpp M +1-0 plugins/python/comics_project_management_tools/comics_project_manager_docker.py https://invent.kde.org/graphics/krita/-/commit/b982457181d151493a7bff7680257bbb57b802b1 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 473429] New start screen in 5.2 Beta adds extra steps to docker plugins that create a new project
https://bugs.kde.org/show_bug.cgi?id=473429 --- Comment #6 from Dmitry Kazakov --- Git commit 10b59e95ceb2300a8f8b62e291e4ea58c51da59d by Dmitry Kazakov, on behalf of Halla Rempt. Committed on 23/10/2023 at 12:12. Pushed by rempt into branch 'master'. Add a flag for dockers that should be shown on the welcome screen Dockers are meant to work on the currently open canvas, but over the years we have created several dockers that are supposed to be open if there's no canvas. Setting the property "ShowOnWelcomePage" on the dockwidget will override hiding that docker on the welcome page. M +2-1libs/flake/KoDockFactoryBase.h M +6-6libs/ui/KisMainWindow.cpp M +2-2plugins/dockers/logdocker/LogDocker.cpp M +1-0 plugins/python/comics_project_management_tools/comics_project_manager_docker.py https://invent.kde.org/graphics/krita/-/commit/10b59e95ceb2300a8f8b62e291e4ea58c51da59d -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 473429] New start screen in 5.2 Beta adds extra steps to docker plugins that create a new project
https://bugs.kde.org/show_bug.cgi?id=473429 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/-/commit/10b59e9 ||5ceb2300a8f8b62e291e4ea58c5 ||1da59d Status|ASSIGNED|RESOLVED --- Comment #5 from Dmitry Kazakov --- Git commit 10b59e95ceb2300a8f8b62e291e4ea58c51da59d by Dmitry Kazakov, on behalf of Halla Rempt. Committed on 23/10/2023 at 12:12. Pushed by rempt into branch 'master'. Add a flag for dockers that should be shown on the welcome screen Dockers are meant to work on the currently open canvas, but over the years we have created several dockers that are supposed to be open if there's no canvas. Setting the property "ShowOnWelcomePage" on the dockwidget will override hiding that docker on the welcome page. M +2-1libs/flake/KoDockFactoryBase.h M +6-6libs/ui/KisMainWindow.cpp M +2-2plugins/dockers/logdocker/LogDocker.cpp M +1-0 plugins/python/comics_project_management_tools/comics_project_manager_docker.py https://invent.kde.org/graphics/krita/-/commit/10b59e95ceb2300a8f8b62e291e4ea58c51da59d -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 473429] New start screen in 5.2 Beta adds extra steps to docker plugins that create a new project
https://bugs.kde.org/show_bug.cgi?id=473429 --- Comment #4 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1957 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 473429] New start screen in 5.2 Beta adds extra steps to docker plugins that create a new project
https://bugs.kde.org/show_bug.cgi?id=473429 Bug Janitor Service changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|ASSIGNED --- Comment #3 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1957 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 473429] New start screen in 5.2 Beta adds extra steps to docker plugins that create a new project
https://bugs.kde.org/show_bug.cgi?id=473429 Rebecca Breu changed: What|Removed |Added CC||rebe...@rbreu.de -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 473429] New start screen in 5.2 Beta adds extra steps to docker plugins that create a new project
https://bugs.kde.org/show_bug.cgi?id=473429 Dmitry Kazakov changed: What|Removed |Added CC||dimul...@gmail.com --- Comment #2 from Dmitry Kazakov --- We should probably add some custom property for a docker not to be hidden in the main screen... -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 473429] New start screen in 5.2 Beta adds extra steps to docker plugins that create a new project
https://bugs.kde.org/show_bug.cgi?id=473429
--- Comment #1 from varkatope ---
(In reply to varkatope from comment #0)
> Or a section on the
> start screen that is addressable from Python, where you can register a
> widget (even just a single button would be enough to launch a new project
> creation window). Or, something like Maya's custom "shelf" where you can pin
> scripts to it, which would be part of the standard UI and therefore
> persistent (like the new document, open existing document, save, etc.
> section at the top left). I dunno, I'm just spitballing now.
Well, I managed to add a new QToolBar and QToolButton to the main window from
within my docker plugin, which would do the trick, but that took some doing
because on first load, the qwindow() doesn't exist yet and will throw an error
unless you use a Notifier for windowCreated. Then I wanted to only have it
appear on the start screen since once the Docker is loaded I can just go from
there, but then if I started a few new projects I would end up with multiple
QToolButtons in the tool bar, so I had to start and stop Notifiers for
imageCreated and imageClosed to activate and deactivate the tool bar depending
on what was open or closed, which still isn't working quite right but at least
I only have one QToolButton at any one time, and it didn't look right so I had
to use addAction instead of addWidget and then
setStyleSheet('QToolBar{border:none}') and it finally looks OK, BUT THEN I
managed to insert a tool button into the "Start" area and that presented its
own set of challenges, plus it could break at any time if y'all decide to
rename 'verticalLayout_4', for example, but at least I don't have to mess with
the other Notifiers, so that's probably what I'm going to stick with for the
moment and hope it doesn't break in future versions...
My point is that it would be cool to have some sort of helper function in
Krita's API for plugin developers that would simplify adding either a tool bar
to the qwindow() or tool button to the welcome page now that there is one (or
both!), and to inherit the style of the existing UI by default (no border if
QToolBar, or setAutoRaise(True), QSize(48,48), setToolButtonStyle(3) if
QToolButton, that sort of thing), because I'm pretty "in the weeds" on the Qt
side at the moment and it stings a bit.
Sorry for the non-"bugreportyness" of this "bug report." Do with it what you
will.
--
You are receiving this mail because:
You are watching all bug changes.
