[krita] [Bug 473485] QAbstractItemModel::endInsertColumns: Invalid index
https://bugs.kde.org/show_bug.cgi?id=473485 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/-/commit/2157e5c |hics/krita/-/commit/de673fe |8a4d36c13f7b69be739f136639f |ee8f20079e54b51f7799d48e267 |aeb2ca |703035 --- Comment #6 from Dmitry Kazakov --- Git commit de673feee8f20079e54b51f7799d48e267703035 by Dmitry Kazakov. Committed on 23/08/2023 at 11:26. Pushed by dkazakov into branch 'krita/5.2'. Fix a model warning in KisTimeBasedItemModel There were two issues: 1) KisTimeBasedItemModel::columnCount() could return the value that has already changed in the image without calling to begin/endInsertColumns. That is not really welcome by Qt. 2) In KisTimeBasedItemModel::setImage() we reset the model (and therefore updated its columns list), but didn't update m_d->numFramesOverride, which caused double insertion of the columns in slotPlaybackRangeChanged() a bit later. M +2-1plugins/dockers/animation/KisTimeBasedItemModel.cpp https://invent.kde.org/graphics/krita/-/commit/de673feee8f20079e54b51f7799d48e267703035 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 473485] QAbstractItemModel::endInsertColumns: Invalid index
https://bugs.kde.org/show_bug.cgi?id=473485 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/-/commit/2157e5c ||8a4d36c13f7b69be739f136639f ||aeb2ca Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #5 from Dmitry Kazakov --- Git commit 2157e5c8a4d36c13f7b69be739f136639faeb2ca by Dmitry Kazakov. Committed on 23/08/2023 at 11:24. Pushed by dkazakov into branch 'master'. Fix a model warning in KisTimeBasedItemModel There were two issues: 1) KisTimeBasedItemModel::columnCount() could return the value that has already changed in the image without calling to begin/endInsertColumns. That is not really welcome by Qt. 2) In KisTimeBasedItemModel::setImage() we reset the model (and therefore updated its columns list), but didn't update m_d->numFramesOverride, which caused double insertion of the columns in slotPlaybackRangeChanged() a bit later. M +2-1plugins/dockers/animation/KisTimeBasedItemModel.cpp https://invent.kde.org/graphics/krita/-/commit/2157e5c8a4d36c13f7b69be739f136639faeb2ca -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 473485] QAbstractItemModel::endInsertColumns: Invalid index
https://bugs.kde.org/show_bug.cgi?id=473485 Dmitry Kazakov changed: What|Removed |Added CC||dimul...@gmail.com Keywords||regression, release_blocker -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 473485] QAbstractItemModel::endInsertColumns: Invalid index
https://bugs.kde.org/show_bug.cgi?id=473485 --- Comment #4 from grum...@grum.fr --- Ah thanks! Didn't saw the bug 473282 as I didn't searched in resolved... :-/ -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 473485] QAbstractItemModel::endInsertColumns: Invalid index
https://bugs.kde.org/show_bug.cgi?id=473485 Freya Lupen changed: What|Removed |Added CC||al...@alvinhc.com --- Comment #3 from Freya Lupen --- *** Bug 473282 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 473485] QAbstractItemModel::endInsertColumns: Invalid index
https://bugs.kde.org/show_bug.cgi?id=473485 Emmet O'Neill changed: What|Removed |Added Status|REPORTED|ASSIGNED Ever confirmed|0 |1 --- Comment #2 from Emmet O'Neill --- Yep, you're right. I'm not sure why this is happening yet, but it'll be on my list of things to look into next week. Thanks for the report as always grum! -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 473485] QAbstractItemModel::endInsertColumns: Invalid index
https://bugs.kde.org/show_bug.cgi?id=473485 Emmet O'Neill changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |emmetoneill@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 473485] QAbstractItemModel::endInsertColumns: Invalid index
https://bugs.kde.org/show_bug.cgi?id=473485 Emmet O'Neill changed: What|Removed |Added CC||emmetoneill@gmail.com Component|General |Animation -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 473485] QAbstractItemModel::endInsertColumns: Invalid index
https://bugs.kde.org/show_bug.cgi?id=473485 --- Comment #1 from grum...@grum.fr --- Opening an animation file with 75 frames (0 to 74) generate a different message :) ``` QAbstractItemModel::endInsertColumns: Invalid index ( 1 , 75 ) in model KisAnimTimelineFramesModel(0x55f8e4ef8380) ``` -- You are receiving this mail because: You are watching all bug changes.
