[krita] [Bug 476076] Masked brushes use pen pressure, even if pen pressure is disabled in the brush
https://bugs.kde.org/show_bug.cgi?id=476076 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/-/commit/8116181 |hics/krita/-/commit/f49342b |4ad4f646ae8c456a349128751d8 |c1cc2bc968ae5b1176583716713 |e0b825 |aa6359 --- Comment #12 from Dmitry Kazakov --- Git commit f49342bc1cc2bc968ae5b1176583716713aa6359 by Dmitry Kazakov. Committed on 03/11/2023 at 17:49. Pushed by dkazakov into branch 'krita/5.2'. Disable checkability of Opacity and Flow options for Masked Brushes They were uncheckable before Krita 5.2.0, so we should keep them this way. That is a proper fix for the incorrect fix for bug 476076. Related: bug 476505 M +1-1 plugins/paintops/defaultpaintops/brush/kis_brushop_settings_widget.cpp M +2-2plugins/paintops/libpaintop/KisStandardOptionData.h https://invent.kde.org/graphics/krita/-/commit/f49342bc1cc2bc968ae5b1176583716713aa6359 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 476076] Masked brushes use pen pressure, even if pen pressure is disabled in the brush
https://bugs.kde.org/show_bug.cgi?id=476076 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/-/commit/77bc720 |hics/krita/-/commit/8116181 |926bf9d1255ca98a6f6b7309f8f |4ad4f646ae8c456a349128751d8 |acd3ef |e0b825 --- Comment #11 from Dmitry Kazakov --- Git commit 81161814ad4f646ae8c456a349128751d8e0b825 by Dmitry Kazakov. Committed on 03/11/2023 at 17:49. Pushed by dkazakov into branch 'master'. Disable checkability of Opacity and Flow options for Masked Brushes They were uncheckable before Krita 5.2.0, so we should keep them this way. That is a proper fix for the incorrect fix for bug 476076. Related: bug 476505 M +1-1 plugins/paintops/defaultpaintops/brush/kis_brushop_settings_widget.cpp M +2-2plugins/paintops/libpaintop/KisStandardOptionData.h https://invent.kde.org/graphics/krita/-/commit/81161814ad4f646ae8c456a349128751d8e0b825 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 476076] Masked brushes use pen pressure, even if pen pressure is disabled in the brush
https://bugs.kde.org/show_bug.cgi?id=476076 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/-/commit/5aeaa07 |hics/krita/-/commit/77bc720 |087147084ab8b8d361c24266b4a |926bf9d1255ca98a6f6b7309f8f |ad290b |acd3ef --- Comment #10 from Dmitry Kazakov --- Git commit 77bc720926bf9d1255ca98a6f6b7309f8facd3ef by Dmitry Kazakov. Committed on 29/10/2023 at 15:09. Pushed by dkazakov into branch 'krita/5.2'. Fix initialization of "Checked" and "Checkable" values for masked brush options Basically, we now automatically deduce Checkable value depending on the presence of the prefix for the option. M +17 -0libs/image/kis_properties_configuration.cc M +7-0libs/image/kis_properties_configuration.h M +2-2plugins/paintops/colorsmudge/KisSmudgeRadiusOptionData.cpp M +6-4plugins/paintops/curvebrush/KisCurveStandardOptionData.h M +1-1 plugins/paintops/defaultpaintops/brush/kis_brushop_settings_widget.cpp M +5-11 plugins/paintops/hatching/KisHatchingStandardOptionData.h M +13 -14 plugins/paintops/libpaintop/KisCurveOptionData.cpp M +13 -8plugins/paintops/libpaintop/KisCurveOptionData.h M +3-2plugins/paintops/libpaintop/KisFlowOpacityOption.cpp M +0-1plugins/paintops/libpaintop/KisFlowOpacityOption.h M +11 -0plugins/paintops/libpaintop/KisKritaSensorPack.cpp M +17 -2plugins/paintops/libpaintop/KisKritaSensorPack.h M +3-1plugins/paintops/libpaintop/KisScatterOptionData.cpp M +3-5plugins/paintops/libpaintop/KisSizeOptionData.cpp M +1-1plugins/paintops/libpaintop/KisSizeOptionData.h M +5-5plugins/paintops/libpaintop/KisStandardOptionData.cpp M +6-7plugins/paintops/libpaintop/KisStandardOptionData.h M +3-9plugins/paintops/sketch/KisSketchStandardOptionData.h https://invent.kde.org/graphics/krita/-/commit/77bc720926bf9d1255ca98a6f6b7309f8facd3ef -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 476076] Masked brushes use pen pressure, even if pen pressure is disabled in the brush
https://bugs.kde.org/show_bug.cgi?id=476076 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/-/commit/5aeaa07 ||087147084ab8b8d361c24266b4a ||ad290b Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #9 from Dmitry Kazakov --- Git commit 5aeaa07087147084ab8b8d361c24266b4aad290b by Dmitry Kazakov. Committed on 29/10/2023 at 15:07. Pushed by dkazakov into branch 'master'. Fix initialization of "Checked" and "Checkable" values for masked brush options Basically, we now automatically deduce Checkable value depending on the presence of the prefix for the option. M +17 -0libs/image/kis_properties_configuration.cc M +7-0libs/image/kis_properties_configuration.h M +2-2plugins/paintops/colorsmudge/KisSmudgeRadiusOptionData.cpp M +6-4plugins/paintops/curvebrush/KisCurveStandardOptionData.h M +1-1 plugins/paintops/defaultpaintops/brush/kis_brushop_settings_widget.cpp M +5-11 plugins/paintops/hatching/KisHatchingStandardOptionData.h M +13 -14 plugins/paintops/libpaintop/KisCurveOptionData.cpp M +13 -8plugins/paintops/libpaintop/KisCurveOptionData.h M +3-2plugins/paintops/libpaintop/KisFlowOpacityOption.cpp M +0-1plugins/paintops/libpaintop/KisFlowOpacityOption.h M +11 -0plugins/paintops/libpaintop/KisKritaSensorPack.cpp M +17 -2plugins/paintops/libpaintop/KisKritaSensorPack.h M +3-1plugins/paintops/libpaintop/KisScatterOptionData.cpp M +3-5plugins/paintops/libpaintop/KisSizeOptionData.cpp M +1-1plugins/paintops/libpaintop/KisSizeOptionData.h M +5-5plugins/paintops/libpaintop/KisStandardOptionData.cpp M +6-7plugins/paintops/libpaintop/KisStandardOptionData.h M +3-9plugins/paintops/sketch/KisSketchStandardOptionData.h https://invent.kde.org/graphics/krita/-/commit/5aeaa07087147084ab8b8d361c24266b4aad290b -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 476076] Masked brushes use pen pressure, even if pen pressure is disabled in the brush
https://bugs.kde.org/show_bug.cgi?id=476076 Dmitry Kazakov changed: What|Removed |Added CC||acc4commissi...@gmail.com --- Comment #8 from Dmitry Kazakov --- *** Bug 475591 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 476076] Masked brushes use pen pressure, even if pen pressure is disabled in the brush
https://bugs.kde.org/show_bug.cgi?id=476076 Dmitry Kazakov changed: What|Removed |Added Keywords||release_blocker -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 476076] Masked brushes use pen pressure, even if pen pressure is disabled in the brush
https://bugs.kde.org/show_bug.cgi?id=476076 --- Comment #7 from Dmitry Kazakov --- I think I can reproduce this issue... -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 476076] Masked brushes use pen pressure, even if pen pressure is disabled in the brush
https://bugs.kde.org/show_bug.cgi?id=476076 --- Comment #6 from Flo Tasser --- All good. Thank you. :) And thanks for asking better questions than I did, never easy to communicate these things well. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 476076] Masked brushes use pen pressure, even if pen pressure is disabled in the brush
https://bugs.kde.org/show_bug.cgi?id=476076 David REVOY changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #5 from David REVOY --- > I'll switch your bug report as "reported" Correction: I meant 'confirmed' , I'll switch it. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 476076] Masked brushes use pen pressure, even if pen pressure is disabled in the brush
https://bugs.kde.org/show_bug.cgi?id=476076 David REVOY changed: What|Removed |Added Status|NEEDSINFO |REPORTED Resolution|WAITINGFORINFO |--- --- Comment #4 from David REVOY --- I see, thank you for the "gif of the behavior" in attachement. It really shows the issue at works. I'll switch your bug report as "reported" because I can reproduce. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 476076] Masked brushes use pen pressure, even if pen pressure is disabled in the brush
https://bugs.kde.org/show_bug.cgi?id=476076 --- Comment #3 from Flo Tasser --- Created attachment 162559 --> https://bugs.kde.org/attachment.cgi?id=162559=edit gif of the behaviour -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 476076] Masked brushes use pen pressure, even if pen pressure is disabled in the brush
https://bugs.kde.org/show_bug.cgi?id=476076 --- Comment #2 from Flo Tasser --- (In reply to David REVOY from comment #1) > Hi, it might be a good idea to write here in the report the name of the > brush-tip, if you can. > > I ask that, because some *.gih brush tips (Gimp animated brush tip) can map > mulitple brush mask to pressure, rotation, or drawing angle. And Krita will > honor that before any built-in curve based sensor. So, it might be the case > with your brush tip. > > For more info about gih brushes: > https://docs.krita.org/en/general_concepts/file_formats/file_gih.html#file- > gih > https://docs.gimp.org/2.8/en/gimp-using-animated-brushes.html Thank you for the idea David. Didn't think of that. But it was a custom brush tip in this example, generally it happens with other brushtips, too. They were all single images, not a .gih Tested with some random animated bruth tips, same result. It seems as if opacity and flow of the mask brush have nothing to do with the toggles. Will try to record a short video. I'll append another screengrab, this time as a gif. Hope it makes sense. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 476076] Masked brushes use pen pressure, even if pen pressure is disabled in the brush
https://bugs.kde.org/show_bug.cgi?id=476076 David REVOY changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution|--- |WAITINGFORINFO CC||i...@davidrevoy.com --- Comment #1 from David REVOY --- Hi, it might be a good idea to write here in the report the name of the brush-tip, if you can. I ask that, because some *.gih brush tips (Gimp animated brush tip) can map mulitple brush mask to pressure, rotation, or drawing angle. And Krita will honor that before any built-in curve based sensor. So, it might be the case with your brush tip. For more info about gih brushes: https://docs.krita.org/en/general_concepts/file_formats/file_gih.html#file-gih https://docs.gimp.org/2.8/en/gimp-using-animated-brushes.html -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 476076] Masked brushes use pen pressure, even if pen pressure is disabled in the brush
https://bugs.kde.org/show_bug.cgi?id=476076 Dmitry Kazakov changed: What|Removed |Added CC||dimul...@gmail.com Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
