[krita] [Bug 476511] Inconsistent undo and redo after flattening a layer

2023-11-05 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=476511

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/5537f00 |hics/krita/-/commit/7eb718c
   |ef0973e2887eee31143ec3aa67e |2543ab120487e1916c6f8d01157
   |3b7e19  |ca02f3

--- Comment #9 from Dmitry Kazakov  ---
Git commit 7eb718c2543ab120487e1916c6f8d01157ca02f3 by Dmitry Kazakov.
Committed on 05/11/2023 at 14:09.
Pushed by dkazakov into branch 'krita/5.2'.

Fix redo of a flatten layer operation when it is animated

KisKeyFrameChannel already wraps the command into SkipFirstRedoWrapper,
so there is no need for another one.

This is a regression from 933c1fa041d97a23701e709eec8a9417f9a26fec

M  +3-3libs/image/kis_layer_utils.cpp

https://invent.kde.org/graphics/krita/-/commit/7eb718c2543ab120487e1916c6f8d01157ca02f3

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 476511] Inconsistent undo and redo after flattening a layer

2023-11-05 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=476511

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/5537f00
   ||ef0973e2887eee31143ec3aa67e
   ||3b7e19

--- Comment #8 from Dmitry Kazakov  ---
Git commit 5537f00ef0973e2887eee31143ec3aa67e3b7e19 by Dmitry Kazakov.
Committed on 05/11/2023 at 14:08.
Pushed by dkazakov into branch 'master'.

Fix redo of a flatten layer operation when it is animated

KisKeyFrameChannel already wraps the command into SkipFirstRedoWrapper,
so there is no need for another one.

This is a regression from 933c1fa041d97a23701e709eec8a9417f9a26fec

M  +3-3libs/image/kis_layer_utils.cpp

https://invent.kde.org/graphics/krita/-/commit/5537f00ef0973e2887eee31143ec3aa67e3b7e19

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 476511] Inconsistent undo and redo after flattening a layer

2023-11-05 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=476511

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

--- Comment #7 from Dmitry Kazakov  ---
Hi, paleh!

Thank you for the video! I can reproduce the issue now! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 476511] Inconsistent undo and redo after flattening a layer

2023-11-03 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=476511

Bug Janitor Service  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

--- Comment #6 from Bug Janitor Service  ---
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 476511] Inconsistent undo and redo after flattening a layer

2023-11-03 Thread paleh
https://bugs.kde.org/show_bug.cgi?id=476511

--- Comment #5 from paleh  ---
Created attachment 162846
  --> https://bugs.kde.org/attachment.cgi?id=162846=edit
screen recording of the bug on 5.2.1-f819e29

No, nothing changed with the stable windows build #2035. I recorded a video to
demonstrate it. Since it was only a Windows build that you restarted, and
because I don't currently have a windows VM, I tested it in Wine, but the
result is the same is the same for the stable appimage build #2040.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 476511] Inconsistent undo and redo after flattening a layer

2023-11-03 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=476511

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REOPENED|NEEDSINFO

--- Comment #4 from Dmitry Kazakov  ---
Hi, paleh!

I have restarted the build. Could you try this one when it is ready?

https://binary-factory.kde.org/job/Krita_Stable_Windows_Build/2035/

It might be related to the race condition I fixed for another report of yours
:)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 476511] Inconsistent undo and redo after flattening a layer

2023-11-03 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=476511

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1
 Resolution|DUPLICATE   |---

--- Comment #3 from Dmitry Kazakov  ---
Well, that is the same build. I'll recheck then

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 476511] Inconsistent undo and redo after flattening a layer

2023-11-03 Thread paleh
https://bugs.kde.org/show_bug.cgi?id=476511

--- Comment #2 from paleh  ---
Hi, Dmitry

Err, which build is it? I can reproduce the bug on 5.2.1-8a2e4c8b0e which you
pushed today (at 12:01pm CET) in response to my other bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 476511] Inconsistent undo and redo after flattening a layer

2023-11-03 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=476511

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #1 from Dmitry Kazakov  ---
Hi, paleh!

Thank you for the report! The bug seems to be fixed by the patch I pushed in
the morning!

Please try this build:
https://binary-factory.kde.org/job/Krita_Stable_Windows_Build/2034/

*** This bug has been marked as a duplicate of bug 476495 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 476511] Inconsistent undo and redo after flattening a layer

2023-11-03 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=476511

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.