[krunner] [Bug 459859] KRunner erroneously executes command when user is deleting input
https://bugs.kde.org/show_bug.cgi?id=459859 Nate Graham changed: What|Removed |Added Version Fixed In||5.27.2 -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 459859] KRunner erroneously executes command when user is deleting input
https://bugs.kde.org/show_bug.cgi?id=459859 Alexander Lohnau changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/milou/commit/717164ca13f |ma/milou/commit/2d5f08e955c |be3ff9f738964a9efbecdc0814e |1bca2ab53f41769d705f1c2e800 |40 |e2 --- Comment #10 from Alexander Lohnau --- Git commit 2d5f08e955c1bca2ab53f41769d705f1c2e800e2 by Alexander Lohnau. Committed on 21/02/2023 at 16:45. Pushed by alex into branch 'Plasma/5.27'. Do not run match automatically when query string changed (cherry picked from commit 717164ca13fbe3ff9f738964a9efbecdc0814e40) M +6-1lib/qml/ResultsView.qml https://invent.kde.org/plasma/milou/commit/2d5f08e955c1bca2ab53f41769d705f1c2e800e2 -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 459859] KRunner erroneously executes command when user is deleting input
https://bugs.kde.org/show_bug.cgi?id=459859 Alexander Lohnau changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/plas ||ma/milou/commit/717164ca13f ||be3ff9f738964a9efbecdc0814e ||40 Resolution|--- |FIXED --- Comment #9 from Alexander Lohnau --- Git commit 717164ca13fbe3ff9f738964a9efbecdc0814e40 by Alexander Lohnau. Committed on 20/02/2023 at 12:46. Pushed by alex into branch 'master'. Do not run match automatically when query string changed M +6-1lib/qml/ResultsView.qml https://invent.kde.org/plasma/milou/commit/717164ca13fbe3ff9f738964a9efbecdc0814e40 -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 459859] KRunner erroneously executes command when user is deleting input
https://bugs.kde.org/show_bug.cgi?id=459859 --- Comment #8 from David Korth --- (In reply to Bug Janitor Service from comment #6) > A possibly relevant merge request was started @ > https://invent.kde.org/plasma/milou/-/merge_requests/52 Can confirm that this patch fixes the issue for me. -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 459859] KRunner erroneously executes command when user is deleting input
https://bugs.kde.org/show_bug.cgi?id=459859 --- Comment #7 from Alexander Lohnau --- @David Korth That code is only relevant for the history, like having an empty query and pressing the arrow-down key in KRunner. But I was quite confused by that too when I started working with KRunner :) -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 459859] KRunner erroneously executes command when user is deleting input
https://bugs.kde.org/show_bug.cgi?id=459859 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #6 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/milou/-/merge_requests/52 -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 459859] KRunner erroneously executes command when user is deleting input
https://bugs.kde.org/show_bug.cgi?id=459859 Alexander Lohnau changed: What|Removed |Added Assignee|plasma-b...@kde.org |alexander.loh...@gmx.de -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 459859] KRunner erroneously executes command when user is deleting input
https://bugs.kde.org/show_bug.cgi?id=459859
David Korth changed:
What|Removed |Added
CC||gerbils...@gerbilsoft.com
--- Comment #5 from David Korth ---
Can still reproduce in 5.27.0.
In RunCommand.qml:
function runCurrentIndex(event) {
var entry = runnerManager.history[currentIndex]
if (entry) {
// If user presses Shift+Return to invoke an action, invoke the first
runner action
if (event && event.modifiers === Qt.ShiftModifier
&& currentItem.additionalActions &&
currentItem.additionalActions.length > 0) {
runAction(0);
return
}
queryField.text = entry
queryField.forceActiveFocus();
}
}
I'm not able to debug this myself (no experience with QML), but it seems like
the access to runnerManager.history[] might be blocking until something's
present in the list?
--
You are receiving this mail because:
You are watching all bug changes.
[krunner] [Bug 459859] KRunner erroneously executes command when user is deleting input
https://bugs.kde.org/show_bug.cgi?id=459859 Nate Graham changed: What|Removed |Added Status|REPORTED|CONFIRMED CC||n...@kde.org Severity|normal |major Ever confirmed|0 |1 --- Comment #4 from Nate Graham --- Whoa, can reproduce. This seems bad. -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 459859] KRunner erroneously executes command when user is deleting input
https://bugs.kde.org/show_bug.cgi?id=459859
--- Comment #3 from phd ---
What is more, you can close the KRunner window and then the bug will still
trigger once you open KRunner again, even after a long time.
And the bug will (obviously) trigger also when you *paste* the new content into
the input field.
The above scenario might be a security/data-loss issue, because clipboard
content might contain some dangerous command and that should always require
user pressing Enter to confirm its execution.
STEPS TO REPRODUCE
1. Open KRunner window
2. type "konsole123"
3. press Enter (nothing will happen)
4. close KRunner by pressing Esc key
5. copy "kcalc" into your clipboard
6. open KRunner window again
7. press Ctrl+V to paste "kcalc" into Krunner
OBSERVED RESULT
Pasted command ("kcalc") will be executed despite user didn't explicitly
allowed that action.
EXPECTED RESULT
Nothing should happen.
--
You are receiving this mail because:
You are watching all bug changes.
[krunner] [Bug 459859] KRunner erroneously executes command when user is deleting input
https://bugs.kde.org/show_bug.cgi?id=459859 --- Comment #2 from phd --- >if you just press and hold Backspace, this bug might not be triggered. however it *will* be triggered once you now enter anything else that has a match, even a suggestion STEPS TO REPRODUCE 1. Open KRunner window 2. type "konsole123" 3. press Enter (nothing will happen) 4. press and hold Backspace until the input is *empty* 5. press "k", it will probably be auto-completed to some random command, and it will be executed (!) 5a. if not, write "kcalc" and it will be executed even without pressing Enter OBSERVED RESULT Random command matching new input (or its auto-complete) is started despite user didn't explicitly allowed that action. EXPECTED RESULT Nothing should happen. -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 459859] KRunner erroneously executes command when user is deleting input
https://bugs.kde.org/show_bug.cgi?id=459859 --- Comment #1 from phd --- >4. start deleting characters with Backspace 4. start deleting characters with Backspace ONE BY ONE if you just press and hold Backspace, this bug might not be triggered. -- You are receiving this mail because: You are watching all bug changes.
