[krunner] [Bug 461424] Add the option to search on the default browser what the user typed if krunner does not have any result

2022-11-30 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=461424

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-workspace/commit/
   ||9cc4255347ed021f4bf30088c34
   ||570e4bf71735f

--- Comment #5 from Nate Graham  ---
Git commit 9cc4255347ed021f4bf30088c34570e4bf71735f by Nate Graham, on behalf
of Alexander Lohnau.
Committed on 30/11/2022 at 15:09.
Pushed by ngraham into branch 'master'.

runners/webshortcuts: Provide result for default provider if no other results
exist

By connecting to the queryFinished signal, we know when all other runners are
done with matching.
After that we can check if there are any matches and if not add a match for the
default provider.

This way we have the advantage of only showing a result when it is relevant.
For example, when we search for apps and get results, the default search engine
result would not be needed.

M  +18   -0runners/webshortcuts/webshortcutrunner.cpp
M  +3-0runners/webshortcuts/webshortcutrunner.h

https://invent.kde.org/plasma/plasma-workspace/commit/9cc4255347ed021f4bf30088c34570e4bf71735f

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 461424] Add the option to search on the default browser what the user typed if krunner does not have any result

2022-11-06 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=461424

--- Comment #4 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2311

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 461424] Add the option to search on the default browser what the user typed if krunner does not have any result

2022-11-06 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=461424

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

--- Comment #3 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2307

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 461424] Add the option to search on the default browser what the user typed if krunner does not have any result

2022-11-04 Thread Natalie Clarius
https://bugs.kde.org/show_bug.cgi?id=461424

--- Comment #2 from Natalie Clarius  ---
I think making use of the existing default search engine setting (where is this
actually used anyway?) in the web shortcuts runner and adding a "Search
 for " result that matches any query but with low
priority would be useful and should be possible to do.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 461424] Add the option to search on the default browser what the user typed if krunner does not have any result

2022-11-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=461424

Nate Graham  changed:

   What|Removed |Added

 CC||natalie_clar...@yahoo.de,
   ||n...@kde.org
Summary|Suggestion : Add the option |Add the option to search on
   |to search on the default|the default browser what
   |browser what the user typed |the user typed if krunner
   |if krunner does not have|does not have any result
   |any result  |

--- Comment #1 from Nate Graham  ---
It really depends on what you were searching for. For example if you were
searching for a local file that wasn't found, then doing a web search is
definitely not going to he helpful, and would leak your personal data.

For that reason we couldn't ever make this an automatic behavior; instead if no
results are found, we could add a synthetic search result that says, "Search
for [search query] on the web". I'm unsure how generically useful this would
actually be, though.

What do you think, Alexander and Natalie?

-- 
You are receiving this mail because:
You are watching all bug changes.