[krusader] [Bug 270150] syncing of files with hashkey as filenamebeginning "#" in krusader deletes the whole directory
https://bugs.kde.org/show_bug.cgi?id=270150 Toni Asensi Esteve changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #18 from Toni Asensi Esteve --- After some conversations (and a review request in https://git.reviewboard.kde.org/r/127287/), this bug was set as fixed thanks to Martin Kostolný. -- You are receiving this mail because: You are watching all bug changes.
[krusader] [Bug 270150] syncing of files with hashkey as filenamebeginning "#" in krusader deletes the whole directory
https://bugs.kde.org/show_bug.cgi?id=270150 --- Comment #17 from Martin Kostolný --- I'm not saying that showing %23 in address path shouldn't be fixed. I just think it should be fixed as a separate commit & bug. -- You are receiving this mail because: You are watching all bug changes.
[krusader] [Bug 270150] syncing of files with hashkey as filenamebeginning "#" in krusader deletes the whole directory
https://bugs.kde.org/show_bug.cgi?id=270150 --- Comment #16 from Martin Kostolný --- Created attachment 97319 --> https://bugs.kde.org/attachment.cgi?id=97319&action=edit patch v2 -- You are receiving this mail because: You are watching all bug changes.
[krusader] [Bug 270150] syncing of files with hashkey as filenamebeginning "#" in krusader deletes the whole directory
https://bugs.kde.org/show_bug.cgi?id=270150
--- Comment #15 from Martin Kostolný ---
Thank you very much for your extensive testing and help. I've tested my use
cases only with sftp. I should have done it with more. So now I created the
same test case as you ("1" and "2" directories with nested "#test#"
contents...).
Surprisingly I didn't run into any problems with sftp and ftp protocols. Even
fish protocol was fine until I used special czech characters such as "č", "ě"
etc. It seems to be a problem with filename encoding and fish protocol. I'll
file a separate bug report for that since dolphin is also affected by this
issue.
You also mentioned %23 text in address bar and tabs. I believe this issue was
already present before applying my patch. Aside from visual effect it should
not have any bad influence in synchronizing directories.
Can you confirm any of my findings
- is sftp working fine?
- was there a special (excluding #) character in your tested fish path?
...or can you please direct me to more specific test case?
Thanks again!
PS: I'm posting a little more polished patch - it should do exactly the same as
the previous one but just to be sure we are testing with the same code. Or
should we continue this in review board?
--
You are receiving this mail because:
You are watching all bug changes.
[krusader] [Bug 270150] syncing of files with hashkey as filenamebeginning "#" in krusader deletes the whole directory
https://bugs.kde.org/show_bug.cgi?id=270150 Toni Asensi Esteve changed: What|Removed |Added CC||seng...@gmail.com --- Comment #14 from Toni Asensi Esteve --- *** Bug 329896 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krusader] [Bug 270150] syncing of files with hashkey as filenamebeginning "#" in krusader deletes the whole directory
https://bugs.kde.org/show_bug.cgi?id=270150 --- Comment #13 from Toni Asensi Esteve --- > let's notice the %23 at the left panel I mean that, as it could be seen in the first screenshot, in the real name of that directory there are no %23 but # -- You are receiving this mail because: You are watching all bug changes.
[krusader] [Bug 270150] syncing of files with hashkey as filenamebeginning "#" in krusader deletes the whole directory
https://bugs.kde.org/show_bug.cgi?id=270150 --- Comment #12 from Toni Asensi Esteve --- Created attachment 97315 --> https://bugs.kde.org/attachment.cgi?id=97315&action=edit If it may help, I attach a screenshot: "After trying to synchronize, in Krusader two folders that could not be synchronized were seen that way; let's notice the %23 at the left panel.png" -- You are receiving this mail because: You are watching all bug changes.
[krusader] [Bug 270150] syncing of files with hashkey as filenamebeginning "#" in krusader deletes the whole directory
https://bugs.kde.org/show_bug.cgi?id=270150 --- Comment #11 from Toni Asensi Esteve --- Created attachment 97314 --> https://bugs.kde.org/attachment.cgi?id=97314&action=edit A case seen with the patch sent by Martin Kostolny Hi, Martin, thank you for your interest, a maintainer for the synchronizer part of Krusader is needed :-) I've tried your patch; although the operations that need to be done are correctly calculated, when applying those operations there are files that are never deleted, I attach a screenshot. I can tell you about the tests that were done, or whatever is necessary. Thank you again for your interest! -- You are receiving this mail because: You are watching all bug changes.
[krusader] [Bug 270150] syncing of files with hashkey as filenamebeginning "#" in krusader deletes the whole directory
https://bugs.kde.org/show_bug.cgi?id=270150 Martin Kostolný changed: What|Removed |Added CC||clearmar...@zoho.com --- Comment #10 from Martin Kostolný --- Created attachment 97242 --> https://bugs.kde.org/attachment.cgi?id=97242&action=edit proposed patch The main idea behind this patch is checking whether QUrl isLocalFile. And if it is not a local file -> escape the uri's "#" character. This logic is done in a separate method so it can be changed from one place and this way applied to all uses throughout Synchronizer code. I'm no Qt guru but I'm willing to maintain Synchronizer part of Krusader since it is currently unmaintained. -- You are receiving this mail because: You are watching all bug changes.
