[krusader] [Bug 372964] At least one Oxygen icon in Krusader is not correctly seen (using Kubuntu 16.04)

[Nikita Melnichenko]

https://bugs.kde.org/show_bug.cgi?id=372964

Nikita Melnichenko  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kru
   ||sader/94ea5b69af14620abd4a4
   ||4a13240ca9b2749641b
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #16 from Nikita Melnichenko  ---
Git commit 94ea5b69af14620abd4a44a13240ca9b2749641b by Nikita Melnichenko.
Committed on 22/04/2018 at 22:00.
Pushed by melnichenko into branch 'master'.

Refactored and unified icon rendering, implemented per-icon fallback logic

Merge branch 'fix-missing-icons'

The merged branch contains implementation of per-icon fallback logic:
1. Search icon in the active icon theme — if found, use it.
2. Search it in the icon theme that is specified in Krusader config — if found,
use it.
3. Search it in Breeze or Oxygen (in case any of these installed) — if found,
use it.
4. Otherwise use a default "icon-missing" icon bundled with Krusader.

FIXED: [ 372964 ] At least one Oxygen icon in Krusader is not correctly seen
(using Kubuntu 16.04)
Related: bug 372966, bug 376699, bug 381676, bug 386554, bug 388691, bug 391899

FIXED: [ 372966 ] Some icons are not seen using a plain Ubuntu (not Kubuntu)
16.04

Differential Revision: https://phabricator.kde.org/D10352

M  +11   -10   krusader/kractions.cpp
M  +2-8krusader/krusader.cpp

https://commits.kde.org/krusader/94ea5b69af14620abd4a44a13240ca9b2749641b

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 372964] At least one Oxygen icon in Krusader is not correctly seen (using Kubuntu 16.04)

[Ganton]

https://bugs.kde.org/show_bug.cgi?id=372964

Ganton  changed:

   What|Removed |Added

 CC||ku...@gmx.com

--- Comment #15 from Ganton  ---
As Andreas Kainz has updated Oxygen icons (very good!), Breeze and Oxygen have
all the icons that Krusader needs, there are more details in:
https://bugs.kde.org/show_bug.cgi?id=388691
   
https://commits.kde.org/oxygen-icons5/857400cb1a51f2287e4b6b285bba0f897066a6f7

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 372964] At least one Oxygen icon in Krusader is not correctly seen (using Kubuntu 16.04)

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=372964

--- Comment #14 from Christoph Feck  ---
The issue is that Breeze uses Oxygen as fallback (because historically, Oxygen
was considered 'complete', whereas Breeze was still evolving), but now the
fallback order should get reversed.

Users that use the Oxygen icons (e.g. me) will probably report it as a bug that
Krusader no longer respects their icon theme choice, but they will understand
that Oxygen is no longer maintained, and with reversed fallback, they would see
a minimal amount of Breeze icons, instead of no icons.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 372964] At least one Oxygen icon in Krusader is not correctly seen (using Kubuntu 16.04)

[Toni Asensi Esteve]

https://bugs.kde.org/show_bug.cgi?id=372964

--- Comment #13 from Toni Asensi Esteve  ---
Just in case: a bug report about the Oxygen icons was created
(https://bugs.kde.org/show_bug.cgi?id=388691)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 372964] At least one Oxygen icon in Krusader is not correctly seen (using Kubuntu 16.04)

[Toni Asensi Esteve]

https://bugs.kde.org/show_bug.cgi?id=372964

--- Comment #12 from Toni Asensi Esteve  ---
I agree, too!

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 372964] At least one Oxygen icon in Krusader is not correctly seen (using Kubuntu 16.04)

[Martin Kostolný]

https://bugs.kde.org/show_bug.cgi?id=372964

Martin Kostolný  changed:

   What|Removed |Added

 CC||clearmar...@zoho.com

--- Comment #11 from Martin Kostolný  ---
> Opinions?

As for me, I agree, Alex. This sounds reasonable. We just have to make sure
that both Breeze and Breeze Dark will work correctly, but that will probably be
no problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 372964] At least one Oxygen icon in Krusader is not correctly seen (using Kubuntu 16.04)

[Alex Bikadorov]

https://bugs.kde.org/show_bug.cgi?id=372964

--- Comment #10 from Alex Bikadorov  ---
Well, if there are icons missing in Oxygen (or any other icon theme) which are
needed by Krusader, it is more a general problem.

I have thought about solving this and Bug 372966:

Two assumptions I take for granted:
* there should never be missing icons for any actions/buttons in the UI. It
simply should not occur in any modern application.
* mixing different icon sets in one application is just ugly and should also
never happen. I can't even remember I have ever seen this anywhere.

And I am really against taking files from another project (Breeze) and copying
them into our project. This is an ugly design decision and leads to more work:
figuring out which icons we need, which icons are obsolete, which icons changed
and need to be updated.

What's left is this (and only this) solution: We make Breeze an official
dependency of Krusader. Because it is the only icon set which contains all
needed icons. And we force using Breeze as icon set if it is installed in the
code; regardless of what the user has set as icon set.
And optionally: Show a warning message on Krusader startup if Breeze is not
installed. Because in this case icons will be missing and the user maybe does
not know why.

Opinions?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 372964] At least one Oxygen icon in Krusader is not correctly seen (using Kubuntu 16.04)

[Toni Asensi Esteve]

https://bugs.kde.org/show_bug.cgi?id=372964

--- Comment #9 from Toni Asensi Esteve  ---
Thank you for your comments, Alex!

> If this bug is about Krusader using icons only included in Breeze, this is 
> what 372966 is about.

> If there are icon-names is Oxygen which are somehow not used by Krusader it 
> would be different though.

After all that has been discussed, it seems that there are those problems:
- Oxygen not having all the icons that Breeze has and Krusader uses (like
"edit-select-none");
- Oxygen having a "edit-select" icon that shows only a generic image of a
mouse arrow, unlike its Breeze equivalent, which shows a mouse arrow and a
distinctive little circle.

And maybe Krusader is doing a good job by not mixing Oxygen and Breeze icons.
So this bug report would not be a 372966 duplicate, but a bug about the Oxygen
icons and Krusader.

Additionally somebody else could think that it would be better that Krusader
would include Breeze icons as fallback in the Krusader package (though it would
look ugly with other themes), then somebody could write here his opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 372964] At least one Oxygen icon in Krusader is not correctly seen (using Kubuntu 16.04)

[Alex Bikadorov]

https://bugs.kde.org/show_bug.cgi?id=372964

--- Comment #8 from Alex Bikadorov  ---
@Toni
if you agree, I would like to set this report as a duplicate of Bug 372966. If
this bug is about Krusader using icons only included in Breeze, this is what
372966 is about.
If there are icon-names is Oxygen which are somehow not used by Krusader it
would be different though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 372964] At least one Oxygen icon in Krusader is not correctly seen (using Kubuntu 16.04)

[Alex Bikadorov]

https://bugs.kde.org/show_bug.cgi?id=372964

Alex Bikadorov  changed:

   What|Removed |Added

 CC||freeslav...@gmail.com

--- Comment #7 from Alex Bikadorov  ---
*** Bug 381676 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 372964] At least one Oxygen icon in Krusader is not correctly seen (using Kubuntu 16.04)

[Toni Asensi Esteve]

https://bugs.kde.org/show_bug.cgi?id=372964

Toni Asensi Esteve  changed:

   What|Removed |Added

 CC||kain...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 372964] At least one Oxygen icon in Krusader is not correctly seen (using Kubuntu 16.04)

[Alex Bikadorov]

https://bugs.kde.org/show_bug.cgi?id=372964

Alex Bikadorov  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||alex.bikado...@kdemail.net
 Ever confirmed|0   |1

--- Comment #6 from Alex Bikadorov  ---
"edit-select-none" and "edit-select-invert" are only included in Breeze and not
standard icon names (see
https://specifications.freedesktop.org/icon-naming-spec/0.8/ar01s04.html).

Sooo what should we do? I really don't know.

* change the icon names to standard ones (i couldn't find something suitable)
* include these breeze icons as fallback in the Krusader package (will look
ugly with other themes)
* do nothing (always a lazy option)

?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 372964] At least one Oxygen icon in Krusader is not correctly seen (using Kubuntu 16.04)

[Toni Asensi Esteve]

https://bugs.kde.org/show_bug.cgi?id=372964

--- Comment #5 from Toni Asensi Esteve  ---
Information about the icons:

In the source code of Krusader, in the viewactions.cpp file, we can see:
actSelect = action(i18n("Select "), "edit-select", Qt::CTRL +
Qt::Key_Plus, SLOT(markGroup()), "select group");
actSelectAll = action(i18n(" All"), "edit-select-all", Qt::ALT +
Qt::Key_Plus, SLOT(markAll()), "select all");
[...]
actUnselectAll = action(i18n("U All"), "edit-select-none", Qt::ALT
+ Qt::Key_Minus, SLOT(unmarkAll()), "unselect all");
and therefore we can see that each action has to have a related icon
("edit-select", "edit-select-all" and "edit-select-none"). 

It it's executed 
$ find / -iname "*edit-select.*" 2>/dev/null
/usr/share/icons/breeze-dark/actions/22/edit-select.svg
/usr/share/icons/breeze-dark/actions/16/edit-select.svg
/usr/share/icons/breeze-dark/actions/24/edit-select.svg
/usr/share/icons/breeze/actions/22/edit-select.svg
/usr/share/icons/breeze/actions/16/edit-select.svg
/usr/share/icons/breeze/actions/24/edit-select.svg
/usr/share/icons/oxygen/16x16/actions/edit-select.png
/usr/share/icons/oxygen/22x22/actions/edit-select.png
/usr/share/icons/oxygen/48x48/actions/edit-select.png
/usr/share/icons/oxygen/32x32/actions/edit-select.png
then we can see that there are Oxygen icons for "edit-select" (altough they
show only a generic image of a mouse arrow, unlike its Breeze equivalent, which
shows a mouse arrow and a distinctive little circle).

If using Kubuntu 16.04 it's executed
$ find / -iname "*edit-select-all*" 2>/dev/null
/usr/share/icons/Adwaita/scalable/actions/edit-select-all-symbolic.svg
/usr/share/icons/Humanity/actions/48/edit-select-all.svg
/usr/share/icons/Humanity/actions/22/edit-select-all.svg
/usr/share/icons/Humanity/actions/16/edit-select-all.svg
/usr/share/icons/Humanity/actions/24/edit-select-all.svg
/usr/share/icons/breeze-dark/actions/22/edit-select-all.svg
/usr/share/icons/breeze-dark/actions/16/edit-select-all.svg
/usr/share/icons/breeze-dark/actions/16/edit-select-all-layers.svg
/usr/share/icons/breeze-dark/actions/24/edit-select-all.svg
/usr/share/icons/breeze/actions/22/edit-select-all.svg
/usr/share/icons/breeze/actions/16/edit-select-all.svg
/usr/share/icons/breeze/actions/16/edit-select-all-layers.svg
/usr/share/icons/breeze/actions/24/edit-select-all.svg
/usr/share/icons/oxygen/16x16/actions/edit-select-all.png
/usr/share/icons/oxygen/22x22/actions/edit-select-all.png
/usr/share/icons/oxygen/48x48/actions/edit-select-all.png
/usr/share/icons/oxygen/32x32/actions/edit-select-all.png
then we can see that there are Oxygen icons for "edit-select-all".

It it's executed 
$ find / -iname "*edit-select-none*" 2>/dev/null
/usr/share/icons/breeze-dark/actions/22/edit-select-none.svg
/usr/share/icons/breeze-dark/actions/16/edit-select-none.svg
/usr/share/icons/breeze-dark/actions/24/edit-select-none.svg
/usr/share/icons/breeze/actions/22/edit-select-none.svg
/usr/share/icons/breeze/actions/16/edit-select-none.svg
/usr/share/icons/breeze/actions/24/edit-select-none.svg
then we can see that there are not Oxygen icons for "edit-select-none".

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 372964] At least one Oxygen icon in Krusader is not correctly seen (using Kubuntu 16.04)

[Toni Asensi Esteve]

https://bugs.kde.org/show_bug.cgi?id=372964

Toni Asensi Esteve  changed:

   What|Removed |Added

Summary|icon|At least one Oxygen icon in
   ||Krusader is not correctly
   ||seen (using Kubuntu 16.04)

-- 
You are receiving this mail because:
You are watching all bug changes.