[krusader] [Bug 410120] Krusader pays no attention to the "Follow links" checkbox when searching. (This looks like a regression)

2019-07-31 Thread Toni Asensi Esteve
https://bugs.kde.org/show_bug.cgi?id=410120

Toni Asensi Esteve  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
  Latest Commit||https://commits.kde.org/kru
   ||sader/ce1941db1d8e9f5c5b6ea
   ||292cefca97e40f5e7d8
 Resolution|--- |FIXED

--- Comment #7 from Toni Asensi Esteve  ---
Git commit ce1941db1d8e9f5c5b6ea292cefca97e40f5e7d8 by Toni Asensi Esteve.
Committed on 01/08/2019 at 05:38.
Pushed by asensi into branch 'master'.

Achieve that Krusader searches correctly if the "Follow links" checkbox is
disabled

FIXED: [ 410120 ] Krusader does not search correctly if the "Follow links"
checkbox is disabled

Differential Revision: https://phabricator.kde.org/D22666

M  +1-1krusader/Search/krsearchmod.cpp

https://commits.kde.org/krusader/ce1941db1d8e9f5c5b6ea292cefca97e40f5e7d8

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 410120] Krusader pays no attention to the "Follow links" checkbox when searching. (This looks like a regression)

2019-07-22 Thread Toni Asensi Esteve
https://bugs.kde.org/show_bug.cgi?id=410120

--- Comment #6 from Toni Asensi Esteve  ---
There's a proposed solution in https://phabricator.kde.org/D22666

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 410120] Krusader pays no attention to the "Follow links" checkbox when searching. (This looks like a regression)

2019-07-22 Thread Toni Asensi Esteve
https://bugs.kde.org/show_bug.cgi?id=410120

--- Comment #5 from Toni Asensi Esteve  ---
If it can help: the bug effects were seen after the commit
53913d8f92e58b8c7bd4dcbc9192610b6b230373 , maybe seeing its changes
(https://cgit.kde.org/krusader.git/commit/?id=53913d8f92e58b8c7bd4dcbc9192610b6b230373)
gives a clue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 410120] Krusader pays no attention to the "Follow links" checkbox when searching. (This looks like a regression)

2019-07-22 Thread Toni Asensi Esteve
https://bugs.kde.org/show_bug.cgi?id=410120

--- Comment #4 from Toni Asensi Esteve  ---
Note: The results of the last screenshot were that way even if the "Follow
links" checkbox was disabled.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 410120] Krusader pays no attention to the "Follow links" checkbox when searching. (This looks like a regression)

2019-07-22 Thread Toni Asensi Esteve
https://bugs.kde.org/show_bug.cgi?id=410120

--- Comment #3 from Toni Asensi Esteve  ---
Created attachment 121686
  --> https://bugs.kde.org/attachment.cgi?id=121686=edit
This is what happens after the bug started to show its effects.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 410120] Krusader pays no attention to the "Follow links" checkbox when searching. (This looks like a regression)

2019-07-22 Thread Toni Asensi Esteve
https://bugs.kde.org/show_bug.cgi?id=410120

--- Comment #2 from Toni Asensi Esteve  ---
Created attachment 121685
  --> https://bugs.kde.org/attachment.cgi?id=121685=edit
After Enter was pressed, those were the results.

Note: In that screenshot the first result is highlighted, that focus allows
users to start using immediately e.g. the arrow keys, F3, F4, etc. This doesn't
happen nowadays, but that's the effect of another bug
(https://bugs.kde.org/show_bug.cgi?id=410118).

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 410120] Krusader pays no attention to the "Follow links" checkbox when searching. (This looks like a regression)

2019-07-22 Thread Toni Asensi Esteve
https://bugs.kde.org/show_bug.cgi?id=410120

--- Comment #1 from Toni Asensi Esteve  ---
Created attachment 121684
  --> https://bugs.kde.org/attachment.cgi?id=121684=edit
Using the test folder: this is a screenshot of the beginning of a search (with
the "Follow links" checkbox disabled), before the bug started to show its
effects.

-- 
You are receiving this mail because:
You are watching all bug changes.