https://bugs.kde.org/show_bug.cgi?id=419396
Toni Asensi Esteve changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/kru
||sader/b4e016807f5c334fce253
||179a38925a5667c0563
Status|REPORTED|RESOLVED
Resolution|--- |FIXED
--- Comment #2 from Toni Asensi Esteve ---
Git commit b4e016807f5c334fce253179a38925a5667c0563 by Toni Asensi Esteve.
Committed on 15/04/2020 at 22:38.
Pushed by asensi into branch 'master'.
Archives: Fix a 7z execution, allow password asking, clarify the name of a
function
In Krusader, nowadays it turns out that in
`kio_krarcProtocol::checkIf7zIsEncrypted()`: 7z is executed with a " t -y "
argument, instead of being executed with two arguments, therefore the execution
fails. To avoid that, a simple change can be made.
In more detail: After applying the proposed changes, a 7z execution is left as
other places are in the Krusader source code like in
`KRarcHandler::checkIf7zIsEncrypted(bool &encrypted, QString fileName)`:
proc << KrServices::fullPathName("7z") << "-y" << "t";
or `KRarcHandler::arcFileCount(const QString& archive, const QString& type,
const QString& password, KRarcObserver *observer)`:
else if (type == "7z") lister << KrServices::fullPathName("7z") << "-y" <<
"l";
After the change is applied, at least an improvement is seen: when the user
tries to enter a compressed 7z file, its password is asked.
Besides:
- A `checkOutputForPassword()` function that was used (and useful) only for
7z files was renamed as `check7zOutputForPassword()`.
Test plan: The one described in the task [Solve some bugs related to archives,
remove some duplicated code](https://phabricator.kde.org/T12876).
FIXED: [ 419396 ] When trying to open a 7z encrypted archive, Krusader does not
ask for a password
Differential Revision: https://phabricator.kde.org/D28411
M +3-4krArc/krarc.cpp
M +1-1krArc/krarc.h
https://commits.kde.org/krusader/b4e016807f5c334fce253179a38925a5667c0563
--
You are receiving this mail because:
You are watching all bug changes.
